From patchwork Mon Jan 15 05:11:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10163061 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83319601C0 for ; Mon, 15 Jan 2018 05:11:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B27A287B2 for ; Mon, 15 Jan 2018 05:11:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FC56287E9; Mon, 15 Jan 2018 05:11:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EA01287B2 for ; Mon, 15 Jan 2018 05:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750899AbeAOFLI (ORCPT ); Mon, 15 Jan 2018 00:11:08 -0500 Received: from merlin.infradead.org ([205.233.59.134]:35656 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbeAOFLH (ORCPT ); Mon, 15 Jan 2018 00:11:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Cc:To:Subject:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+v6GJokB6e0Q6nrJbcfSnYzxifdTPc6jvtkgcy6TNQw=; b=L2SFDMHY/iKWbsCqVGFjabDzQy Ox3szEn/jrHjggkY9EIQe+4n4PL2vZz3IVjG/bfagHRpzeUb6HLVCpYT/rSUlsjfYy8543p5clj7t UovqrlTprjJulAZJCbuRsjmFfAfF0hmCMT8PUNwouODZO4FP/BEhuBK+qDxk8GkTNdjsIX+TfEAVn SEfjos2mdFVDIBiDn44a7H2X3qWP9dDqwNlLusw11toDqC7uAxFBta2imKcy06JmdPPmdPQmrUcuX 5x8cnkKJTmNs4/5fqayRiLn4usYCGbxflhmKA7nfgzbU0YP6/sBvaFBSepYB/48JKrpBDCtzkn+Cb DD1pE7eg==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1eax34-0003pi-2k; Mon, 15 Jan 2018 05:11:06 +0000 From: Randy Dunlap Subject: [PATCH] iio/adc: depend on SYSFS instead of selecting it To: linux-iio@vger.kernel.org, LKML Cc: Jonathan Cameron Message-ID: Date: Sun, 14 Jan 2018 21:11:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all IIO drivers consistent w.r.t depending on SYSFS instead of selecting it. Signed-off-by: Randy Dunlap Cc: Jonathan Cameron Cc: linux-iio@vger.kernel.org --- drivers/iio/adc/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- lnx-415-rc8.orig/drivers/iio/adc/Kconfig +++ lnx-415-rc8/drivers/iio/adc/Kconfig @@ -144,10 +144,9 @@ config ASPEED_ADC config AT91_ADC tristate "Atmel AT91 ADC" depends on ARCH_AT91 - depends on INPUT + depends on INPUT && SYSFS select IIO_BUFFER select IIO_TRIGGERED_BUFFER - select SYSFS help Say yes here to build support for Atmel AT91 ADC.