From patchwork Mon Mar 31 08:02:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14033223 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C6E369D2B; Mon, 31 Mar 2025 08:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743408185; cv=none; b=hTvsMNZjIDKXDPNlVBkIvu8jW3NVeXNlirbQ/7UBaMRBwbEd4BdCRcZ9GFMiY6SqoQd74UownJzKkoMehy2AqLFhQFNT74yESEf4FKn/+E3qHuUGrYv5EDLDqHt2KLJ5KxFtDTYuYJzPqSmSdVZ524Yb2aG5nYHOSa6ubp6mrr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743408185; c=relaxed/simple; bh=YVpuM7dgprbv0GtfP/fGAJUobt+5qb7gbFBGxfO11jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GFY188hqZ8qwRBM56laX0jfcltxWhTBBgNtQvv2QOy57ay1KjrvHIqbzVv6gyOdN28ioTR7KFyeewMuuy8TsDeNb7FIVjuGBw+/ZrsBotPRsiWTAJH9c54WgfJs+Imj36rn6cD/v3iHnt4i72sZfKY56/h41fDlZ1iQOfPDFegA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WIHiVysw; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIHiVysw" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-30bf1d48843so36268851fa.2; Mon, 31 Mar 2025 01:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743408181; x=1744012981; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aBHwZqJRLeUXbeecOEQfFgkEOpXTE6ey+sc5tdVEuRw=; b=WIHiVyswkZO3GJ3cj214zxSzac0yIfmlefuANqwBuIVt7nd0WkIqSsq1/veswIC5gY ep8d+AzFxt5tUltuv0RcSHYulwSeHab1Kz1yxsA/F+yN+tvqEglsJSsQuF18SgPXI+EY GFHDSnvGHfDkbcjpEGxAWIYe4AcwUyLemht4kPlGabhuUbppsWKyMNt8dBpytCnAmmp6 aSzLEBS9SiknT3I+oXDX7niK2jKPMa4pVypK2ff/9OnLuhV3lXeWoYm51Yav7RN85mUe s6rkAMXL9ocRGI3C8ti+vVcdSAXAyvYW+eDYX+No84f7+ts7lXrbhGU9S7Vwhtq6U3sZ uhZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743408181; x=1744012981; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aBHwZqJRLeUXbeecOEQfFgkEOpXTE6ey+sc5tdVEuRw=; b=s84w4aU+M/tm71PnEMQoUngd/VKk4RqjYeDxH2iGmNId0ZZe9Zo/qOs+wrb/KMf/rH jYzzVk9Witreyva/YY6lSNt2znn3R9Hx42h54S+8KGpMAk2hhwBIOEMVZbZ6w7Nn117M nxdxj6QxfyaiFElW0QBwVwXNrVOzzdUpZ1kojZ8OHMKaHBP+Wf+teX9/PiALirBWX3YA /pFcS/JzxRnQ6/60rKF4h8W/neC/NoXA68M9bGEsJ+C1REsLzAZWQITUJfNlqQGYzUz+ JiU01qF4YXoRYVRlG2ZxSzh4h7vYeJLqql6oa8dP+BpspLVtz/pSqs+7BCjGuVgblkYa htuQ== X-Forwarded-Encrypted: i=1; AJvYcCV7ylJKHS1BBbeX4E6XjIadO8kmFzt0CWtO/VoM3miCQhOkGeCikbzjl2uZEqmNwVvTz/wE77FiIDjUxUSm@vger.kernel.org, AJvYcCVZnJOD2PZSxDsTe3Df3LBVj4U8C0Xn9dNv+y+I6MgZs+KfOHcxuAsDcNgEbO9DPyVk6DDOcj4qKaRZ@vger.kernel.org, AJvYcCXEORQBfvwafUCClrV0V51DsnSt693vpeF3BMyWfxFmZmcDRJKXxNN1nBuNyHvHxff4sFtEqPzNSWXY@vger.kernel.org X-Gm-Message-State: AOJu0YxB6LX02PG2yEdYkINaA/l3mqBKcWfXHBlhAfFYE+NgPs+hEAU2 8JmY2DX9hgEM2//Uj0daJ7TjyQO8xUe+V5tqbC/KJP7zrnEggV08 X-Gm-Gg: ASbGncvlJFKc4RqRbqDgpH0j9iBOnNr/P+9rvn2XOH0uKeL8eli9Tl7LHYRKKVtCbB8 MOIxySwUAkvbdXiytJEllEKI+PI2MFmG6EEDh1uBukHrlgUsvuYFpLEusciQu7WBK1Tx2wee+RW 3Uowr19xoIpYjOedpMBWEQTavMEt1OZo2xdt1uvhMgGFymvo+IW9kS06y+ALmlIjEfleEZyVQ7r zoEuYMVDTA78GB/kVE5x3fz54XaEIgDAPWzoBlpEDz9TPV1u2mGrafS7c+Z9N3CTsNcBIHXHYyP eLH3CgvMmT2Fv6igHaxRixSj7MruC8WBR6OnDDj9i64X6Qc/Gx0= X-Google-Smtp-Source: AGHT+IF9Wc+i1DLmHJJAa6vLgUpDGzaBiNozHNoAChuyMtEChf9NIyjq49qgbM/np31OKjekneIscQ== X-Received: by 2002:a2e:b88a:0:b0:30d:e104:b67d with SMTP id 38308e7fff4ca-30de104b897mr22059131fa.40.1743408181301; Mon, 31 Mar 2025 01:03:01 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30dd2b5983fsm13354411fa.98.2025.03.31.01.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 01:03:00 -0700 (PDT) Date: Mon, 31 Mar 2025 11:02:55 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Nuno Sa , David Lechner , Javier Carrasco , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] iio: adc: ti-adc128s052: Fix ADC value on BE systems Message-ID: References: Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: ADCs supported by the ti-adc128s052 driver do return the ADC data in 16 bits using big-endian format. The driver does unconditionally swap the bytes. This leads to wrong values being reported to users on big endian systems. Fix this by using the be16_to_cpu() instead of doing unconditional byte swapping. Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052") Cc: stable@vger.kernel.org Signed-off-by: Matti Vaittinen --- I have no big endian machines on my hands to test this. Problem was spotted by reading the code, which leaves some room for errors. Careful reviewing is appreciated! --- drivers/iio/adc/ti-adc128s052.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index a456ea78462f..d1e31122ea0d 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -28,19 +28,20 @@ struct adc128 { struct regulator *reg; struct mutex lock; - u8 buffer[2] __aligned(IIO_DMA_MINALIGN); + __be16 buffer __aligned(IIO_DMA_MINALIGN); }; static int adc128_adc_conversion(struct adc128 *adc, u8 channel) { int ret; + char *msg = (char *)&adc->buffer; - mutex_lock(&adc->lock); + msg[0] = channel << 3; + msg[1] = 0; - adc->buffer[0] = channel << 3; - adc->buffer[1] = 0; + mutex_lock(&adc->lock); - ret = spi_write(adc->spi, &adc->buffer, 2); + ret = spi_write(adc->spi, msg, 2); if (ret < 0) { mutex_unlock(&adc->lock); return ret; @@ -53,7 +54,7 @@ static int adc128_adc_conversion(struct adc128 *adc, u8 channel) if (ret < 0) return ret; - return ((adc->buffer[0] << 8 | adc->buffer[1]) & 0xFFF); + return be16_to_cpu(adc->buffer) & 0xFFF; } static int adc128_read_raw(struct iio_dev *indio_dev,