From patchwork Sun Mar 18 13:35:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Veenstra X-Patchwork-Id: 10291163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1435B600F6 for ; Sun, 18 Mar 2018 13:35:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0393528E11 for ; Sun, 18 Mar 2018 13:35:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EACAD2900F; Sun, 18 Mar 2018 13:35:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6377B28E11 for ; Sun, 18 Mar 2018 13:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbeCRNfu (ORCPT ); Sun, 18 Mar 2018 09:35:50 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:40633 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbeCRNfu (ORCPT ); Sun, 18 Mar 2018 09:35:50 -0400 Received: by mail-wm0-f66.google.com with SMTP id t6so10823663wmt.5 for ; Sun, 18 Mar 2018 06:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xsrGdsRAp6769DuCagNQ01okxpRInqlsYuK0SFOak2A=; b=L/7sF6+ZGOcRTH14xu5wbiBEuoqMw4ulbkHCvoC3dO/19i54TBO7FYguNoTWIQHG6e LuifOJbULkFMCFlB2eNXT84Qx3xGGhJHwY9DArC3iMTAJI3r44+PsuleDOWgVrjVRNjX yHLJ/eH31p1fQsHZ5Pc8IgQBsaSpLdMELpIJuOsjVukjF+D1u9RMzAusxy5+/OOVbW8p hy1J7zOt61TT8GVtMorVuvaqqb8kQGuKdP9S2b9ua6Y3kWC80U/h2KnMrV4hpymjzPDV s2LfyKzTDwxRcR6zPyxv5UduyRK0vBu8+t31qVfpwADSZDh8zwMbshXJ52T1XyY0fqsY vTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xsrGdsRAp6769DuCagNQ01okxpRInqlsYuK0SFOak2A=; b=abQ/kRVLHrlL25LnUbNnZCC/It7IyUBVHhpuX1vQiLmG/aWiNwkUkawMQLOqTkgxWr fsFgi1Cbd6+8JeZmojOGaLfKxWFSsJSpwVqMi82lR5Zv/7dOQeaUMsPRUEfdX+sdu1GR woSFEV+/xGlIh9tvvQXunWp5H6no0F73wtldb5I7xffLqYNa96zjhtRNGecG+4+7/mYm QrVn2kR3a03BGnDd+szrqSmQuaeL2O9+tRYqpK2YEGq/L8Aw3qrHYjWJtRv7UBbCwQzb EZRP5hfOhU/kEGmm1nXc5IkW05a04eoP20Acvzpzdew8EZypazU5iixmBHnZffnspEgS u/Qg== X-Gm-Message-State: AElRT7FGffTgAMNCKhVdrRDRreMKdBH5SuiAV4xL+RQbH8z3icDkSv8b M2lzPaVKaz5xxVbdo/vIVko= X-Google-Smtp-Source: AG47ELvvxg5dYNJBzk/fHOLJtF0edLwlEPSA2jFtf48kRFikhk1wrZYXJ9tRRgUgvJQAJ7wo8qQXfA== X-Received: by 10.80.226.66 with SMTP id o2mr9758354edl.248.1521380149141; Sun, 18 Mar 2018 06:35:49 -0700 (PDT) Received: from zenbook-arch (s559434a1.adsl.online.nl. [85.148.52.161]) by smtp.gmail.com with ESMTPSA id p7sm7591939edc.20.2018.03.18.06.35.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 06:35:48 -0700 (PDT) Date: Sun, 18 Mar 2018 14:35:46 +0100 From: David Veenstra To: lars@metafoo.de, jic23@kernel.org Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH 05/11] staging: iio: ad2s1200: Introduce variable for repeated value Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly used in ad2s1200_probe. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index 00efba598671..eceb86e952de 100644 --- a/drivers/staging/iio/resolver/ad2s1200.c +++ b/drivers/staging/iio/resolver/ad2s1200.c @@ -118,19 +118,22 @@ static int ad2s1200_probe(struct spi_device *spi) unsigned short *pins = spi->dev.platform_data; struct ad2s1200_state *st; struct iio_dev *indio_dev; + struct device *dev; int pn, ret = 0; + dev = &spi->dev; + for (pn = 0; pn < AD2S1200_PN; pn++) { - ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT, + ret = devm_gpio_request_one(dev, pins[pn], GPIOF_DIR_OUT, DRV_NAME); if (ret) { - dev_err(&spi->dev, "request gpio pin %d failed\n", + dev_err(dev, "request gpio pin %d failed\n", pins[pn]); return ret; } } - indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; @@ -141,14 +144,14 @@ static int ad2s1200_probe(struct spi_device *spi) st->sample = pins[0]; st->rdvel = pins[1]; - indio_dev->dev.parent = &spi->dev; + indio_dev->dev.parent = dev; indio_dev->info = &ad2s1200_info; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = ad2s1200_channels; indio_dev->num_channels = ARRAY_SIZE(ad2s1200_channels); indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(&spi->dev, indio_dev); + ret = devm_iio_device_register(dev, indio_dev); if (ret) return ret;