| Message ID | d979a0a8160118d560ba2255346d05237f73b9ce.1731495937.git.mazziesaccount@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support ROHM KX134ACR-LBZ | expand |
On Wed, Nov 13, 2024 at 01:20:49PM +0200, Matti Vaittinen wrote: > Add compatible and information for ROHM KX134ACR-LBZ accelerometer. The commit message mention what makes this device incompatible - but I'll let you away with it the description below contains it. Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > --- > .../devicetree/bindings/iio/accel/kionix,kx022a.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml > index 66ea894dbe55..c973f4941a6d 100644 > --- a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml > @@ -11,7 +11,8 @@ maintainers: > > description: | > KX022A, KX132ACR-LBZ and KX132-1211 are 3-axis accelerometers supporting > - +/- 2G, 4G, 8G and 16G ranges, variable output data-rates and a > + +/- 2G, 4G, 8G and 16G ranges. The KX134ACR-LBZ supports +/- 8G, 16G, > + 32G and 64G. All the sensors also have variable output data-rates and a > hardware-fifo buffering. These accelerometers can be accessed either > via I2C or SPI. > > @@ -21,6 +22,7 @@ properties: > - kionix,kx022a > - kionix,kx132-1211 > - rohm,kx132acr-lbz > + - rohm,kx134acr-lbz > > reg: > maxItems: 1 > -- > 2.47.0 >
On 14/11/2024 22:10, Conor Dooley wrote: > On Wed, Nov 13, 2024 at 01:20:49PM +0200, Matti Vaittinen wrote: >> Add compatible and information for ROHM KX134ACR-LBZ accelerometer. > > The commit message mention what makes this device incompatible - but > I'll let you away with it the description below contains it. > Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks for pointing it out Conor. I agree the commit message should describe the KX134ACR-LBZ a bit better. I'll improve the commit message to include the g-range difference if I re-spin this series - and try to remember this if I get to support also some other variants :) A very good head's up for me as I didn't even think of describing the differences in commit message! Yours, -- Matti
diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml index 66ea894dbe55..c973f4941a6d 100644 --- a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml @@ -11,7 +11,8 @@ maintainers: description: | KX022A, KX132ACR-LBZ and KX132-1211 are 3-axis accelerometers supporting - +/- 2G, 4G, 8G and 16G ranges, variable output data-rates and a + +/- 2G, 4G, 8G and 16G ranges. The KX134ACR-LBZ supports +/- 8G, 16G, + 32G and 64G. All the sensors also have variable output data-rates and a hardware-fifo buffering. These accelerometers can be accessed either via I2C or SPI. @@ -21,6 +22,7 @@ properties: - kionix,kx022a - kionix,kx132-1211 - rohm,kx132acr-lbz + - rohm,kx134acr-lbz reg: maxItems: 1
Add compatible and information for ROHM KX134ACR-LBZ accelerometer. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- .../devicetree/bindings/iio/accel/kionix,kx022a.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)