From patchwork Sun Mar 18 13:35:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Veenstra X-Patchwork-Id: 10291165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7824060385 for ; Sun, 18 Mar 2018 13:36:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67DD328E11 for ; Sun, 18 Mar 2018 13:36:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C4E82900F; Sun, 18 Mar 2018 13:36:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C8D8128E11 for ; Sun, 18 Mar 2018 13:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbeCRNgC (ORCPT ); Sun, 18 Mar 2018 09:36:02 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:52140 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbeCRNgB (ORCPT ); Sun, 18 Mar 2018 09:36:01 -0400 Received: by mail-wm0-f67.google.com with SMTP id h21so10721274wmd.1 for ; Sun, 18 Mar 2018 06:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2qz2ZOOY1/eWBCP1ftCzMbX3pMCDnqL5sR2rtr8kezg=; b=YJZ9ihNSqYIUYz42qgTiBU53ff+BByollA2xyuTYTGzk+N5tTwdGadV/3eirXV9W2u aflFtFr5v2jevtyNEDHzvGIZapO4U5hv3JiyKsorrti6hb5mhUegdhkzHGOs4tbIYQOu 0eKfaMBBVMko9OdLzOqqgR9m85zkSiZD0nQtTyxr1GsIKOeoFhOv2VCaJhf6SeT6RYji RhnXUr1EWezyTz3AdGBda180LkrgrJGZ3+bu6n2PGoPFCiqMC7uysv9g7Hy7zf+lSuWs Y4mAHGDKZ28F1wR0//wss9uFIYqZCv1LQ2ueKzT4Z16LOEJyJcwZNV5MAEr74M7T0+MY 7PWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2qz2ZOOY1/eWBCP1ftCzMbX3pMCDnqL5sR2rtr8kezg=; b=jBePQQNs45dnDmtfmOKaH/UiokEytEMnaLNw6h1h8nCfQohwDDDh0k+ZJdM6kjfi6a E1jylh4w5N9j2jJngDPg+3AVoK631TZ/YIzhrL7CCjTrRSZaxI2fjNM7fQEFLZi4ATaE exDz2IJjIOP8gDTgi1fckvaAW6MkDl66cgyZ6Gofi6L+c4zEINYWPJtU0fGjl7cMmo0s fkQL3YasQ7YRWP1O2e840XCireTlI4PDM8QIyriSj9dv839iLtLmVfxlnDbQPus7pcMx jXM644p7Oxf8BA+TGLgfvsFkAOpiazJTaOouVt6LhdaxxF0/fMlVFVxVT4V6mojCuoOo C9Aw== X-Gm-Message-State: AElRT7F76QAPkPoLNyJWNxuG2vMUJABCSLlslejC1aYNQMHgkxse7iUn 4MGCaRUUF+hHNGYwqFaqA0w= X-Google-Smtp-Source: AG47ELs/3onLjBXZcUEfcJ6ArGceqlHG1kiDBAXKpVuJIoE0LgRSC3tyBIp7sRijzb4L5cuN/Bq65A== X-Received: by 10.80.149.3 with SMTP id u3mr10014971eda.212.1521380160768; Sun, 18 Mar 2018 06:36:00 -0700 (PDT) Received: from zenbook-arch (s559434a1.adsl.online.nl. [85.148.52.161]) by smtp.gmail.com with ESMTPSA id l91sm6612202edl.4.2018.03.18.06.35.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 06:36:00 -0700 (PDT) Date: Sun, 18 Mar 2018 14:35:58 +0100 From: David Veenstra To: lars@metafoo.de, jic23@kernel.org Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH 06/11] staging: iio: ad2s1200: Improve readability with be16_to_cpup Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The manual states that the data is contained in the upper 12 bits of the 16 bits read by spi. The code that extracts these 12 bits is correct for both be and le machines, but this is not clear from a first glance. To improve readability the relevant expressions are replaced with equivalent expressions that use be16_to_cpup. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index eceb86e952de..e0e7c88368ed 100644 --- a/drivers/staging/iio/resolver/ad2s1200.c +++ b/drivers/staging/iio/resolver/ad2s1200.c @@ -58,7 +58,7 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev, { struct ad2s1200_state *st = iio_priv(indio_dev); int ret = 0; - s16 vel; + u16 vel; mutex_lock(&st->lock); gpio_set_value(st->sample, 0); @@ -74,14 +74,13 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev, return ret; } + vel = be16_to_cpup((__be16 *)st->rx); switch (chan->type) { case IIO_ANGL: - *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); + *val = vel >> 4; break; case IIO_ANGL_VEL: - vel = (((s16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - vel = sign_extend32(vel, 11); - *val = vel; + *val = sign_extend32((s16)vel >> 4, 11); break; default: mutex_unlock(&st->lock);