| Message ID | 20190416202013.4034148-1-arnd@arndb.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | compat_ioctl: cleanups | expand |
On 2019-04-16 4:19 p.m., Arnd Bergmann wrote: > Hi Al, > > It took me way longer than I had hoped to revisit this series, see > https://lore.kernel.org/lkml/20180912150142.157913-1-arnd@arndb.de/ > for the previously posted version. > > I've come to the point where all conversion handlers and most > COMPATIBLE_IOCTL() entries are gone from this file, but for > now, this series only has the parts that have either been reviewed > previously, or that are simple enough to include. > > The main missing piece is the SG_IO/SG_GET_REQUEST_TABLE conversion. > I'll post the patches I made for that later, as they need more > testing and review from the scsi maintainers. Perhaps you could look at the document in this url: http://sg.danny.cz/sg/sg_v40.html It is work-in-progress to modernize the SCSI generic driver. It extends ioctl(sg_fd, SG_IO, &pt_obj) to additionally accept the sg v4 interface as defined in include/uapi/linux/bsg.h . Currently only the bsg driver uses the sg v4 interface. Since struct sg_io_v4 is all explicitly sized integers, I'm guessing it is immune "compat" problems. [I can see no reference to bsg nor struct sg_io_v4 in the current fs/compat_ioctl.c file.] Other additions described in the that document are these new ioctls: - SG_IOSUBMIT ultimately to replace write(sg_fd, ...) - SG_IORECEIVE to replace read(sg_fd, ...) - SG_IOABORT abort SCSI cmd in progress; new functionality - SG_SET_GET_EXTENDED has associated struct sg_extended_info The first three take a pointer to a struct sg_io_hdr (v3 interface) or a struct sg_io_v4 object. Both objects start with a 32 bit integer: 'S' identifies the v3 interface while 'Q' identifies the v4 interface. The SG_SET_GET_EXTENDED ioctl takes a pointer to a struct sg_extended_info object which contains explicitly sized integers so it may also be immune from "compat" problems. The ioctls section (13) of that document referenced above has a table showing how many "sets and gets" are hiding in the SG_SET_GET_EXTENDED ioctl. BTW No change is proposed for this case: ioctl(normal_block_device, SG_IO, &sg_v3_obj) which is handled by block/scsi_ioctl.c This would be a good time for me to address any "compat" concerns in the proposed sg driver update. Doug Gilbert > I hope you can still take these for the coming merge window, unless > new problems come up. > > Arnd > > Arnd Bergmann (26): > compat_ioctl: pppoe: fix PPPOEIOCSFWD handling > compat_ioctl: move simple ppp command handling into driver > compat_ioctl: avoid unused function warning for do_ioctl > compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.c > compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c > compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t > compat_ioctl: move rtc handling into rtc-dev.c > compat_ioctl: add compat_ptr_ioctl() > compat_ioctl: move drivers to compat_ptr_ioctl > compat_ioctl: use correct compat_ptr() translation in drivers > ceph: fix compat_ioctl for ceph_dir_operations > compat_ioctl: move more drivers to compat_ptr_ioctl > compat_ioctl: move tape handling into drivers > compat_ioctl: move ATYFB_CLK handling to atyfb driver > compat_ioctl: move isdn/capi ioctl translation into driver > compat_ioctl: move rfcomm handlers into driver > compat_ioctl: move hci_sock handlers into driver > compat_ioctl: remove HCIUART handling > compat_ioctl: remove HIDIO translation > compat_ioctl: remove translation for sound ioctls > compat_ioctl: remove IGNORE_IOCTL() > compat_ioctl: remove /dev/random commands > compat_ioctl: remove joystick ioctl translation > compat_ioctl: remove PCI ioctl translation > compat_ioctl: remove /dev/raw ioctl translation > compat_ioctl: remove last RAID handling code > > Documentation/networking/ppp_generic.txt | 2 + > arch/um/drivers/hostaudio_kern.c | 1 + > drivers/android/binder.c | 2 +- > drivers/char/ppdev.c | 12 +- > drivers/char/random.c | 1 + > drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- > drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +- > drivers/dma-buf/dma-buf.c | 4 +- > drivers/dma-buf/sw_sync.c | 2 +- > drivers/dma-buf/sync_file.c | 2 +- > drivers/firewire/core-cdev.c | 12 +- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- > drivers/hid/hidraw.c | 4 +- > drivers/hid/usbhid/hiddev.c | 11 +- > drivers/hwtracing/stm/core.c | 12 +- > drivers/ide/ide-tape.c | 31 +- > drivers/iio/industrialio-core.c | 2 +- > drivers/infiniband/core/uverbs_main.c | 4 +- > drivers/isdn/capi/capi.c | 31 + > drivers/isdn/i4l/isdn_ppp.c | 14 +- > drivers/media/rc/lirc_dev.c | 4 +- > drivers/mfd/cros_ec_dev.c | 4 +- > drivers/misc/cxl/flash.c | 8 +- > drivers/misc/genwqe/card_dev.c | 23 +- > drivers/misc/mei/main.c | 22 +- > drivers/misc/vmw_vmci/vmci_host.c | 2 +- > drivers/mtd/ubi/cdev.c | 36 +- > drivers/net/ppp/ppp_generic.c | 99 +++- > drivers/net/ppp/pppoe.c | 7 + > drivers/net/ppp/pptp.c | 3 + > drivers/net/tap.c | 12 +- > drivers/nvdimm/bus.c | 4 +- > drivers/nvme/host/core.c | 2 +- > drivers/pci/switch/switchtec.c | 2 +- > drivers/platform/x86/wmi.c | 2 +- > drivers/rpmsg/rpmsg_char.c | 4 +- > drivers/rtc/dev.c | 13 +- > drivers/rtc/rtc-vr41xx.c | 10 + > drivers/s390/char/tape_char.c | 41 +- > drivers/sbus/char/display7seg.c | 2 +- > drivers/sbus/char/envctrl.c | 4 +- > drivers/scsi/3w-xxxx.c | 4 +- > drivers/scsi/cxlflash/main.c | 2 +- > drivers/scsi/esas2r/esas2r_main.c | 2 +- > drivers/scsi/megaraid/megaraid_mm.c | 28 +- > drivers/scsi/osst.c | 34 +- > drivers/scsi/pmcraid.c | 4 +- > drivers/scsi/st.c | 35 +- > drivers/staging/android/ion/ion.c | 4 +- > drivers/staging/pi433/pi433_if.c | 12 +- > drivers/staging/vme/devices/vme_user.c | 2 +- > drivers/tee/tee_core.c | 2 +- > drivers/usb/class/cdc-wdm.c | 2 +- > drivers/usb/class/usbtmc.c | 4 +- > drivers/usb/core/devio.c | 16 +- > drivers/usb/gadget/function/f_fs.c | 12 +- > drivers/vfio/vfio.c | 39 +- > drivers/vhost/net.c | 12 +- > drivers/vhost/scsi.c | 12 +- > drivers/vhost/test.c | 12 +- > drivers/vhost/vsock.c | 12 +- > drivers/video/fbdev/aty/atyfb_base.c | 12 +- > drivers/virt/fsl_hypervisor.c | 2 +- > fs/btrfs/super.c | 2 +- > fs/ceph/dir.c | 1 + > fs/ceph/file.c | 2 +- > fs/compat_ioctl.c | 602 +------------------- > fs/fat/file.c | 13 +- > fs/fuse/dev.c | 2 +- > fs/notify/fanotify/fanotify_user.c | 2 +- > fs/userfaultfd.c | 2 +- > include/linux/fs.h | 7 + > include/linux/if_pppox.h | 2 + > include/linux/mtio.h | 58 ++ > include/uapi/linux/ppp-ioctl.h | 2 + > include/uapi/linux/ppp_defs.h | 14 + > net/bluetooth/hci_sock.c | 21 +- > net/bluetooth/rfcomm/sock.c | 14 +- > net/l2tp/l2tp_ppp.c | 3 + > net/rfkill/core.c | 2 +- > sound/core/oss/pcm_oss.c | 4 + > sound/oss/dmasound/dmasound_core.c | 2 + > 82 files changed, 452 insertions(+), 1034 deletions(-) > create mode 100644 include/linux/mtio.h >
Hi Al, It took me way longer than I had hoped to revisit this series, see https://lore.kernel.org/lkml/20180912150142.157913-1-arnd@arndb.de/ for the previously posted version. I've come to the point where all conversion handlers and most COMPATIBLE_IOCTL() entries are gone from this file, but for now, this series only has the parts that have either been reviewed previously, or that are simple enough to include. The main missing piece is the SG_IO/SG_GET_REQUEST_TABLE conversion. I'll post the patches I made for that later, as they need more testing and review from the scsi maintainers. I hope you can still take these for the coming merge window, unless new problems come up. Arnd Arnd Bergmann (26): compat_ioctl: pppoe: fix PPPOEIOCSFWD handling compat_ioctl: move simple ppp command handling into driver compat_ioctl: avoid unused function warning for do_ioctl compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.c compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t compat_ioctl: move rtc handling into rtc-dev.c compat_ioctl: add compat_ptr_ioctl() compat_ioctl: move drivers to compat_ptr_ioctl compat_ioctl: use correct compat_ptr() translation in drivers ceph: fix compat_ioctl for ceph_dir_operations compat_ioctl: move more drivers to compat_ptr_ioctl compat_ioctl: move tape handling into drivers compat_ioctl: move ATYFB_CLK handling to atyfb driver compat_ioctl: move isdn/capi ioctl translation into driver compat_ioctl: move rfcomm handlers into driver compat_ioctl: move hci_sock handlers into driver compat_ioctl: remove HCIUART handling compat_ioctl: remove HIDIO translation compat_ioctl: remove translation for sound ioctls compat_ioctl: remove IGNORE_IOCTL() compat_ioctl: remove /dev/random commands compat_ioctl: remove joystick ioctl translation compat_ioctl: remove PCI ioctl translation compat_ioctl: remove /dev/raw ioctl translation compat_ioctl: remove last RAID handling code Documentation/networking/ppp_generic.txt | 2 + arch/um/drivers/hostaudio_kern.c | 1 + drivers/android/binder.c | 2 +- drivers/char/ppdev.c | 12 +- drivers/char/random.c | 1 + drivers/char/tpm/tpm_vtpm_proxy.c | 12 +- drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +- drivers/dma-buf/dma-buf.c | 4 +- drivers/dma-buf/sw_sync.c | 2 +- drivers/dma-buf/sync_file.c | 2 +- drivers/firewire/core-cdev.c | 12 +- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- drivers/hid/hidraw.c | 4 +- drivers/hid/usbhid/hiddev.c | 11 +- drivers/hwtracing/stm/core.c | 12 +- drivers/ide/ide-tape.c | 31 +- drivers/iio/industrialio-core.c | 2 +- drivers/infiniband/core/uverbs_main.c | 4 +- drivers/isdn/capi/capi.c | 31 + drivers/isdn/i4l/isdn_ppp.c | 14 +- drivers/media/rc/lirc_dev.c | 4 +- drivers/mfd/cros_ec_dev.c | 4 +- drivers/misc/cxl/flash.c | 8 +- drivers/misc/genwqe/card_dev.c | 23 +- drivers/misc/mei/main.c | 22 +- drivers/misc/vmw_vmci/vmci_host.c | 2 +- drivers/mtd/ubi/cdev.c | 36 +- drivers/net/ppp/ppp_generic.c | 99 +++- drivers/net/ppp/pppoe.c | 7 + drivers/net/ppp/pptp.c | 3 + drivers/net/tap.c | 12 +- drivers/nvdimm/bus.c | 4 +- drivers/nvme/host/core.c | 2 +- drivers/pci/switch/switchtec.c | 2 +- drivers/platform/x86/wmi.c | 2 +- drivers/rpmsg/rpmsg_char.c | 4 +- drivers/rtc/dev.c | 13 +- drivers/rtc/rtc-vr41xx.c | 10 + drivers/s390/char/tape_char.c | 41 +- drivers/sbus/char/display7seg.c | 2 +- drivers/sbus/char/envctrl.c | 4 +- drivers/scsi/3w-xxxx.c | 4 +- drivers/scsi/cxlflash/main.c | 2 +- drivers/scsi/esas2r/esas2r_main.c | 2 +- drivers/scsi/megaraid/megaraid_mm.c | 28 +- drivers/scsi/osst.c | 34 +- drivers/scsi/pmcraid.c | 4 +- drivers/scsi/st.c | 35 +- drivers/staging/android/ion/ion.c | 4 +- drivers/staging/pi433/pi433_if.c | 12 +- drivers/staging/vme/devices/vme_user.c | 2 +- drivers/tee/tee_core.c | 2 +- drivers/usb/class/cdc-wdm.c | 2 +- drivers/usb/class/usbtmc.c | 4 +- drivers/usb/core/devio.c | 16 +- drivers/usb/gadget/function/f_fs.c | 12 +- drivers/vfio/vfio.c | 39 +- drivers/vhost/net.c | 12 +- drivers/vhost/scsi.c | 12 +- drivers/vhost/test.c | 12 +- drivers/vhost/vsock.c | 12 +- drivers/video/fbdev/aty/atyfb_base.c | 12 +- drivers/virt/fsl_hypervisor.c | 2 +- fs/btrfs/super.c | 2 +- fs/ceph/dir.c | 1 + fs/ceph/file.c | 2 +- fs/compat_ioctl.c | 602 +------------------- fs/fat/file.c | 13 +- fs/fuse/dev.c | 2 +- fs/notify/fanotify/fanotify_user.c | 2 +- fs/userfaultfd.c | 2 +- include/linux/fs.h | 7 + include/linux/if_pppox.h | 2 + include/linux/mtio.h | 58 ++ include/uapi/linux/ppp-ioctl.h | 2 + include/uapi/linux/ppp_defs.h | 14 + net/bluetooth/hci_sock.c | 21 +- net/bluetooth/rfcomm/sock.c | 14 +- net/l2tp/l2tp_ppp.c | 3 + net/rfkill/core.c | 2 +- sound/core/oss/pcm_oss.c | 4 + sound/oss/dmasound/dmasound_core.c | 2 + 82 files changed, 452 insertions(+), 1034 deletions(-) create mode 100644 include/linux/mtio.h