| Message ID | 20200924094628.1085000-1-vincent.huang@tw.synaptics.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for F3A | expand |
Hi, On 9/24/20 11:46 AM, Vincent Huang wrote: > RMI4 F3A supports the touchpad GPIO function, it's designed to support > more GPIOs and used on newer touchpads. The patches add support of > touchpad buttons and rename f30_data to avoid confusion. Thank you for the patch. So as already mentioned patches 1 and 2 need to be combined into a single patch. Otherwise the patches look good to me and I can confirm that they fix clickpad clicks not registering when using rmi4 for the touchpad on the Lenovo T14 gen 1. So for version 2 (with patches 1 and 2 combined into a single patch) you may add my: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Tested-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > Vincent Huang (3): > Input: synaptics-rmi4 - rename f30_data to gpio_data > HID: rmi - rename f30_data to gpio_data > Input: synaptics-rmi4 - add support for F3A > > drivers/hid/hid-rmi.c | 2 +- > drivers/input/mouse/synaptics.c | 2 +- > drivers/input/rmi4/Kconfig | 8 ++ > drivers/input/rmi4/Makefile | 1 + > drivers/input/rmi4/rmi_bus.c | 3 + > drivers/input/rmi4/rmi_driver.h | 1 + > drivers/input/rmi4/rmi_f30.c | 14 +- > drivers/input/rmi4/rmi_f3a.c | 241 ++++++++++++++++++++++++++++++++ > include/linux/rmi.h | 11 +- > 9 files changed, 269 insertions(+), 14 deletions(-) > create mode 100644 drivers/input/rmi4/rmi_f3a.c >
On Sun, 27 Sep 2020, Hans de Goede wrote: > Otherwise the patches look good to me and I can confirm that > they fix clickpad clicks not registering when using rmi4 for the touchpad > on the Lenovo T14 gen 1. > > So for version 2 (with patches 1 and 2 combined into a single patch) > you may add my: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Tested-by: Hans de Goede <hdegoede@redhat.com> For the folded version Acked-by: Jiri Kosina <jkosina@suse.cz> I believe this is better merged through Dmitry's tree. Thanks,