From patchwork Fri Dec 11 17:35:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11969253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D30C433FE for ; Fri, 11 Dec 2020 19:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E00062405A for ; Fri, 11 Dec 2020 19:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395307AbgLKRgl (ORCPT ); Fri, 11 Dec 2020 12:36:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394582AbgLKRgf (ORCPT ); Fri, 11 Dec 2020 12:36:35 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405E4C0613CF for ; Fri, 11 Dec 2020 09:35:55 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id v29so7567731pgk.12 for ; Fri, 11 Dec 2020 09:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UC8VDOR6bWYQSMmSbZ73sFRI2d4knlSzKHhJz1r8X5s=; b=iYXRXtIY7Ts57AbagWtK7P0ETy/M0tesF+OC5a1t1C7sZzmBuFX489lEemCKFrG4cj pyZo646JynIR6uIadKBPzDYJ+nHr8BGRBVl5a+dBMaJsANXFfhTKcak7Dv7M7OM1ecj9 5JYvcE3YlWszLn8gLyOBKlXcRzAv4ojOsJdmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UC8VDOR6bWYQSMmSbZ73sFRI2d4knlSzKHhJz1r8X5s=; b=dbA5LM8DYyfItfs2bemjVLudd6Q8GL8MAZaMW7qdPglDIhAvEpEpDbu/D6NmT44IRK +ZdclPmrTE1+nAyl69+G7LMilYgbYq8Jd+b3SxOQ7aLSSsPlZL+NKnlUGhQxMDApfUu+ 2e0EmGfkxhc/Hr7Hw8ayC0cpgwGOU2DwlsXzOiuT7osws5lFitClXgIVu0awbfxr9H0X BNYgbGPJn6Bakib8vhckde0NGG/T36qUERGtnq+ZVAgc5ZDjT+ddz1ma1ceJJGt7S/+q roNwZuDcKzz9Sg7z9/q2auFpAEMtbNrIKLR4l0p87d/6n/uSXwqVKgQHoz+qoQKfnHvS fNdw== X-Gm-Message-State: AOAM533WZGHwEynqQ0DInHYa98nbk+KlpwTRtd0+2yERd71U9hCj53oj rk1PAsOL0YbCivIaMzLbpu1PEg== X-Google-Smtp-Source: ABdhPJwCA17O2+gXshC38oWub2baCqhVIqKgdoN6JLXeoscngGE2G66TMOyaeL8VNZsjuQUZ4mBAFQ== X-Received: by 2002:a63:f501:: with SMTP id w1mr12656744pgh.142.1607708154707; Fri, 11 Dec 2020 09:35:54 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id r185sm11402765pfc.53.2020.12.11.09.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 09:35:54 -0800 (PST) From: Douglas Anderson To: jkosina@suse.cz, benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org, Dmitry Torokhov Cc: hdegoede@redhat.com, swboyd@chromium.org, robh+dt@kernel.org, linux-input@vger.kernel.org, andrea@borgia.bo.it, kai.heng.feng@canonical.com, Douglas Anderson , Anson Huang , Arnd Bergmann , Bjorn Andersson , Catalin Marinas , Coiby Xu , Geert Uytterhoeven , =?utf-8?q?Guido_G=C3=BCnther?= , Jiri Kosina , Li Yang , Masahiro Yamada , Max Krummenacher , Michael Walle , Pavel Balan , Shawn Guo , Will Deacon , Xiaofei Tan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Date: Fri, 11 Dec 2020 09:35:22 -0800 Message-Id: <20201211173526.1516653-1-dianders@chromium.org> X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO. To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there. This series was: - Tested on a device that uses normal i2c-hid. - Tested on a device that has a Goodix i2c-hid device. - Tested on an ACPI device, but an earlier version of the series. I believe the plan is for Benjamin to land the whole series. Will said this about the arm64 defconfig change (and provided his Ack): > ...there are a few things I really care about > in defconfig (e.g. things like page size!), generally speaking we don't > need to Ack everything that changes in there. > > That said, might be worth checking whether arm-soc have any defconfig > changes queued in -next so you don't end up with conflicts. Changes in v7: - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") Changes in v6: - ACPI probe function should have been "static" - Don't export suspend/resume, just export dev_pm_ops from core. - Fixed crash in ACPI module (missing init of "client") - No need for regulator include in the core. - Removed i2c_device_id table from ACPI module. - Suspend/resume are no longer exported from the core. Changes in v5: - Add shutdown_tail op and use it in ACPI. - Added mention of i2c-hid in the yaml itself as per Rob. - Adjusted subject as per Rob. - i2chid_subclass_data => i2chid_ops. - power_up_device => power_up (same with power_down). - subclass => ops. Changes in v4: - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. - Fully rejigger so ACPI and OF are full subclasses. - Totally redid based on the new subclass system. Changes in v3: - Fixed compatible in example. - Removed Benjamin as a maintainer. - Rework to use subclassing. - Updated description. Changes in v2: - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. - Get timings based on the compatible string. - Use a separate compatible string for this new touchscreen. Douglas Anderson (4): HID: i2c-hid: Reorganize so ACPI and OF are separate modules arm64: defconfig: Update config names for i2c-hid rejigger dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core .../bindings/input/goodix,gt7375p.yaml | 65 +++++ arch/arm64/configs/defconfig | 3 +- drivers/hid/Makefile | 2 +- drivers/hid/i2c-hid/Kconfig | 47 +++- drivers/hid/i2c-hid/Makefile | 6 +- drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++ drivers/hid/i2c-hid/i2c-hid-core.c | 254 +++--------------- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++ drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++ drivers/hid/i2c-hid/i2c-hid.h | 22 ++ include/linux/platform_data/i2c-hid.h | 41 --- 11 files changed, 596 insertions(+), 262 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c delete mode 100644 include/linux/platform_data/i2c-hid.h