mbox series

[v3,0/6] add timestamp channel for hid-sensors

Message ID 20210105072203.5701-1-xiang.ye@intel.com (mailing list archive)
Headers show
Series add timestamp channel for hid-sensors | expand

Message

Ye Xiang Jan. 5, 2021, 7:21 a.m. UTC
This patch series add a timestamp channel for hid sensors,
including gravity sensor, gyro sensor, magnetometer sensor,
ambient light sensor, inclinometer sensor, and rotation sensor.

With this patch series, user can get the time when sensor yield
a sample.

---
v3:
  - hid-sensor-magn-3d: fix iio_val buffer len issue.
  - hid-sensor-accel-3d: refine commit message

v2:
  - remove unrelated changes.

Ye Xiang (6):
  iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
  iio: hid-sensor-gyro-3d: Add timestamp channel
  iio: hid-sensor-als: Add timestamp channel
  iio: hid-sensor-magn-3d: Add timestamp channel
  iio: hid-sensor-incl-3d: Add timestamp channel
  iio: hid-sensor-rotation: Add timestamp channel

 drivers/iio/accel/hid-sensor-accel-3d.c       |  6 ++-
 drivers/iio/gyro/hid-sensor-gyro-3d.c         | 40 +++++++++-------
 drivers/iio/light/hid-sensor-als.c            | 39 ++++++++-------
 drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ++++++++++++-------
 drivers/iio/orientation/hid-sensor-incl-3d.c  | 43 ++++++++++-------
 drivers/iio/orientation/hid-sensor-rotation.c | 46 ++++++++++--------
 6 files changed, 134 insertions(+), 88 deletions(-)

Comments

srinivas pandruvada Jan. 5, 2021, 8:53 a.m. UTC | #1
On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote:
> This patch series add a timestamp channel for hid sensors,
> including gravity sensor, gyro sensor, magnetometer sensor,
> ambient light sensor, inclinometer sensor, and rotation sensor.
> 
> With this patch series, user can get the time when sensor yield
> a sample.
> 
I think this series is v1 for upstream not v3.

Thanks,
Srinivas

> ---
> v3:
>   - hid-sensor-magn-3d: fix iio_val buffer len issue.
>   - hid-sensor-accel-3d: refine commit message
> 
> v2:
>   - remove unrelated changes.
> 
> Ye Xiang (6):
>   iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
>   iio: hid-sensor-gyro-3d: Add timestamp channel
>   iio: hid-sensor-als: Add timestamp channel
>   iio: hid-sensor-magn-3d: Add timestamp channel
>   iio: hid-sensor-incl-3d: Add timestamp channel
>   iio: hid-sensor-rotation: Add timestamp channel
> 
>  drivers/iio/accel/hid-sensor-accel-3d.c       |  6 ++-
>  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 40 +++++++++-------
>  drivers/iio/light/hid-sensor-als.c            | 39 ++++++++-------
>  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ++++++++++++-----
> --
>  drivers/iio/orientation/hid-sensor-incl-3d.c  | 43 ++++++++++-------
>  drivers/iio/orientation/hid-sensor-rotation.c | 46 ++++++++++-------
> -
>  6 files changed, 134 insertions(+), 88 deletions(-)
>
Ye Xiang Jan. 5, 2021, 9:26 a.m. UTC | #2
On Tue, Jan 05, 2021 at 12:53:44AM -0800, Srinivas Pandruvada wrote:
> On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote:
> > This patch series add a timestamp channel for hid sensors,
> > including gravity sensor, gyro sensor, magnetometer sensor,
> > ambient light sensor, inclinometer sensor, and rotation sensor.
> > 
> > With this patch series, user can get the time when sensor yield
> > a sample.
> > 
> I think this series is v1 for upstream not v3.
Sorry, it's v1 for upstream. will resent it as v1. v3 is our internal review version.

Thanks
Ye Xiang
> 
> 
> > ---
> > v3:
> >   - hid-sensor-magn-3d: fix iio_val buffer len issue.
> >   - hid-sensor-accel-3d: refine commit message
> > 
> > v2:
> >   - remove unrelated changes.
> > 
> > Ye Xiang (6):
> >   iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
> >   iio: hid-sensor-gyro-3d: Add timestamp channel
> >   iio: hid-sensor-als: Add timestamp channel
> >   iio: hid-sensor-magn-3d: Add timestamp channel
> >   iio: hid-sensor-incl-3d: Add timestamp channel
> >   iio: hid-sensor-rotation: Add timestamp channel
> > 
> >  drivers/iio/accel/hid-sensor-accel-3d.c       |  6 ++-
> >  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 40 +++++++++-------
> >  drivers/iio/light/hid-sensor-als.c            | 39 ++++++++-------
> >  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ++++++++++++-----
> > --
> >  drivers/iio/orientation/hid-sensor-incl-3d.c  | 43 ++++++++++-------
> >  drivers/iio/orientation/hid-sensor-rotation.c | 46 ++++++++++-------
> > -
> >  6 files changed, 134 insertions(+), 88 deletions(-)
> > 
> 
>
Jonathan Cameron Jan. 9, 2021, 7:28 p.m. UTC | #3
On Tue, 5 Jan 2021 17:26:33 +0800
"Ye, Xiang" <xiang.ye@intel.com> wrote:

> On Tue, Jan 05, 2021 at 12:53:44AM -0800, Srinivas Pandruvada wrote:
> > On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote:  
> > > This patch series add a timestamp channel for hid sensors,
> > > including gravity sensor, gyro sensor, magnetometer sensor,
> > > ambient light sensor, inclinometer sensor, and rotation sensor.
> > > 
> > > With this patch series, user can get the time when sensor yield
> > > a sample.
> > >   
> > I think this series is v1 for upstream not v3.  
> Sorry, it's v1 for upstream. will resent it as v1. v3 is our internal review version.
> 
Future notice, if you make a mistake of this particular type - don't resend and
carry on with future version numbers.  Otherwise it gets really confusing
if we get to a public v3 version!   Monotonic version numbers only :)

Not a bit problem though but if that does happen check I don't grab the wrong
version.

Jonathan

> Thanks
> Ye Xiang
> > 
> >   
> > > ---
> > > v3:
> > >   - hid-sensor-magn-3d: fix iio_val buffer len issue.
> > >   - hid-sensor-accel-3d: refine commit message
> > > 
> > > v2:
> > >   - remove unrelated changes.
> > > 
> > > Ye Xiang (6):
> > >   iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
> > >   iio: hid-sensor-gyro-3d: Add timestamp channel
> > >   iio: hid-sensor-als: Add timestamp channel
> > >   iio: hid-sensor-magn-3d: Add timestamp channel
> > >   iio: hid-sensor-incl-3d: Add timestamp channel
> > >   iio: hid-sensor-rotation: Add timestamp channel
> > > 
> > >  drivers/iio/accel/hid-sensor-accel-3d.c       |  6 ++-
> > >  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 40 +++++++++-------
> > >  drivers/iio/light/hid-sensor-als.c            | 39 ++++++++-------
> > >  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ++++++++++++-----
> > > --
> > >  drivers/iio/orientation/hid-sensor-incl-3d.c  | 43 ++++++++++-------
> > >  drivers/iio/orientation/hid-sensor-rotation.c | 46 ++++++++++-------
> > > -
> > >  6 files changed, 134 insertions(+), 88 deletions(-)
> > >   
> > 
> >
Ye Xiang Jan. 10, 2021, 7:11 a.m. UTC | #4
On Sat, Jan 09, 2021 at 07:28:05PM +0000, Jonathan Cameron wrote:
> On Tue, 5 Jan 2021 17:26:33 +0800
> "Ye, Xiang" <xiang.ye@intel.com> wrote:
> 
> > On Tue, Jan 05, 2021 at 12:53:44AM -0800, Srinivas Pandruvada wrote:
> > > On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote:  
> > > > This patch series add a timestamp channel for hid sensors,
> > > > including gravity sensor, gyro sensor, magnetometer sensor,
> > > > ambient light sensor, inclinometer sensor, and rotation sensor.
> > > > 
> > > > With this patch series, user can get the time when sensor yield
> > > > a sample.
> > > >   
> > > I think this series is v1 for upstream not v3.  
> > Sorry, it's v1 for upstream. will resent it as v1. v3 is our internal review version.
> > 
> Future notice, if you make a mistake of this particular type - don't resend and
> carry on with future version numbers.  Otherwise it gets really confusing
> if we get to a public v3 version!   Monotonic version numbers only :)
> 
> Not a bit problem though but if that does happen check I don't grab the wrong
> version.

Got it. you grabed the right version v1 for test. thanks.

Thanks
Ye Xiang

> 
> > > 
> > >   
> > > > ---
> > > > v3:
> > > >   - hid-sensor-magn-3d: fix iio_val buffer len issue.
> > > >   - hid-sensor-accel-3d: refine commit message
> > > > 
> > > > v2:
> > > >   - remove unrelated changes.
> > > > 
> > > > Ye Xiang (6):
> > > >   iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
> > > >   iio: hid-sensor-gyro-3d: Add timestamp channel
> > > >   iio: hid-sensor-als: Add timestamp channel
> > > >   iio: hid-sensor-magn-3d: Add timestamp channel
> > > >   iio: hid-sensor-incl-3d: Add timestamp channel
> > > >   iio: hid-sensor-rotation: Add timestamp channel
> > > > 
> > > >  drivers/iio/accel/hid-sensor-accel-3d.c       |  6 ++-
> > > >  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 40 +++++++++-------
> > > >  drivers/iio/light/hid-sensor-als.c            | 39 ++++++++-------
> > > >  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ++++++++++++-----
> > > > --
> > > >  drivers/iio/orientation/hid-sensor-incl-3d.c  | 43 ++++++++++-------
> > > >  drivers/iio/orientation/hid-sensor-rotation.c | 46 ++++++++++-------
> > > > -
> > > >  6 files changed, 134 insertions(+), 88 deletions(-)
> > > >   
> > > 
> > >   
>