From patchwork Wed May 19 08:59:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Link Mauve X-Patchwork-Id: 12266679 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCF1C433ED for ; Wed, 19 May 2021 08:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABCB1610E9 for ; Wed, 19 May 2021 08:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344086AbhESJBC (ORCPT ); Wed, 19 May 2021 05:01:02 -0400 Received: from 82-65-109-163.subs.proxad.net ([82.65.109.163]:41090 "EHLO luna.linkmauve.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241640AbhESJBB (ORCPT ); Wed, 19 May 2021 05:01:01 -0400 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 3F92FF40644; Wed, 19 May 2021 10:59:36 +0200 (CEST) From: Emmanuel Gil Peyrot To: linux-input@vger.kernel.org Cc: Emmanuel Gil Peyrot , Ash Logan , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , =?utf-8?q?Barnab?= =?utf-8?q?=C3=A1s_P=C5=91cze?= , Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org Subject: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad Date: Wed, 19 May 2021 10:59:20 +0200 Message-Id: <20210519085924.1636-1-linkmauve@linkmauve.fr> X-Mailer: git-send-email 2.31.1 In-Reply-To: 20210511201604.23204-1-linkmauve@linkmauve.fr References: <20210502232836.26134-1-linkmauve@linkmauve.fr> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This driver is for the DRC (wireless gamepad) when plugged to the DRH of the Wii U, a chip exposing it as a USB device. I tried to use this driver on master over usbip on my laptop, but usbip disconnects the device right after the driver created the /dev/input/event* files, so instead I have only tested this driver on the 4.19 branch of the linux-wiiu[1] downstream. Other than that, pretty much all of the HID parts of the gamepad work, it’s only missing microphone, camera and NFC input now but those are mostly standard (read require quirks) and pertain to other subsystems, so I felt like this can be upstreamed already. [1] https://gitlab.com/linux-wiiu/linux-wiiu Changes since v1: - Rename interfaces to be less redundant. - Add comments for potentially unclear things. - Reword some commits to include more needed information. - Include all needed includes. - Use helpful helper functions instead of (badly) reimplementing them myself. - Always return the correct type for each function, to avoid some bool/int confusion, or returning 0 to mean error. - Use myself as the module author, even though Ash did most of the initial work, I’m the one who will be maintaining this module from now on. - Use input_set_capability() instead of set_bit(…, keybit) to also set BIT(EV_KEY) on evbit[0]. - Call hid_hw_start() before input_register_device() but after the setup functions, so that hid_hw_open() is never called before it. - Add missing spin_lock_init() for the battery lock. - Use a static atomic for the drc_num, and remove the comment about using the interface number. - Interpret battery report as the voltage coming from an ADC, instead of the completely wrong ENERGY_NOW it was before. So basically addressing Jonathan’s and Barnabás’ comments. :) Changes since v2: - Guard against the possibility of CONFIG_HID_BATTERY_STRENGTH not having been selected. - Include forgotten linux/fixp-arith.h header. - Fix a warning in clamp() due to comparing a s16 with a #define. Ash Logan (1): HID: wiiu-drc: Add a driver for this gamepad Emmanuel Gil Peyrot (3): HID: wiiu-drc: Implement touch reports HID: wiiu-drc: Add accelerometer, gyroscope and magnetometer readings HID: wiiu-drc: Add battery reporting drivers/hid/Kconfig | 7 + drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 3 + drivers/hid/hid-wiiu-drc.c | 564 +++++++++++++++++++++++++++++++++++++ 5 files changed, 576 insertions(+) create mode 100644 drivers/hid/hid-wiiu-drc.c