| Message ID | 20211019110418.26874-1-linkmauve@linkmauve.fr (mailing list archive) |
|---|---|
| Headers | show |
| Series | HID: nintendo: Add support for the Wii U gamepad | expand |
On Tue, 19 Oct 2021, Emmanuel Gil Peyrot wrote: > This driver is for the DRC (wireless gamepad) when plugged to the DRH of > the Wii U, a chip exposing it as a USB device. > > I tried to use this driver on master over usbip on my laptop, but usbip > disconnects the device right after the driver created the > /dev/input/event* files, so instead I have only tested this driver on > the 4.19 branch of the linux-wiiu[1] downstream. > > Other than that, pretty much all of the HID parts of the gamepad work, > it’s only missing microphone, camera and NFC input now but those are > mostly standard (read require quirks) and pertain to other subsystems, > so I felt like this can be upstreamed already. Now that proper hid.git#for-5.16/nintendo branch exists, could you please fix up the issues reported by the kernel build bot and resubmit? Thanks,
This driver is for the DRC (wireless gamepad) when plugged to the DRH of the Wii U, a chip exposing it as a USB device. I tried to use this driver on master over usbip on my laptop, but usbip disconnects the device right after the driver created the /dev/input/event* files, so instead I have only tested this driver on the 4.19 branch of the linux-wiiu[1] downstream. Other than that, pretty much all of the HID parts of the gamepad work, it’s only missing microphone, camera and NFC input now but those are mostly standard (read require quirks) and pertain to other subsystems, so I felt like this can be upstreamed already. [1] https://gitlab.com/linux-wiiu/linux-wiiu Changes since v1: - Rename interfaces to be less redundant. - Add comments for potentially unclear things. - Reword some commits to include more needed information. - Include all needed includes. - Use helpful helper functions instead of (badly) reimplementing them myself. - Always return the correct type for each function, to avoid some bool/int confusion, or returning 0 to mean error. - Use myself as the module author, even though Ash did most of the initial work, I’m the one who will be maintaining this module from now on. - Use input_set_capability() instead of set_bit(…, keybit) to also set BIT(EV_KEY) on evbit[0]. - Call hid_hw_start() before input_register_device() but after the setup functions, so that hid_hw_open() is never called before it. - Add missing spin_lock_init() for the battery lock. - Use a static atomic for the drc_num, and remove the comment about using the interface number. - Interpret battery report as the voltage coming from an ADC, instead of the completely wrong ENERGY_NOW it was before. So basically addressing Jonathan’s and Barnabás’ comments. :) Changes since v2: - Guard against the possibility of CONFIG_HID_BATTERY_STRENGTH not having been selected. - Include forgotten linux/fixp-arith.h header. - Fix a warning in clamp() due to comparing a s16 with a #define. Changes since v3: - Rebased on top of hid.git#for-5.16/nintendo. - Merged into hid-nintendo. - Make hid-nintendo mostly a stub, with sub-drivers implementing the actual controllers. - Introduced CONFIG_HID_NINTENDO_WIIU to enable support for this device now. Ash Logan (1): HID: nintendo: drc: add support for the Wii U gamepad Emmanuel Gil Peyrot (4): HID: nintendo: split switch support into its own file HID: nintendo: drc: implement touch reports HID: nintendo: drc: add accelerometer, gyroscope and magnetometer readings HID: nintendo: drc: add battery reporting drivers/hid/Kconfig | 31 +- drivers/hid/Makefile | 2 + drivers/hid/hid-ids.h | 1 + .../{hid-nintendo.c => hid-nintendo-switch.c} | 43 +- drivers/hid/hid-nintendo-wiiu.c | 550 ++++ drivers/hid/hid-nintendo.c | 2300 +---------------- drivers/hid/hid-nintendo.h | 22 + drivers/hid/hid-quirks.c | 3 + 8 files changed, 645 insertions(+), 2307 deletions(-) copy drivers/hid/{hid-nintendo.c => hid-nintendo-switch.c} (98%) create mode 100644 drivers/hid/hid-nintendo-wiiu.c create mode 100644 drivers/hid/hid-nintendo.h