mbox series

[v3,0/2] Input: mt6779-keypad - fix hw code logic and row/col selection

Message ID 20220617081902.2931099-1-mkorpershoek@baylibre.com (mailing list archive)
Headers show
Series Input: mt6779-keypad - fix hw code logic and row/col selection | expand

Message

Mattijs Korpershoek June 17, 2022, 8:19 a.m. UTC 
This serie is the first follow-up on the mt6779-keypad in
order to enable it on the MediaTek mt8183-pumpkin board.

To fully enable it on mt8183-pumpkin, we still need:
* double key support
* dts changes

To ease up reviewing, I preferred sending this first.

The first patch fixes the row/column logic to match the underlying
hardware matrix.
The second patch configures the keypad correctly in order to not
report bogus values.

Thank you,
Mattijs

Changes in v3:
* reworked row/column logic as discussed in [1] 
* Dropped Angelo's review since patch 1 changed

Changes in v2:
* Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry
* Added Angelo's Reviewed-by on patch 1

Mattijs Korpershoek (2):
  Input: mt6779-keypad - match hardware matrix organization
  Input: mt6779-keypad - implement row/column selection

 drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

[1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com

base-commit: 69cf890d8b283c8d3a77d28dbd3024f58ae236a9