From patchwork Fri Jun 17 08:19:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mattijs Korpershoek X-Patchwork-Id: 12885256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D823AC433EF for ; Fri, 17 Jun 2022 08:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379702AbiFQITL (ORCPT ); Fri, 17 Jun 2022 04:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234805AbiFQITK (ORCPT ); Fri, 17 Jun 2022 04:19:10 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CD2868328 for ; Fri, 17 Jun 2022 01:19:08 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id m16-20020a7bca50000000b0039c8a224c95so2000793wml.2 for ; Fri, 17 Jun 2022 01:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+zfxAXUXstiy9HFbkcUgRLR8H01OXibXa/AaMrxxFvw=; b=0/lpT5HykZNP39UyQqCjq47YFnbNhY6JYeUpCQof3XsUCTKrQxaR6kA28RIQxTsbd6 1LEw0QDrN9P2uFjEA4gyoQ7AYXPWDm88DQ0XGhQzPDkWiZP5GoHzZaZ9lxAkY/imqrZr OxKFwb9rRWc2WMYOqSmapsicbLo5l+Ja0iMnyEsotqYS/ssTeCAl2EQeq9PuZhBGQ0f4 SCrQSvV7U5fEf17jmRCIvxNuAxCpvn28FEJhgz3Qw4bsLodKjeeow04oKVRWlrHSrmRE 4JvJEcYARhLkW9ETjyCako/k/bFGcivdLZH212LSaMl/R4vpsEF86YDRiinIbLXTzctp ntZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+zfxAXUXstiy9HFbkcUgRLR8H01OXibXa/AaMrxxFvw=; b=7bNnDHmv8mjTB6YsybqLlvdlO2tkyjZDGJweE1vOIfMVQgckZY+JyieG5Fk028KjTO Tx78T5O/xO9wDnypZmgqWLfqDDRSZ7MJ+3vn1aQSSM6nA3hczD0Vz1YGA5I/ip2PcGG5 Ewv0M0+NHYRRCn6oLkifo8RFlqE0VvJITyIcgbfJyYRK3GdX6FLGD5La9tHvBcw0Cr50 C8rlpBj8y7HEfkDNh38IW8r+B2AF9F4gGdvpzdb/ZTrLtCBEhCU4zdepZTtcN/R/GXIi CqXWH6S8+Rh4vzheKr279UtoQkv5HDNRTphWzxAD0uRaGQoplGB5m5oYor+cGuawMBs8 o4ng== X-Gm-Message-State: AJIora+i2EOjh8nO+e5OOtpQ3TWXRmmb3KHl1a/JEe8BBYFFtuUG+f6q PSySz5uJ4tdk4LHpzX5B6yBzk6v1agtYOg== X-Google-Smtp-Source: AGRyM1uA1po67esnYEyNcEdUlzYn0dRDp8zP7JR6MJK74I8T9W1lnpShELLVdMBsJIPq0QGFqWNaXg== X-Received: by 2002:a7b:ce87:0:b0:39c:5509:660c with SMTP id q7-20020a7bce87000000b0039c5509660cmr8961277wmj.163.1655453947001; Fri, 17 Jun 2022 01:19:07 -0700 (PDT) Received: from groot.. ([2a01:cb19:85e6:1900:b8a0:45dd:a367:2e65]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c4f0900b0039db500714fsm4970245wmq.6.2022.06.17.01.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 01:19:06 -0700 (PDT) From: Mattijs Korpershoek To: Dmitry Torokhov Cc: Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Fabien Parent , linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek Subject: [PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic and row/col selection Date: Fri, 17 Jun 2022 10:19:00 +0200 Message-Id: <20220617081902.2931099-1-mkorpershoek@baylibre.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This serie is the first follow-up on the mt6779-keypad in order to enable it on the MediaTek mt8183-pumpkin board. To fully enable it on mt8183-pumpkin, we still need: * double key support * dts changes To ease up reviewing, I preferred sending this first. The first patch fixes the row/column logic to match the underlying hardware matrix. The second patch configures the keypad correctly in order to not report bogus values. Thank you, Mattijs Changes in v3: * reworked row/column logic as discussed in [1] * Dropped Angelo's review since patch 1 changed Changes in v2: * Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry * Added Angelo's Reviewed-by on patch 1 Mattijs Korpershoek (2): Input: mt6779-keypad - match hardware matrix organization Input: mt6779-keypad - implement row/column selection drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) [1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com base-commit: 69cf890d8b283c8d3a77d28dbd3024f58ae236a9