From patchwork Wed Oct 26 11:49:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 13020503 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD3BC38A2D for ; Wed, 26 Oct 2022 11:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbiJZLta (ORCPT ); Wed, 26 Oct 2022 07:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbiJZLt3 (ORCPT ); Wed, 26 Oct 2022 07:49:29 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CA8764B; Wed, 26 Oct 2022 04:49:27 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8A17A32003CE; Wed, 26 Oct 2022 07:49:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 26 Oct 2022 07:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alistair23.me; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm3; t=1666784965; x=1666871365; bh=Fs O0gPfX2wHmErfPj9SmHjSOURVfbrKHD0GjwO7ZwVk=; b=wguQpGpJB+dw8/sOY7 LLeySXpRG3RP0n5L14JU/FaYJiN3r0kUN6jw2eGYikDd93TOsJVIkoVXFEOtVE5Z uDMU4CJoBph8oPHuYLXSGFaKgDEXMq5cHExDcvYEs7WEtqE/UT+RBLqvQ7VAZ+3v CCYevACGdoWityOQsXB9PiuO31Dv7fbrBX521juoWjTrF4lQrjxbVxqcPadVthuR eeosC508IAqq5g7ocvRmy9QFYcYpateK9DaXAuyYHT4GPSw89aa/a/hP8kRmwFq4 zgbkr9K3dS7JpaTePv+ne1o9CiLR5mlVqnQ1Iij1cTjcPKpz1JLjpUUyDVCA+D1F u3Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1666784965; x=1666871365; bh=FsO0gPfX2wHmE rfPj9SmHjSOURVfbrKHD0GjwO7ZwVk=; b=kKXNGot4HwX9HZLQpWN2eO25Rn4Aw 8KMBK7puUOgt9RAl95V/dAzpuw4x1bYOMogRuSZPrVO7+/NB1ShRblVme+Pow0Jr b6JGyva8vSaIbqyT0gGDsj9+msQvV6+kFH5tF3CJ+vz7NVTDUkA7dkqxOLhVHY5Q saQ4DnOlrEPijwKiWMZHgFov5Pg+vVCWpBtPc6ckZanUZXjUOesG5CsUVN6k30eA 6RXQNPbUO1QHC+JQHccazuZMKvHySq1fCZPwZHPigDkL1uj8WQutwb7oesHU+LlA 2nQ1UG9mCHLuHIqon1rtL8UWGGUXRZupYN3y6tdbQPatz/+HCzsBPt2/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtddvgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpeetlhhishhtrghirhcuhfhrrghntghishcuoegrlhhishhtrghi rhesrghlihhsthgrihhrvdefrdhmvgeqnecuggftrfgrthhtvghrnhepgedtvdfffeffje ekgefggeetfffftdeuveekfedvjeevtedvueduvddvtdeigfelnecuffhomhgrihhnpehl fihnrdhnvghtpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegrlhhishhtrghirhesrghlihhsthgrihhrvdefrdhm vg X-ME-Proxy: Feedback-ID: ifd214418:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Oct 2022 07:49:15 -0400 (EDT) From: Alistair Francis To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, shawnguo@kernel.org, rydberg@bitmath.org, alistair23@gmail.com, s.hauer@pengutronix.de, andreas@kemnade.info, Alistair Francis Subject: [PATCH v10 0/4] Add support for the Cypress cyttsp5 Date: Wed, 26 Oct 2022 21:49:04 +1000 Message-Id: <20221026114908.191472-1-alistair@alistair23.me> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This patch series builds on top of [1] and adds support for the cyttsp5 touchscreen controller for the reMarkable 2. I first tried to add an I2C HID device. Although the cyttsp5 has some HID looking aspects it is not HID compatible. Just in trying to probe the device I found: - The HID descriptor has extra padding - The HID descriptor sets the high bytes of the descriptor length - The HID descriptor has extra unrecognised tags - The HID reset command doesn't appear to work I don't think there is a way to use the I2C HID framework with the cyttsp5. For anyone interested you can see the work here [2]. In that branch though I can only obtain a HID descriptor, nothing else works without more core changes. So instead I rebased the series from [1]. Converted to the new yaml DTS documentation, added regulator support and fixed a x/y miscalculation bug. 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid v10: - Fix device tree binding errors - Add commit message about defcofig cahnges v9: - Fixup kernel robot failures v8: - Rebase and resend v7: - Fix device tree warnings v6: - Use reg for the button properties v5: - Address review comments from v4 Alistair Francis (4): Input: Add driver for Cypress Generation 5 touchscreen dt-bindings: input: Add Cypress TT21000 touchscreen controller ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen ARM: dts: imx7d-remarkable2: Enable the cyttsp5 .../input/touchscreen/cypress,tt21000.yaml | 106 ++ arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ arch/arm/configs/imx_v6_v7_defconfig | 1 + drivers/input/touchscreen/Kconfig | 16 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ 6 files changed, 1126 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml create mode 100644 drivers/input/touchscreen/cyttsp5.c