From patchwork Fri Jan 6 01:59:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roderick Colenbrander X-Patchwork-Id: 13090782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F809C3DA7A for ; Fri, 6 Jan 2023 01:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjAFB7X (ORCPT ); Thu, 5 Jan 2023 20:59:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjAFB7W (ORCPT ); Thu, 5 Jan 2023 20:59:22 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2542D59F83 for ; Thu, 5 Jan 2023 17:59:21 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id j8-20020a17090a3e0800b00225fdd5007fso324566pjc.2 for ; Thu, 05 Jan 2023 17:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaikai-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0qusvn5B77dSVH/bR1o93bu2pfXKHjaiYxUqfS6HYgE=; b=PSnw6rz9m0VOBxWYqKIlL23lUb7yIeR6UPlnPKpogL5z3xJBTKkHXQxkgJnc1scQEQ c84A9zgFv1qCOUeVmp2KuYqEAYiD8soVOQZJR8cXbHuW+q1fV9ZoZh9myT1CXyhgA2Ei oaBmxm40jVIN+85Oxr8M0AVS2QL8LLA4hniC7n4m4D4kqlbzOp4NNBIEYXnL1ZSaCYUV jxdu5kmiH0NxmE51xjL8BK1WoEJu1iLLHgb/vCgcn2KbsxBHsiVKmJNov7jeqFw2HJZf /+OG38iJ9DQ923A/8NBHSgbCsewgi2xuHldIOtmf53LjKzlwCwQgpsX68emllEnjfneb 1pTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0qusvn5B77dSVH/bR1o93bu2pfXKHjaiYxUqfS6HYgE=; b=hWQWVIyA5qrbUgyDuFmv8ysCFVIr+sSAEpq9m8XrxhnyBQX/TXXc0aXWbwxoyjDEc/ 9bcKNLeVDiQsxHjvpkfAdsyda3VqoMrEckPAPTQRhq88RFcWYdUT7DT/Gj/AM0v3R0ge TCd00Wf7QmSqP51qE9S7WhUFzY8wrahQ8sWd4AsaxVxcSVCW/ugKDJyln6Vkc8mJGapA 6fCepAB1p0WZnP4s6DC8rxFW0437mn0t6FPMBqF1ZAMggPRS5nPpvYFIJnffJC7Tsm+l v/NePGLqNf3okJFAoKwlaVicvPQ5rbjQAhHp56ZONsUcL5IW1ZqJAb9EEcnU3/LKv5lk QEyg== X-Gm-Message-State: AFqh2krwHTD55WS42llbuTu6fwdH5f9mXytn4ZsEvar+tQV6kagvX1ac gNxL2riZaIPm0q4d7w7nPh1TdA== X-Google-Smtp-Source: AMrXdXuBgurj60qw8ZF+st+k0oDDCX8LOkMo+7sT+D5HUAwHqyot6ceAAZ//KTlXnBa2OSh91MJzTQ== X-Received: by 2002:a17:902:bb85:b0:189:8ca1:e641 with SMTP id m5-20020a170902bb8500b001898ca1e641mr57002200pls.60.1672970360664; Thu, 05 Jan 2023 17:59:20 -0800 (PST) Received: from localhost.localdomain (23-122-157-100.lightspeed.irvnca.sbcglobal.net. [23.122.157.100]) by smtp.gmail.com with ESMTPSA id i18-20020a17090332d200b001897a8b537asm26811165plr.221.2023.01.05.17.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 17:59:19 -0800 (PST) From: Roderick Colenbrander X-Google-Original-From: Roderick Colenbrander To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, Roderick Colenbrander Subject: [PATCH 0/5] HID: playstation: various DS4 and DualSense fixes Date: Thu, 5 Jan 2023 17:59:05 -0800 Message-Id: <20230106015910.3031670-1-roderick.colenbrander@sony.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, This patch set contains a number of small fixes and stability improvements. The stability patches are most critical as they prevent kernel crashes. Over the years there have been various buggy devices usually clone devices, but now apparently some official devices with wiped calibration data. It is hard to handle all permutations of devices as some have constants, some have broken constants (e.g. wrong sign of a coefficient). We disable calibration when we see an invalid 0 denominator. The patch adds the same logic to both the DualShock4 and DualSense code. As part of the calibration stability improvements, a thorough review was performed of the calibration code as it was suspected it was potentially incorrect. It was found to be only slightly wrong for the handling of the bias of the gyroscopes. Two patches fix this for both DualShock4 and DualSense. There is only a marginal impact on practical values as the bias values tend to be quite small. Thanks, Roderick Colenbrander Sony Interactive Entertainment, LLC Roderick Colenbrander (5): HID: playstation: fix DualShock4 unreachable calibration code. HID: playstation: sanity check DualShock4 calibration data. HID: playstation: sanity check DualSense calibration data. HID: playstation: correct DualShock4 gyro bias handling. HID: playstation: correct DualSense gyro bias handling. drivers/hid/hid-playstation.c | 104 +++++++++++++++++++++++++++------- 1 file changed, 85 insertions(+), 19 deletions(-)