mbox series

[0/4] HID: explicitly include linux/leds.h

Message ID 20230215-power_supply-leds-hid-v1-0-35b6f1dcee8a@weissschuh.net (mailing list archive)
Headers show
Series HID: explicitly include linux/leds.h | expand

Message

Thomas Weißschuh Feb. 15, 2023, 1:03 a.m. UTC
Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (4):
      HID: steelseries: explicitly include linux/leds.h
      HID: lg-g15: explicitly include linux/leds.h
      HID: asus: explicitly include linux/leds.h
      HID: apple: explicitly include linux/leds.h

 drivers/hid/hid-apple.c       | 1 +
 drivers/hid/hid-asus.c        | 1 +
 drivers/hid/hid-lg-g15.c      | 1 +
 drivers/hid/hid-steelseries.c | 1 +
 4 files changed, 4 insertions(+)
---
base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf

Best regards,

Comments

Thomas Weißschuh March 20, 2023, 10:18 p.m. UTC | #1
Friendly ping,

this seems to have fallen through the cracks.

Thanks,
Thomas

On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (4):
>       HID: steelseries: explicitly include linux/leds.h
>       HID: lg-g15: explicitly include linux/leds.h
>       HID: asus: explicitly include linux/leds.h
>       HID: apple: explicitly include linux/leds.h
> 
>  drivers/hid/hid-apple.c       | 1 +
>  drivers/hid/hid-asus.c        | 1 +
>  drivers/hid/hid-lg-g15.c      | 1 +
>  drivers/hid/hid-steelseries.c | 1 +
>  4 files changed, 4 insertions(+)
> ---
> base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>
Benjamin Tissoires April 13, 2023, 3:04 p.m. UTC | #2
On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
> 
> 

Applied to hid/hid.git (for-6.4/apple), thanks!

[4/4] HID: apple: explicitly include linux/leds.h
      https://git.kernel.org/hid/hid/c/6c89c1160321

Cheers,
Benjamin Tissoires April 13, 2023, 3:10 p.m. UTC | #3
On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
> 
> 

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.4/led-includes), thanks!

[1/4] HID: steelseries: explicitly include linux/leds.h
      https://git.kernel.org/hid/hid/c/f28bb5ce4f15
[2/4] HID: lg-g15: explicitly include linux/leds.h
      https://git.kernel.org/hid/hid/c/21c5bd5b4b06
[3/4] HID: asus: explicitly include linux/leds.h
      https://git.kernel.org/hid/hid/c/a2654c1f640c

Cheers,
Benjamin Tissoires April 13, 2023, 3:11 p.m. UTC | #4
On Mar 20 2023, Thomas Weißschuh wrote:
> Friendly ping,
> 
> this seems to have fallen through the cracks.

Sorry for the delay.

I have applied them now, as should have told you the automatic
notifications.

Cheers,
Benjamin

> 
> Thanks,
> Thomas
> 
> On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> > Instead of relying on an accidental, transitive inclusion of linux/leds.h
> > use it directly.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > Thomas Weißschuh (4):
> >       HID: steelseries: explicitly include linux/leds.h
> >       HID: lg-g15: explicitly include linux/leds.h
> >       HID: asus: explicitly include linux/leds.h
> >       HID: apple: explicitly include linux/leds.h
> > 
> >  drivers/hid/hid-apple.c       | 1 +
> >  drivers/hid/hid-asus.c        | 1 +
> >  drivers/hid/hid-lg-g15.c      | 1 +
> >  drivers/hid/hid-steelseries.c | 1 +
> >  4 files changed, 4 insertions(+)
> > ---
> > base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> > change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
> > 
> > Best regards,
> > -- 
> > Thomas Weißschuh <linux@weissschuh.net>
> >