| Message ID | 20231217200703.719876-1-srinivas.pandruvada@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix regression in ALS | expand |
On Sun, 17 Dec 2023 12:07:01 -0800 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote: > Addition of color temperature and chromaticity support breaks ALS sensor > on several platforms. Till we have a good solution, revert these commits > for 6.7 cycle. > > Srinivas Pandruvada (2): > Revert "iio: hid-sensor-als: Add light chromaticity support" > Revert "iio: hid-sensor-als: Add light color temperature support" > > drivers/iio/light/hid-sensor-als.c | 100 +---------------------------- > include/linux/hid-sensor-ids.h | 4 -- > 2 files changed, 2 insertions(+), 102 deletions(-) +CC Greg KH. Hi Greg, This is a regression fix that I'd like to get in asap. Currently light sensors on a wide range of laptops are broken. I was hoping we'd fix the the problem rather than need to revert, but time is running out so revert it is. I don't have anything else that needs to be rushed in before the merge cycle, so if you are happy to pick these two reverts directly that would be great. Message ID of the cover letter is 20231217200703.719876-1-srinivas.pandruvada@linux.intel.com Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> If not I should be able to do a pull request in next couple of days with these in. Thanks, Jonathan >
On Sun, 17 Dec 2023 12:07:01 -0800 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote: > Addition of color temperature and chromaticity support breaks ALS sensor > on several platforms. Till we have a good solution, revert these commits > for 6.7 cycle. > > Srinivas Pandruvada (2): > Revert "iio: hid-sensor-als: Add light chromaticity support" > Revert "iio: hid-sensor-als: Add light color temperature support" > > drivers/iio/light/hid-sensor-als.c | 100 +---------------------------- > include/linux/hid-sensor-ids.h | 4 -- > 2 files changed, 2 insertions(+), 102 deletions(-) +CC Greg KH. (resent as I messed up Greg's address first time around) Hi Greg, This is a regression fix that I'd like to get in asap. Currently light sensors on a wide range of laptops are broken. I was hoping we'd fix the the problem rather than need to revert, but time is running out so revert it is. I don't have anything else that needs to be rushed in before the merge cycle, so if you are happy to pick these two reverts directly that would be great. Message ID of the cover letter is 20231217200703.719876-1-srinivas.pandruvada@linux.intel.com Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> If not I should be able to do a pull request in next couple of days with these in. Thanks, Jonathan >
On Mon, Dec 18, 2023 at 04:22:27PM +0000, Jonathan Cameron wrote: > On Sun, 17 Dec 2023 12:07:01 -0800 > Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote: > > > Addition of color temperature and chromaticity support breaks ALS sensor > > on several platforms. Till we have a good solution, revert these commits > > for 6.7 cycle. > > > > Srinivas Pandruvada (2): > > Revert "iio: hid-sensor-als: Add light chromaticity support" > > Revert "iio: hid-sensor-als: Add light color temperature support" > > > > drivers/iio/light/hid-sensor-als.c | 100 +---------------------------- > > include/linux/hid-sensor-ids.h | 4 -- > > 2 files changed, 2 insertions(+), 102 deletions(-) > > +CC Greg KH. (resent as I messed up Greg's address first time around) > > Hi Greg, > > This is a regression fix that I'd like to get in asap. Currently light sensors > on a wide range of laptops are broken. I was hoping we'd fix the the problem > rather than need to revert, but time is running out so revert it is. > > I don't have anything else that needs to be rushed in before the merge cycle, > so if you are happy to pick these two reverts directly that would be great. > > Message ID of the cover letter is > > 20231217200703.719876-1-srinivas.pandruvada@linux.intel.com > > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > If not I should be able to do a pull request in next couple of days > with these in. Now queued up, thanks. greg k-h