mbox series

[v7,0/5] initial support for Marvell 88PM886 PMIC

Message ID 20240531175109.15599-1-balejk@matfyz.cz (mailing list archive)
Headers show
Series initial support for Marvell 88PM886 PMIC | expand

Message

Karel Balej May 31, 2024, 5:34 p.m. UTC 
Hello,

the following implements basic support for Marvell's 88PM886 PMIC which
is found for instance as a component of the samsung,coreprimevelte
smartphone which inspired this and also serves as a testing platform.

The code for the MFD is based primarily on this old series [1] with the
addition of poweroff based on the smartphone's downstream kernel tree
[2]. The onkey and regulators drivers are based on the latter. I am not
in possesion of the datasheet.

[1] https://lore.kernel.org/all/1434098601-3498-1-git-send-email-yizhang@marvell.com/
[2] https://github.com/CoderCharmander/g361f-kernel

Thank you, kind regards,
K. B.
---
v7:
- Rebase to v6.10-rc1.
- v6: https://lore.kernel.org/r/20240504194632.2456-1-balejk@matfyz.cz/
v6:
- Rebase to v6.9-rc6.
- Fix patchset versioning: the previous version was marked as v1 because I
  considered RFC to be its own thing. Thank you to Krzysztof for
  explaining that that is not the case. The previous version is thus now
  marked as v5 and this is v6, sorry for any confusion.
- v5: https://lore.kernel.org/r/20240331105608.7338-2-balejk@matfyz.cz/
v5:
- RFC v4: https://lore.kernel.org/r/20240311160110.32185-1-karelb@gimli.ms.mff.cuni.cz/
- Rebase to v6.9-rc1.
- Thank you to everybody for their feedback on the RFC!
RFC v4:
- RFC v3: https://lore.kernel.org/all/20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz/
RFC v3:
- Address Rob's feedback:
  - Drop onkey bindings patch.
- Rename PM88X -> PM886 everywhere.
- RFC v2: https://lore.kernel.org/all/20240211094609.2223-1-karelb@gimli.ms.mff.cuni.cz/
RFC v2:
- Merge with the regulators series to have multiple devices and thus
  justify the use of the MFD framework.
- Rebase on v6.8-rc3.
- Reorder patches.
- MFD RFC v1: https://lore.kernel.org/all/20231217131838.7569-1-karelb@gimli.ms.mff.cuni.cz/
- regulators RFC v1: https://lore.kernel.org/all/20231228100208.2932-1-karelb@gimli.ms.mff.cuni.cz/

Karel Balej (5):
  dt-bindings: mfd: add entry for Marvell 88PM886 PMIC
  mfd: add driver for Marvell 88PM886 PMIC
  regulator: add regulators driver for Marvell 88PM886 PMIC
  input: add onkey driver for Marvell 88PM886 PMIC
  MAINTAINERS: add myself for Marvell 88PM886 PMIC

 .../bindings/mfd/marvell,88pm886-a1.yaml      |  76 ++++
 MAINTAINERS                                   |   9 +
 drivers/input/misc/88pm886-onkey.c            |  98 +++++
 drivers/input/misc/Kconfig                    |   7 +
 drivers/input/misc/Makefile                   |   1 +
 drivers/mfd/88pm886.c                         | 148 +++++++
 drivers/mfd/Kconfig                           |  12 +
 drivers/mfd/Makefile                          |   1 +
 drivers/regulator/88pm886-regulator.c         | 392 ++++++++++++++++++
 drivers/regulator/Kconfig                     |   6 +
 drivers/regulator/Makefile                    |   1 +
 include/linux/mfd/88pm886.h                   |  69 +++
 12 files changed, 820 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml
 create mode 100644 drivers/input/misc/88pm886-onkey.c
 create mode 100644 drivers/mfd/88pm886.c
 create mode 100644 drivers/regulator/88pm886-regulator.c
 create mode 100644 include/linux/mfd/88pm886.h

Comments

Lee Jones June 28, 2024, 2:41 p.m. UTC | #1 
On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote:
> the following implements basic support for Marvell's 88PM886 PMIC which
> is found for instance as a component of the samsung,coreprimevelte
> smartphone which inspired this and also serves as a testing platform.
> 
> The code for the MFD is based primarily on this old series [1] with the
> addition of poweroff based on the smartphone's downstream kernel tree
> [2]. The onkey and regulators drivers are based on the latter. I am not
> in possesion of the datasheet.
> 
> [...]

Applied, thanks!

[1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC
      commit: c4725350a9f76fbec45cbbfffb20be2e574eb6ef
[2/5] mfd: add driver for Marvell 88PM886 PMIC
      commit: 860f8e3beac0b800bbe20f23c5f3440b1c470b8f
[3/5] regulator: add regulators driver for Marvell 88PM886 PMIC
      commit: 5d1a5144396e9570efea02d467df0a68fd28db6f
[4/5] input: add onkey driver for Marvell 88PM886 PMIC
      commit: 914089db309ccc590314b6c21df5a1f812e9ab0b
[5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC
      commit: f53d3efa366b1754f0389944401bb53397d22468

--
Lee Jones [李琼斯]
Lee Jones June 28, 2024, 2:42 p.m. UTC | #2 
On Fri, 28 Jun 2024, Lee Jones wrote:

> On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote:
> > the following implements basic support for Marvell's 88PM886 PMIC which
> > is found for instance as a component of the samsung,coreprimevelte
> > smartphone which inspired this and also serves as a testing platform.
> > 
> > The code for the MFD is based primarily on this old series [1] with the
> > addition of poweroff based on the smartphone's downstream kernel tree
> > [2]. The onkey and regulators drivers are based on the latter. I am not
> > in possesion of the datasheet.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC
>       commit: c4725350a9f76fbec45cbbfffb20be2e574eb6ef
> [2/5] mfd: add driver for Marvell 88PM886 PMIC
>       commit: 860f8e3beac0b800bbe20f23c5f3440b1c470b8f
> [3/5] regulator: add regulators driver for Marvell 88PM886 PMIC
>       commit: 5d1a5144396e9570efea02d467df0a68fd28db6f
> [4/5] input: add onkey driver for Marvell 88PM886 PMIC
>       commit: 914089db309ccc590314b6c21df5a1f812e9ab0b
> [5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC
>       commit: f53d3efa366b1754f0389944401bb53397d22468

Submitted for build testing.

If all is good, I'll send out a PR for the other maintainers soon.

Note to self: ib-mfd-input-regulator-6.11
Karel Balej June 28, 2024, 5:20 p.m. UTC | #3 
Lee Jones, 2024-06-28T15:41:39+01:00:
> On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote:
> > the following implements basic support for Marvell's 88PM886 PMIC which
> > is found for instance as a component of the samsung,coreprimevelte
> > smartphone which inspired this and also serves as a testing platform.
> > 
> > The code for the MFD is based primarily on this old series [1] with the
> > addition of poweroff based on the smartphone's downstream kernel tree
> > [2]. The onkey and regulators drivers are based on the latter. I am not
> > in possesion of the datasheet.
> > 
> > [...]
>
> Applied, thanks!

Thank you and thank you and everybody else for all the feedback and
reviews, I appreciate it.

K. B.