[00/18] zforse_ts: assorted cleanups

Message ID	20240824055047.1706392-1-dmitry.torokhov@gmail.com (mailing list archive)
Headers	show Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDF2F9F8; Sat, 24 Aug 2024 05:50:57 +0000 (UTC) From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: =?utf-8?q?Heiko_St=C3=BCbner?= <heiko@sntech.de>, linux-input@vger.kernel.org Cc: Andreas Kemnade <andreas@kemnade.info>, linux-kernel@vger.kernel.org Subject: [PATCH 00/18] zforse_ts: assorted cleanups Date: Fri, 23 Aug 2024 22:50:24 -0700 Message-ID: <20240824055047.1706392-1-dmitry.torokhov@gmail.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	zforse_ts: assorted cleanups \| expand [00/18] zforse_ts: assorted cleanups [01/18] Input: zforce_ts - use devm_add_action_or_reset() [02/18] Input: zforce_ts - simplify reporting of slot state [03/18] Input: zforce_ts - remove support for platfrom data [04/18] Input: zforce_ts - do not explicitly set EV_SYN, etc bits [05/18] Input: zforce_ts - handle errors from input_mt_init_sots() [06/18] Input: zforce_ts - remove unneeded locking [07/18] Input: zforce_ts - ensure that pm_stay_awake() and pm_relax() are balanced [08/18] Input: zforce_ts - use guard notation when acquiring mutexes [09/18] Input: zforce_ts - switch to using get_unaligned_le16 [10/18] Input: zforce_ts - make parsing of contacts less confusing [11/18] Input: zforce_ts - do not ignore errors when acquiring regulator [12/18] Input: zforce_ts - use dev_err_probe() where appropriate [13/18] Input: zforce_ts - make zforce_idtable constant [14/18] Input: zforce_ts - stop treating VDD regulator as optional [15/18] Input: zforce_ts - switch to using devm_regulator_get_enable() [16/18] Input: zforce_ts - do not hardcode interrupt level [17/18] Input: zforce_ts - remove assert/deassert wrappers [18/18] Input: zforce_ts - switch to using asynchronous probing

Message ID

20240824055047.1706392-1-dmitry.torokhov@gmail.com (mailing list archive)

Headers

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: =?utf-8?q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
 linux-input@vger.kernel.org
Cc: Andreas Kemnade <andreas@kemnade.info>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 00/18] zforse_ts: assorted cleanups
Date: Fri, 23 Aug 2024 22:50:24 -0700
Message-ID: <20240824055047.1706392-1-dmitry.torokhov@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

zforse_ts: assorted cleanups | expand

Message

Dmitry Torokhov Aug. 24, 2024, 5:50 a.m. UTC

Hi,

This is a set of somewhat random cleanups for the zforce_ts driver. 

Heiko, Andreas, if you still have access to the hardware it would be
great if you could give it a spin.

Thanks!

Dmitry Torokhov (17):
  Input: zforce_ts - simplify reporting of slot state
  Input: zforce_ts - remove support for platfrom data
  Input: zforce_ts - do not explicitly set EV_SYN, etc bits
  Input: zforce_ts - handle errors from input_mt_init_sots()
  Input: zforce_ts - remove unneeded locking
  Input: zforce_ts - ensure that pm_stay_awake() and pm_relax() are balanced
  Input: zforce_ts - use guard notation when acquiring mutexes
  Input: zforce_ts - switch to using get_unaligned_le16
  Input: zforce_ts - make parsing of contacts less confusing
  Input: zforce_ts - do not ignore errors when acquiring regulator
  Input: zforce_ts - use dev_err_probe() where appropriate
  Input: zforce_ts - make zforce_idtable constant
  Input: zforce_ts - stop treating VDD regulator as optional
  Input: zforce_ts - switch to using devm_regulator_get_enable()
  Input: zforce_ts - do not hardcode interrupt level
  Input: zforce_ts - remove assert/deassert wrappers
  Input: zforce_ts - switch to using asynchronous probing

Sudip Mukherjee (1):
  Input: zforce_ts - use devm_add_action_or_reset()

 drivers/input/touchscreen/zforce_ts.c   | 474 ++++++++++--------------
 include/linux/platform_data/zforce_ts.h |  15 -
 2 files changed, 192 insertions(+), 297 deletions(-)
 delete mode 100644 include/linux/platform_data/zforce_ts.h

Comments

Andreas Kemnade Sept. 2, 2024, 8:08 a.m. UTC | #1

Hi Dmitry,

Am Fri, 23 Aug 2024 22:50:24 -0700
schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:

> Hi,
> 
> This is a set of somewhat random cleanups for the zforce_ts driver. 
> 
> Heiko, Andreas, if you still have access to the hardware it would be
> great if you could give it a spin.
> 
> Thanks!
> 
nice cleanup,
I tested a bit on the Toline Shine 2HD without gui (have not rebased my
other stuff to 6.11 yet)

A short move on the touchscreen gives this:
Event: time 1725264307.093542, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 24
Event: time 1725264307.093542, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1159
Event: time 1725264307.093542, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 596
Event: time 1725264307.093542, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 11
Event: time 1725264307.093542, type 3 (EV_ABS), code 49 (ABS_MT_TOUCH_MINOR), value 11
Event: time 1725264307.093542, type 3 (EV_ABS), code 52 (ABS_MT_ORIENTATION), value 0
Event: time 1725264307.093542, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 1
Event: time 1725264307.093542, type 3 (EV_ABS), code 0 (ABS_X), value 1159
Event: time 1725264307.093542, type 3 (EV_ABS), code 1 (ABS_Y), value 596
Event: time 1725264307.093542, -------------- SYN_REPORT ------------
Event: time 1725264307.096361, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1039
Event: time 1725264307.096361, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 607
Event: time 1725264307.096361, type 3 (EV_ABS), code 0 (ABS_X), value 1039
Event: time 1725264307.096361, type 3 (EV_ABS), code 1 (ABS_Y), value 607
Event: time 1725264307.096361, -------------- SYN_REPORT ------------
Event: time 1725264307.112426, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 934
Event: time 1725264307.112426, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 637
Event: time 1725264307.112426, type 3 (EV_ABS), code 0 (ABS_X), value 934
Event: time 1725264307.112426, type 3 (EV_ABS), code 1 (ABS_Y), value 637
Event: time 1725264307.112426, -------------- SYN_REPORT ------------
Event: time 1725264307.131523, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 859
Event: time 1725264307.131523, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 661
Event: time 1725264307.131523, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 12
Event: time 1725264307.131523, type 3 (EV_ABS), code 0 (ABS_X), value 859
Event: time 1725264307.131523, type 3 (EV_ABS), code 1 (ABS_Y), value 661
Event: time 1725264307.131523, -------------- SYN_REPORT ------------
Event: time 1725264307.150540, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 795
Event: time 1725264307.150540, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 671
Event: time 1725264307.150540, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 13
Event: time 1725264307.150540, type 3 (EV_ABS), code 0 (ABS_X), value 795
Event: time 1725264307.150540, type 3 (EV_ABS), code 1 (ABS_Y), value 671
Event: time 1725264307.150540, -------------- SYN_REPORT ------------
Event: time 1725264307.169589, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 760
Event: time 1725264307.169589, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 675
Event: time 1725264307.169589, type 3 (EV_ABS), code 0 (ABS_X), value 760
Event: time 1725264307.169589, type 3 (EV_ABS), code 1 (ABS_Y), value 675
Event: time 1725264307.169589, -------------- SYN_REPORT ------------
Event: time 1725264307.188157, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value -1
Event: time 1725264307.188157, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 0
Event: time 1725264307.188157, -------------- SYN_REPORT ------------

So,

Tested-by: Andreas Kemnade <andreas@kemnade.info> # Tolino Shine2HD

Regards,
Andreas

Dmitry Torokhov Sept. 6, 2024, 5:49 a.m. UTC | #2

On Mon, Sep 02, 2024 at 10:08:05AM +0200, Andreas Kemnade wrote:
> Hi Dmitry,
> 
> Am Fri, 23 Aug 2024 22:50:24 -0700
> schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> 
> > Hi,
> > 
> > This is a set of somewhat random cleanups for the zforce_ts driver. 
> > 
> > Heiko, Andreas, if you still have access to the hardware it would be
> > great if you could give it a spin.
> > 
> > Thanks!
> > 
> nice cleanup,
> I tested a bit on the Toline Shine 2HD without gui (have not rebased my
> other stuff to 6.11 yet)
> 
> A short move on the touchscreen gives this:
> Event: time 1725264307.093542, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 24
> Event: time 1725264307.093542, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1159
> Event: time 1725264307.093542, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 596
> Event: time 1725264307.093542, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 11
> Event: time 1725264307.093542, type 3 (EV_ABS), code 49 (ABS_MT_TOUCH_MINOR), value 11
> Event: time 1725264307.093542, type 3 (EV_ABS), code 52 (ABS_MT_ORIENTATION), value 0
> Event: time 1725264307.093542, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 1
> Event: time 1725264307.093542, type 3 (EV_ABS), code 0 (ABS_X), value 1159
> Event: time 1725264307.093542, type 3 (EV_ABS), code 1 (ABS_Y), value 596
> Event: time 1725264307.093542, -------------- SYN_REPORT ------------
> Event: time 1725264307.096361, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1039
> Event: time 1725264307.096361, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 607
> Event: time 1725264307.096361, type 3 (EV_ABS), code 0 (ABS_X), value 1039
> Event: time 1725264307.096361, type 3 (EV_ABS), code 1 (ABS_Y), value 607
> Event: time 1725264307.096361, -------------- SYN_REPORT ------------
> Event: time 1725264307.112426, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 934
> Event: time 1725264307.112426, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 637
> Event: time 1725264307.112426, type 3 (EV_ABS), code 0 (ABS_X), value 934
> Event: time 1725264307.112426, type 3 (EV_ABS), code 1 (ABS_Y), value 637
> Event: time 1725264307.112426, -------------- SYN_REPORT ------------
> Event: time 1725264307.131523, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 859
> Event: time 1725264307.131523, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 661
> Event: time 1725264307.131523, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 12
> Event: time 1725264307.131523, type 3 (EV_ABS), code 0 (ABS_X), value 859
> Event: time 1725264307.131523, type 3 (EV_ABS), code 1 (ABS_Y), value 661
> Event: time 1725264307.131523, -------------- SYN_REPORT ------------
> Event: time 1725264307.150540, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 795
> Event: time 1725264307.150540, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 671
> Event: time 1725264307.150540, type 3 (EV_ABS), code 48 (ABS_MT_TOUCH_MAJOR), value 13
> Event: time 1725264307.150540, type 3 (EV_ABS), code 0 (ABS_X), value 795
> Event: time 1725264307.150540, type 3 (EV_ABS), code 1 (ABS_Y), value 671
> Event: time 1725264307.150540, -------------- SYN_REPORT ------------
> Event: time 1725264307.169589, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 760
> Event: time 1725264307.169589, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 675
> Event: time 1725264307.169589, type 3 (EV_ABS), code 0 (ABS_X), value 760
> Event: time 1725264307.169589, type 3 (EV_ABS), code 1 (ABS_Y), value 675
> Event: time 1725264307.169589, -------------- SYN_REPORT ------------
> Event: time 1725264307.188157, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value -1
> Event: time 1725264307.188157, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 0
> Event: time 1725264307.188157, -------------- SYN_REPORT ------------
> 
> So,
> 
> Tested-by: Andreas Kemnade <andreas@kemnade.info> # Tolino Shine2HD

Thank you for giving it a spin!