mbox series

[v5,0/4] HID: hidraw: HIDIOCREVOKE introduction

Message ID 20240827-hidraw-revoke-v5-0-d004a7451aea@kernel.org (mailing list archive)
Headers show
Series HID: hidraw: HIDIOCREVOKE introduction | expand

Message

Benjamin Tissoires Aug. 27, 2024, 8:19 a.m. UTC
The is the v5 of the HIDIOCREVOKE patches.

After a small discussion with Peter, we decided to:
- drop the BPF hooks that are problematic (Linus doesn't want
  "ALLOW_ERROR_INJECTION" to be used as "normal" fmodret bpf hooks)
- punt those BPF hooks later once we get the API right
- I'll be the one sending that new version, given that it's easier for
  me ATM

For testing the patch, and for convenience, I added a new selftest
program that can test this new ioctl. This will also allow us to
integrate the (future) BPF hooks and show how this should be used.

Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
---
Changes in v5:
- check for ENODEV when required in selftests
- create new common header for the HID tests that can be reused in other
  HID selftests
- Link to v4: https://lore.kernel.org/r/20240827-hidraw-revoke-v4-0-88c6795bf867@kernel.org

Link to v3: https://lore.kernel.org/all/20240812052753.GA478917@quokka/

---
Benjamin Tissoires (3):
      selftests/hid: extract the utility part of hid_bpf.c into its own header
      selftests/hid: Add initial hidraw tests skeleton
      selftests/hid: Add HIDIOCREVOKE tests

Peter Hutterer (1):
      HID: hidraw: add HIDIOCREVOKE ioctl

 drivers/hid/hidraw.c                     |  39 ++-
 include/linux/hidraw.h                   |   1 +
 include/uapi/linux/hidraw.h              |   1 +
 tools/testing/selftests/hid/.gitignore   |   1 +
 tools/testing/selftests/hid/Makefile     |   2 +-
 tools/testing/selftests/hid/hid_bpf.c    | 437 +------------------------------
 tools/testing/selftests/hid/hid_common.h | 436 ++++++++++++++++++++++++++++++
 tools/testing/selftests/hid/hidraw.c     | 237 +++++++++++++++++
 8 files changed, 714 insertions(+), 440 deletions(-)
---
base-commit: 6e4436539ae182dc86d57d13849862bcafaa4709
change-id: 20240826-hidraw-revoke-0a02ebb21743

Best regards,

Comments

Benjamin Tissoires Aug. 29, 2024, 8:41 a.m. UTC | #1
On Tue, 27 Aug 2024 17:19:28 +0900, bentiss@kernel.org wrote:
> The is the v5 of the HIDIOCREVOKE patches.
> 
> After a small discussion with Peter, we decided to:
> - drop the BPF hooks that are problematic (Linus doesn't want
>   "ALLOW_ERROR_INJECTION" to be used as "normal" fmodret bpf hooks)
> - punt those BPF hooks later once we get the API right
> - I'll be the one sending that new version, given that it's easier for
>   me ATM
> 
> [...]

Applied to hid/hid.git (for-6.12/hidraw), thanks!

[1/4] HID: hidraw: add HIDIOCREVOKE ioctl
      https://git.kernel.org/hid/hid/c/b31c9d9dc343
[2/4] selftests/hid: extract the utility part of hid_bpf.c into its own header
      https://git.kernel.org/hid/hid/c/375e9bde9fc0
[3/4] selftests/hid: Add initial hidraw tests skeleton
      https://git.kernel.org/hid/hid/c/8163892a629c
[4/4] selftests/hid: Add HIDIOCREVOKE tests
      https://git.kernel.org/hid/hid/c/321f7798cfb8

Cheers,