mbox series

[v2,0/3] HID: hid-bigbenff: fixing three crash bugs in a gamepad driver

Message ID 74d73ebc-0cff-768d-00b7-57bb9b44124f@hanno.de (mailing list archive)
Headers show
Series HID: hid-bigbenff: fixing three crash bugs in a gamepad driver | expand

Message

Hanno Zulla Feb. 18, 2020, 11:30 a.m. UTC 
Hi Benjamin,

> I think the patches are correct (have you tested them with actual HW?).

Yes, I did, and am also properly embarrassed that I didn't notice the 
double free bug in the original driver.

> However, checkpatch complains that the From and Signed-off-by email
> differ. Can you send a v2 with a fix for that?

Here it is.

Thanks,

Hanno

Comments

Benjamin Tissoires Feb. 19, 2020, 7:54 a.m. UTC | #1 
On Tue, Feb 18, 2020 at 12:44 PM Hanno Zulla <kontakt@hanno.de> wrote:
>
> Hi Benjamin,
>
> > I think the patches are correct (have you tested them with actual HW?).
>
> Yes, I did, and am also properly embarrassed that I didn't notice the
> double free bug in the original driver.
>
> > However, checkpatch complains that the From and Signed-off-by email
> > differ. Can you send a v2 with a fix for that?
>
> Here it is.
>

Thanks for the quick respin.

Not sure what happened, but the commit title was duplicated in all of
the commits.

Anyway, not a big deal, fixed and pushed to for-5.6/upstream-fixes

Cheers,
Benjamin

> Thanks,
>
> Hanno
>