From patchwork Mon Nov 25 02:13:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3227811 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 001069F3B8 for ; Mon, 25 Nov 2013 02:13:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 23A012024D for ; Mon, 25 Nov 2013 02:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 200062023F for ; Mon, 25 Nov 2013 02:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065Ab3KYCN4 (ORCPT ); Sun, 24 Nov 2013 21:13:56 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:14704 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560Ab3KYCNz (ORCPT ); Sun, 24 Nov 2013 21:13:55 -0500 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWS0085ARIY4K00@mailout2.samsung.com> for linux-input@vger.kernel.org; Mon, 25 Nov 2013 11:13:46 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id AE.96.18459.A52B2925; Mon, 25 Nov 2013 11:13:46 +0900 (KST) X-AuditID: cbfee68f-b7f336d00000481b-d0-5292b25a1c52 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0F.3E.02580.A52B2925; Mon, 25 Nov 2013 11:13:46 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MWS00CIXRIYRCB0@mmp1.samsung.com>; Mon, 25 Nov 2013 11:13:46 +0900 (KST) From: Jingoo Han To: 'Dmitry Torokhov' Cc: 'Dmitry Torokhov' , linux-input@vger.kernel.org, 'Jingoo Han' Subject: [PATCH] Input: serio: remove unnecessary pci_set_drvdata() Date: Mon, 25 Nov 2013 11:13:46 +0900 Message-id: <001b01cee983$f894c510$e9be4f30$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7pg/RssH2XbsxtQMmM4P0YTcHa8w== Content-language: ko x-cr-hashedpuzzle: gso= C4cC EJjp HXDB JMyq JvTs QUPj Wc+j X2x9 cdzU fTi7 h8XO mFT0 mnVs oXSb uhwC; 4; ZABtAGkAdAByAHkALgB0AG8AcgBvAGsAaABvAHYAQABnAG0AYQBpAGwALgBjAG8AbQA7AGQAdABvAHIAQABtAGEAaQBsAC4AcgB1ADsAagBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGkAbgBwAHUAdABAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnAA==; Sosha1_v1; 7; {639AFCC9-70C2-4D0F-BD5E-2CB4CB7699E6}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Mon, 25 Nov 2013 02:13:39 GMT; WwBQAEEAVABDAEgAXQAgAEkAbgBwAHUAdAA6ACAAcwBlAHIAaQBvADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {639AFCC9-70C2-4D0F-BD5E-2CB4CB7699E6} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t8zfd2oTZOCDBYtkrc4vOgFo8XD7S9Y LS4vvMRqcfPTN1YHFo+ds+6ye0yZe4TVo2/LKkaPz5vkAliiuGxSUnMyy1KL9O0SuDJ2/drK WvCVteLA0ulMDYw/WboYOTkkBEwkPvyfAGWLSVy4t54NxBYSWMYoMelsJkzNypc/WCDiixgl 7r4u72LkArJ/MUqcfTuBCSTBJqAm8eXLYfYuRg4OEQFDiRlrqkBMZoF0ibMHPUAqhAWcJT49 /Ag2nkVAVWLilQ52EJtXwFbi7+XZjBC2oMSPyffAVjELaEms33mcCcKWl9i85i0zyEgJAXWJ R391QcIiAnoSO5rmQJWLSOx78Y4R4uIfLBI/jqpB2KYSyx5cZwK5WELgHLvEs7MLWCBuEJD4 NvkQC8RMWYlNB5gh6iUlDq64wTKBUWIWkotmIbloFpKLZiFZvYCRZRWjaGpBckFxUnqRsV5x Ym5xaV66XnJ+7iZGSDz272C8e8D6EGMy0PqJzFKiyfnAeM4riTc0NjOyMDUxNTYytzQjTVhJ nPf+w6QgIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYyTbI7x+6dcWf73ImfFxg6OG0d43Tl7 rG//vfTVW2xO3qU5O1/Nfa61xpIjdjLrPfbgS54r8o9Zi4qZ3hf0skuqdHFSXTGt30Fd11db 1ODtPpuVjEFG7tn6+xXd4r/d6day67Kf2ZRcONX3z4dXmnt8rlv+sJn99NR59ZUKBpe//5ts 2zr7TJcSS3FGoqEWc1FxIgAuUwn23QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t9jAd2oTZOCDPr2S1scXvSC0eLh9hes FpcXXmK1uPnpG6sDi8fOWXfZPabMPcLq0bdlFaPH501yASxRDYw2GamJKalFCql5yfkpmXnp tkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUA7lRTKEnNKgUIBicXFSvp2mCaEhrjp WsA0Ruj6hgTB9RgZoIGEdYwZu35tZS34ylpxYOl0pgbGnyxdjJwcEgImEitf/oCyxSQu3FvP BmILCSxilLj7uryLkQvI/sUocfbtBCaQBJuAmsSXL4fZuxg5OEQEDCVmrKkCMZkF0iXOHvQA qRAWcJb49PAj2BgWAVWJiVc62EFsXgFbib+XZzNC2IISPybfA1vLLKAlsX7ncSYIW15i85q3 zCAjJQTUJR791QUJiwjoSexomgNVLiKx78U7RoiLf7BI/DiqBmGbSix7cJ1pAqPQLCQbZiHZ MAvJhllIRi1gZFnFKJpakFxQnJSea6hXnJhbXJqXrpecn7uJERzvz6R2MK5ssDjEKMDBqMTD a1E5KUiINbGsuDL3EKMEB7OSCO+eOqAQb0piZVVqUX58UWlOavEhxmRgAExklhJNzgemoryS eENjEzMjSyMzCyMTc3PShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYLygwLH1Q8OFpcf7 Zib9m91+4bnG7RVyuj8OT1n9fe7HF/M5ykJdz9xeslXxispKhV1lzlN0bVM3bnP1OqgrkSkc +Kl2+S1rLW6mg4kThDydX6lPvFkiztlcZ1p/uSGjmOEOl5Zb+rvv/3SeyvYKcpaGXvQzOuIx 1f2YyL1Dhi4TP8msnWc+R0GJpTgj0VCLuag4EQBFq6hnOwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/input/serio/pcips2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c index 76f8383..13062f6 100644 --- a/drivers/input/serio/pcips2.c +++ b/drivers/input/serio/pcips2.c @@ -181,7 +181,6 @@ static void pcips2_remove(struct pci_dev *dev) struct pcips2_data *ps2if = pci_get_drvdata(dev); serio_unregister_port(ps2if->io); - pci_set_drvdata(dev, NULL); kfree(ps2if); pci_release_regions(dev); pci_disable_device(dev);