From patchwork Tue Mar 14 05:10:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cameron Gutman X-Patchwork-Id: 9622487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D1F4A604CC for ; Tue, 14 Mar 2017 05:10:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE9AC28434 for ; Tue, 14 Mar 2017 05:10:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B315C284CE; Tue, 14 Mar 2017 05:10:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32F3428434 for ; Tue, 14 Mar 2017 05:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750736AbdCNFK0 (ORCPT ); Tue, 14 Mar 2017 01:10:26 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34223 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdCNFKZ (ORCPT ); Tue, 14 Mar 2017 01:10:25 -0400 Received: by mail-pg0-f68.google.com with SMTP id b5so21896663pgg.1; Mon, 13 Mar 2017 22:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=uuzQSRnKu1a9CpBrIUmY4Ea65W/FMg+u/EnGWeh20dw=; b=g2Imwz05tLI6HUdC4F0IDMUnEiBk2w31ESPYOq0FtGyJk0M+22wp+m0HLCJu3XpnY5 KE1I6GHInQRiBppA3hWy/CCLLyVTjWlQr//6vz4Iyaf0mEvsE5zWuEfln321AVBS8FDf nfVefyWNTZG+PBNQY7sdrjhIaw7dBBruQC8IfRxzCnNt83K7SeeBfsP9+yWGKY2Hn185 esXTHlbXFE9tAbwpHPmAwUNklrsZKjfHP/dxuvmZhtymKNjvMmYpBL2Fi+kF1PQUblNZ BI+kcdY2pZgBUsoISLXphUj90BpppFEeDaVEm1+9rJGKFe7j2HVsSJja0dmaNKfGxaB0 cM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uuzQSRnKu1a9CpBrIUmY4Ea65W/FMg+u/EnGWeh20dw=; b=RuxhNwK/Bfc59N8w0aju5evyrpGv5W4BBNRo+brAqPbnBD4lSZstxIKSrIi0HwTPaG FCgDu5OkzjS1s04UfSCmomlfjdMChTE6QKpp2srm7lbeut8LDtBIw8NW4t/h3qAzesuW p5DsvU85HnhEsA0aB5zzKsj8ZXDpLSK92qPl2FWevG9b8ylrGRLFgdmrfRXv0MpFqoxH +MNWqqV4z6SUx7IFjiqHaqOpGcm+RdgBA03lSFPiuKxri2zbTvN0jDzB/bYoQC7ZfetQ SsGJnVKgLlK8UIC6RO2RaQhW1EwV44Nq56JH6M0fcKnA0VCrllrruIqXnW9xUnul24hf hqow== X-Gm-Message-State: AMke39m3D6S18+mIdW3cxL5dbxq6G9t0l0XxJr72qxdjdkL8TOjjfS94vecz644uKcBgdQ== X-Received: by 10.99.247.17 with SMTP id x17mr41471616pgh.5.1489468224245; Mon, 13 Mar 2017 22:10:24 -0700 (PDT) Received: from [192.168.1.46] ([174.127.240.168]) by smtp.gmail.com with ESMTPSA id w131sm35502731pfd.34.2017.03.13.22.10.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 22:10:23 -0700 (PDT) Subject: Re: Synaptics RMI4 touchpad regression in 4.11-rc1 To: Andrew Duggan , Benjamin Tissoires , Thorsten Leemhuis , Jiri Kosina References: <375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com> <7964888d-05dd-b109-973a-e0503884e2e2@leemhuis.info> <20170313131356.GH4378@mail.corp.redhat.com> <20170313131537.GI4378@mail.corp.redhat.com> <07543e67-efef-a764-02e6-d81d30b89a1c@synaptics.com> Cc: nick@shmanahar.org, cheiny@synaptics.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Cameron Gutman Message-ID: <03d8e6ac-1ba4-36a6-cc07-0c07e61f754f@gmail.com> Date: Mon, 13 Mar 2017 22:10:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <07543e67-efef-a764-02e6-d81d30b89a1c@synaptics.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/13/2017 06:35 PM, Andrew Duggan wrote: > > > On 03/13/2017 06:15 AM, Benjamin Tissoires wrote: >> [Resending, forgot to add Jiri in CC] >> >> On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote: >>> On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote: >>>> Lo! On 12.03.2017 02:55, Cameron Gutman wrote: >>>>> Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9343's >>>>> Synaptics touchpad and dropping some errors into dmesg. Here are the >>>>> messages that seem RMI-related: >>>>> >>>>> rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version >>>>> rmi4_f34: probe of rmi4-00.fn34 failed with error -22 >>>>> rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324 >>>>> input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19 >>>>> hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01 >>>> FWIW, I get this on my XPS 13 DE (9360) with 4.11-rc1: >>>> >>>> input: SynPS/2 Synaptics TouchPad as >>>> /devices/platform/i8042/serio1/input/input6 >>>> rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version >>>> rmi4_f34: probe of rmi4-00.fn34 failed with error -22 >>>> rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, >>>> product: TM3038-003, fw id: 2375007 >>>> input: Synaptics TM3038-003 as >>>> /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-8/i2c-DLL075B:01/0018:06CB:76AF.0001/input/input20 >>>> hid-rmi 0018:06CB:76AF.0001: input,hidraw0: I2C HID v1.00 Mouse >>>> [DLL075B:01 06CB:76AF] on i2c-DLL075B:01 >>>> >>>>> […] >>>>> Compared to hid-multitouch, the RMI stack seems to have completely broken >>>>> palm rejection and introduced some random jumpiness during fine pointing >>>>> motions. I don't know if these issues are caused by the above errors or >>>>> are a separate issue. > > The error about the bootloader version not being recognized just means that updating the firmware is not supported on this touchpad. It is only the F34 firmware update functionality which is failing to load. The palm rejection and jumps are not related to this error. > Maybe that code path should be changed to not make as much noise when it runs on known unsupported hardware. Something like the attached patch? > Looking at how hid-multitouch handles palms it looks like palms should not be reported as active when calling input_mt_report_slot_state(). I'm setting the tool type to MT_TOOL_PALM when the firmware determines that a contact is a palm. But, that does not seem to be sufficient enough to have the palms filtered out. After some quick testing it looks like the change below will restore palm rejection similar to that provided by hid-multitouch. > It looks like your email client ate the tabs, but if I apply the change myself it seems to fix the palm rejection regression for me. Tested-by: Cameron Gutman >>>> Just to confirm: I noticed "jumpiness during fine pointing motions" as >>>> well since switching to 4.11-rc. > > One of my test systems is a XPS 13 9343 and I have not really seen any jumpiness. But, based on the data I am seeing that if I lift my finger and place it again in a short period of time the first event or so will be at the location of the previous contact. Then it will switch over to the current location. When switching over to hid-multitouch I was unable to reproduce this behavior. This definitely could be the source of the jumps. > The jumpiness definitely happens without lifting my finger, but I'm willing to test any patch you think would improve the situation. Moving one finger slowly in a figure-8 across my touchpad shows the issue clearly for me. The small variations in speed of my finger due to the friction on the trackpad get magnified to relatively large jumpy pointer movements on screen. It seems much more noticeable in diagonal movements than completely vertical or horizontal movements. Regards, Cameron --- -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c index 56c6c39..1291d9a 100644 --- a/drivers/input/rmi4/rmi_f34v7.c +++ b/drivers/input/rmi4/rmi_f34v7.c @@ -1369,9 +1369,9 @@ int rmi_f34v7_probe(struct f34_data *f34) } else if (f34->bootloader_id[1] == 7) { f34->bl_version = 7; } else { - dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version\n", - __func__); - return -EINVAL; + dev_info(&f34->fn->dev, "%s: Unsupported bootloader version: %u\n", + __func__, f34->bootloader_id[1]); + return -ENODEV; } memset(&f34->v7.blkcount, 0x00, sizeof(f34->v7.blkcount));