From patchwork Thu Oct 1 02:55:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 7303621 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 896409F536 for ; Thu, 1 Oct 2015 02:56:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B90052077E for ; Thu, 1 Oct 2015 02:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A74B920784 for ; Thu, 1 Oct 2015 02:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357AbbJAC4R (ORCPT ); Wed, 30 Sep 2015 22:56:17 -0400 Received: from m50-135.163.com ([123.125.50.135]:43618 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755094AbbJAC4N (ORCPT ); Wed, 30 Sep 2015 22:56:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ZkLqKpjpRdGR+fbuuE wWmrN8GytK26doCfL+nnhQLC4=; b=JtsTXA3to9cLLYJq7jh81/eFDvb0LXg9Ba A9FfIt64/rq+ZTzmhUhdq8UCnxyjLL7E0g7Ci0Avjljd+GHYWPktxdCezoDHeXQl j3zYPrDMxcBq39SY5+o1YClSXYWv4guVZEoOC8+0pJx0RDPbYasl0hjqwqEYJe9I 6hDDsO+Rk= Received: from localhost (unknown [116.77.128.85]) by smtp5 (Coremail) with SMTP id D9GowADHSpmyoAxWYiDMCg--.26913S3; Thu, 01 Oct 2015 10:55:48 +0800 (CST) From: Geliang Tang To: Dmitry Torokhov , Hans de Goede , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Masaki Ota Cc: Geliang Tang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] Input: alps: drop unlikely before IS_ERR_OR_NULL Date: Thu, 1 Oct 2015 10:55:30 +0800 Message-Id: <081982d1188978b6020952afb4c2dcf3bc42fa1f.1443667610.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <03d18502ed7ed417f136c091f417d2d88c147ec6.1443667610.git.geliangtang@163.com> References: <03d18502ed7ed417f136c091f417d2d88c147ec6.1443667610.git.geliangtang@163.com> In-Reply-To: <03d18502ed7ed417f136c091f417d2d88c147ec6.1443667610.git.geliangtang@163.com> References: <03d18502ed7ed417f136c091f417d2d88c147ec6.1443667610.git.geliangtang@163.com> X-CM-TRANSID: D9GowADHSpmyoAxWYiDMCg--.26913S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7JrWxZr1kuFyxKF18CF45ZFb_yoWfGrb_WF y8Zrs7Xw12yF1vyw15Cw1avrWvy3ZaqrWkAw4F939xJF1xZrZxJ3yDZF4kZr4UW3yxCF98 Kw13Gr1ruw47KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjsmitUUUUU== X-Originating-IP: [116.77.128.85] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiJRSGmVUL7OhjdQAAsi Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 4d24686..b4f146a 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -1367,7 +1367,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, /* On V2 devices the DualPoint Stick reports bare packets */ dev = priv->dev2; dev2 = psmouse->dev; - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { + } else if (IS_ERR_OR_NULL(priv->dev3)) { /* Register dev3 mouse if we received PS/2 packet first time */ if (!IS_ERR(priv->dev3)) psmouse_queue_work(psmouse, &priv->dev3_register_work,