diff mbox

[1/2] Input: sur40: Delete an error message for a failed memory allocation in sur40_probe()

Message ID 122986b6-b7f2-9b34-b11d-4d63557a2b97@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring Jan. 20, 2018, 9:28 p.m. UTC
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 20 Jan 2018 22:11:24 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/input/touchscreen/sur40.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Kepplinger-Novakovic Jan. 22, 2018, 7 a.m. UTC | #1
On 2018-01-20 22:28, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Jan 2018 22:11:24 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Martin Kepplinger <martink@posteo.de>

> ---
>  drivers/input/touchscreen/sur40.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index f16f8358c70a..c7a0a92b2044 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -591,7 +591,6 @@ static int sur40_probe(struct usb_interface *interface,
>  	sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
>  	sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
>  	if (!sur40->bulk_in_buffer) {
> -		dev_err(&interface->dev, "Unable to allocate input buffer.");
>  		error = -ENOMEM;
>  		goto err_free_polldev;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
index f16f8358c70a..c7a0a92b2044 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/input/touchscreen/sur40.c
@@ -591,7 +591,6 @@  static int sur40_probe(struct usb_interface *interface,
 	sur40->bulk_in_epaddr = endpoint->bEndpointAddress;
 	sur40->bulk_in_buffer = kmalloc(sur40->bulk_in_size, GFP_KERNEL);
 	if (!sur40->bulk_in_buffer) {
-		dev_err(&interface->dev, "Unable to allocate input buffer.");
 		error = -ENOMEM;
 		goto err_free_polldev;
 	}