From patchwork Tue Jan 19 00:19:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 73789 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o0J0IePX013922 for ; Tue, 19 Jan 2010 00:19:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422Ab0ASATn (ORCPT ); Mon, 18 Jan 2010 19:19:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752478Ab0ASATm (ORCPT ); Mon, 18 Jan 2010 19:19:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257Ab0ASATl (ORCPT ); Mon, 18 Jan 2010 19:19:41 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0J0JcjU028358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Jan 2010 19:19:39 -0500 Received: from [10.36.8.89] (vpn2-8-89.ams2.redhat.com [10.36.8.89]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0J0JaAE015196; Mon, 18 Jan 2010 19:19:37 -0500 Subject: Re: [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel From: Bastien Nocera To: Ping Cheng Cc: Dmitry Torokhov , linux-input , BlueZ development , bgunn@solekai.com In-Reply-To: <1263850557.20565.3204.camel@localhost.localdomain> References: <1263833399.20565.2905.camel@localhost.localdomain> <167e8a331001181144u54cefd15m65a5a63ca8c4c4b6@mail.gmail.com> <1263850557.20565.3204.camel@localhost.localdomain> Date: Tue, 19 Jan 2010 00:19:35 +0000 Message-ID: <1263860375.20565.3374.camel@localhost.localdomain> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From 15fd982367e4e8f5ceeec3b8f802fb0f43da4ef9 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Mon, 18 Jan 2010 16:13:41 +0000 Subject: [PATCH] [hid] Implement Wacom quirk in the kernel The hid-wacom driver required user-space to poke at the tablet to make it send data about the cursor location. This patch makes it do the same thing but in the kernel. Signed-off-by: Bastien Nocera --- drivers/hid/hid-wacom.c | 33 +++++++++++++++++++++++++++++++++ 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c index 7475421..ad71a85 100644 --- a/drivers/hid/hid-wacom.c +++ b/drivers/hid/hid-wacom.c @@ -155,7 +155,9 @@ static int wacom_probe(struct hid_device *hdev, struct hid_input *hidinput; struct input_dev *input; struct wacom_data *wdata; + char rep_data[3]; int ret; + int limit; wdata = kzalloc(sizeof(*wdata), GFP_KERNEL); if (wdata == NULL) { @@ -165,6 +167,7 @@ static int wacom_probe(struct hid_device *hdev, hid_set_drvdata(hdev, wdata); + /* Parse the HID report now */ ret = hid_parse(hdev); if (ret) { dev_err(&hdev->dev, "parse failed\n"); @@ -177,6 +180,36 @@ static int wacom_probe(struct hid_device *hdev, goto err_free; } + /* Set Wacom mode2 */ + rep_data[0] = 0x53; /* HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE */ + rep_data[1] = 0x03; rep_data[2] = 0x00; + limit =3; + do { + ret = hdev->hid_output_raw_report(hdev, rep_data, 3); + } while (ret < 0 && limit-- > 0); + if (ret < 0) { + dev_err(&hdev->dev, "failed to poke device #1, %d\n", ret); + goto err_free; + } + + rep_data[0] = 0x71; /* HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE */ + /* 0x06 - high reporting speed, 0x05 - low speed */ + rep_data[1] = 0x06; rep_data[2] = 0x00; + limit = 3; + do { + ret = hdev->hid_output_raw_report(hdev, rep_data, 3); + } while (ret < 0 && limit-- > 0); + if (ret < 0) { + dev_err(&hdev->dev, "failed to poke device #2, %d\n", ret); + goto err_free; + } + + ret = hid_parse(hdev); + if (ret) { + dev_err(&hdev->dev, "parse failed\n"); + goto err_free; + } + hidinput = list_entry(hdev->inputs.next, struct hid_input, list); input = hidinput->input; -- 1.6.5.2