From patchwork Tue Nov 30 18:44:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 367831 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oAUIiTJQ029886 for ; Tue, 30 Nov 2010 18:44:31 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525Ab0K3Soa (ORCPT ); Tue, 30 Nov 2010 13:44:30 -0500 Received: from phoenix3.szarvasnet.hu ([87.101.127.16]:37508 "EHLO phoenix3.szarvasnet.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755471Ab0K3So2 (ORCPT ); Tue, 30 Nov 2010 13:44:28 -0500 Received: from mail.szarvas.hu (localhost [127.0.0.1]) by phoenix3.szarvasnet.hu (Postfix) with SMTP id C37F14DC011; Tue, 30 Nov 2010 19:44:25 +0100 (CET) Received: from localhost.localdomain (catvpool-576570d8.szarvasnet.hu [87.101.112.216]) by phoenix3.szarvasnet.hu (Postfix) with ESMTPA id 638FB270001; Tue, 30 Nov 2010 19:44:25 +0100 (CET) From: Gabor Juhos To: Dmitry Torokhov Cc: Ben Gardiner , linux-input@vger.kernel.org, Ralf Baechle , Kevin Hilman , nsekhar@ti.com Subject: [PATCH 3/8] input: gpio_keys_polled: avoid possible division by zero Date: Tue, 30 Nov 2010 19:44:18 +0100 Message-Id: <1291142663-1011-4-git-send-email-juhosg@openwrt.org> X-Mailer: git-send-email 1.7.2.1 In-Reply-To: <4CF541ED.80905@openwrt.org> References: <4CF541ED.80905@openwrt.org> X-VBMS: A11DB08DE43 | phoenix3 | 127.0.0.1 | | | Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Tue, 30 Nov 2010 18:44:31 +0000 (UTC) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index 5275c9e..9636c2f 100644 --- a/drivers/input/keyboard/gpio_keys_polled.c +++ b/drivers/input/keyboard/gpio_keys_polled.c @@ -114,8 +114,8 @@ static int __devinit gpio_keys_polled_probe(struct platform_device *pdev) int error; int i; - if (!pdata) - return -ENXIO; + if (!pdata || !pdata->poll_interval) + return -EINVAL; bdev = kzalloc(sizeof(struct gpio_keys_polled_dev) + pdata->nbuttons * sizeof(struct gpio_keys_button_data),