From patchwork Tue Jun 7 14:37:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 857022 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p57EbmKC002536 for ; Tue, 7 Jun 2011 14:37:48 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579Ab1FGOhr (ORCPT ); Tue, 7 Jun 2011 10:37:47 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:50991 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753517Ab1FGOhr (ORCPT ); Tue, 7 Jun 2011 10:37:47 -0400 Received: from finisterre.wolfsonmicro.main (unknown [87.246.78.26]) by opensource2.wolfsonmicro.com (Postfix) with ESMTPSA id 3DEB31B4181; Tue, 7 Jun 2011 15:37:46 +0100 (BST) Received: from broonie by finisterre.wolfsonmicro.main with local (Exim 4.76) (envelope-from ) id 1QTxPd-0006Rh-6A; Tue, 07 Jun 2011 15:37:45 +0100 From: Mark Brown To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com, Mark Brown Subject: [PATCH] Input: wm831x-ts - Remove unneeded clearing of driver data Date: Tue, 7 Jun 2011 15:37:44 +0100 Message-Id: <1307457464-24747-1-git-send-email-broonie@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.7.5.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 07 Jun 2011 14:37:48 +0000 (UTC) This is unneeded, only a bound driver can use driver data and a driver relying on the state prior to probe() is buggy. Signed-off-by: Mark Brown --- drivers/input/touchscreen/wm831x-ts.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/input/touchscreen/wm831x-ts.c b/drivers/input/touchscreen/wm831x-ts.c index 9175d49..e5b63b9 100644 --- a/drivers/input/touchscreen/wm831x-ts.c +++ b/drivers/input/touchscreen/wm831x-ts.c @@ -389,7 +389,6 @@ static __devexit int wm831x_ts_remove(struct platform_device *pdev) input_unregister_device(wm831x_ts->input_dev); kfree(wm831x_ts); - platform_set_drvdata(pdev, NULL); return 0; }