From patchwork Mon Jun 20 21:01:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 898592 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5KL2Rqo030557 for ; Mon, 20 Jun 2011 21:02:27 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755815Ab1FTVCL (ORCPT ); Mon, 20 Jun 2011 17:02:11 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:60329 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798Ab1FTVCK (ORCPT ); Mon, 20 Jun 2011 17:02:10 -0400 Received: from gallifrey.ext.pengutronix.de ([2001:6f8:1178:4:5054:ff:fe8d:eefb] helo=pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1QYlbh-0003Vo-7M; Mon, 20 Jun 2011 23:02:05 +0200 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Dmitry Torokhov , Bo Shen , Axel Lin , linux-input@vger.kernel.org Subject: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata Date: Mon, 20 Jun 2011 23:01:12 +0200 Message-Id: <1308603674-19264-1-git-send-email-w.sang@pengutronix.de> X-Mailer: git-send-email 1.7.2.5 X-SA-Exim-Connect-IP: 2001:6f8:1178:4:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 20 Jun 2011 21:02:27 +0000 (UTC) A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang Cc: Dmitry Torokhov Cc: Bo Shen Cc: Axel Lin Acked-by: Jean Delvare --- This is more a cleanup than a bugfix. Still, would be happy to have this obsolete programming style largely removed in 3.0 if possible. drivers/input/keyboard/qt1070.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c index ca7b891..b21bf5b 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client) input_unregister_device(data->input); kfree(data); - i2c_set_clientdata(client, NULL); - return 0; }