From patchwork Tue Jul 5 23:26:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ping Cheng X-Patchwork-Id: 947152 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p65NN0dC002015 for ; Tue, 5 Jul 2011 23:24:29 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775Ab1GEXY3 (ORCPT ); Tue, 5 Jul 2011 19:24:29 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:59063 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741Ab1GEXY2 (ORCPT ); Tue, 5 Jul 2011 19:24:28 -0400 Received: by iwn6 with SMTP id 6so5619237iwn.19 for ; Tue, 05 Jul 2011 16:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=Obd8O3Xl8XF1qtOdlvTsNBCk0XEB9+s7IXUvJ3nVScs=; b=FK6nCx6f6Uur8V8UvNtFZ01yyiDj0Xyu0WBHATwAq6+kaKBsDoXxwznX6GJFnKV6zh FRGcqy31KxJ23L0a5Dr4TIe0cow/VpnvIb/mSK0QjZupbwX3m2i/NpccEVY+bScJNQ+Y CNw6HlDXouXFF1F40QaTKiBiP47zP345kI8g4= Received: by 10.42.153.4 with SMTP id k4mr8970156icw.103.1309908268229; Tue, 05 Jul 2011 16:24:28 -0700 (PDT) Received: from localhost.localdomain ([67.51.163.10]) by mx.google.com with ESMTPS id c2sm2113108ibd.5.2011.07.05.16.24.27 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jul 2011 16:24:27 -0700 (PDT) From: Ping Cheng To: linux-input@vger.kernel.org Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se, Ping Cheng , Ping Cheng Subject: [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo Date: Tue, 5 Jul 2011 16:26:00 -0700 Message-Id: <1309908360-18866-1-git-send-email-pinglinux@gmail.com> X-Mailer: git-send-email 1.7.5.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 05 Jul 2011 23:24:29 +0000 (UTC) The old code may call input_sync without sending any other events. Although the sync event will be ignored in the userland, eliminating unnecessary kernel events is the right way to go. Signed-off-by: Ping Cheng Reviewed-by: Chris Bagwell --- drivers/input/tablet/wacom_wac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 19554a4..03ebcc8 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c @@ -300,8 +300,8 @@ static int wacom_graphire_irq(struct wacom_wac *wacom) wacom->id[1] = 0; input_report_abs(input, ABS_MISC, wacom->id[1]); input_event(input, EV_MSC, MSC_SERIAL, 0xf0); + retval = 1; } - retval = 1; break; } exit: