Input: mma8450: add device tree probe support

Message ID	1311265551-23233-1-git-send-email-shawn.guo@linaro.org (mailing list archive)
State	Accepted
Commit	71ff069c3d6a2b23eaf516bc714a20ce0cdc3609
Headers	show Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6LGDhQU017857 for <patchwork-linux-input@patchwork.kernel.org>; Thu, 21 Jul 2011 16:13:43 GMT From: Shawn Guo <shawn.guo@linaro.org> To: linux-input@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org, patches@linaro.org, Shawn Guo <shawn.guo@linaro.org>, Grant Likely <grant.likely@secretlab.ca>, Sammy He <r62914@freescale.com>, Eric Miao <eric.miao@linaro.org>, Dmitry Torokhov <dtor@mail.ru> Subject: [PATCH] Input: mma8450: add device tree probe support Date: Fri, 22 Jul 2011 00:25:51 +0800 Message-Id: <1311265551-23233-1-git-send-email-shawn.guo@linaro.org> Sender: linux-input-owner@vger.kernel.org Precedence: bulk

Message ID

1311265551-23233-1-git-send-email-shawn.guo@linaro.org (mailing list archive)

State

Accepted

Commit

71ff069c3d6a2b23eaf516bc714a20ce0cdc3609

Headers

From: Shawn Guo <shawn.guo@linaro.org>
To: linux-input@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org, patches@linaro.org,
	Shawn Guo <shawn.guo@linaro.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Sammy He <r62914@freescale.com>, Eric Miao <eric.miao@linaro.org>,
	Dmitry Torokhov <dtor@mail.ru>
Subject: [PATCH] Input: mma8450: add device tree probe support
Date: Fri, 22 Jul 2011 00:25:51 +0800
Message-Id: <1311265551-23233-1-git-send-email-shawn.guo@linaro.org>
Sender: linux-input-owner@vger.kernel.org
Precedence: bulk

Commit Message

Shawn Guo July 21, 2011, 4:25 p.m. UTC

It adds device tree probe support for mma8450 driver.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Sammy He <r62914@freescale.com>
Cc: Eric Miao <eric.miao@linaro.org>
Cc: Dmitry Torokhov <dtor@mail.ru>
---
 .../devicetree/bindings/input/fsl-mma8450.txt      |   11 +++++++++++
 drivers/input/misc/mma8450.c                       |    8 ++++++++
 2 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt

Comments

Shawn Guo July 29, 2011, 2:38 a.m. UTC | #1

Any comments?

Regards,
Shawn

On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
> It adds device tree probe support for mma8450 driver.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Sammy He <r62914@freescale.com>
> Cc: Eric Miao <eric.miao@linaro.org>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> ---
>  .../devicetree/bindings/input/fsl-mma8450.txt      |   11 +++++++++++
>  drivers/input/misc/mma8450.c                       |    8 ++++++++
>  2 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
> new file mode 100644
> index 0000000..a00c94c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
> @@ -0,0 +1,11 @@
> +* Freescale MMA8450 3-Axis Accelerometer
> +
> +Required properties:
> +- compatible : "fsl,mma8450".
> +
> +Example:
> +
> +accelerometer: mma8450@1c {
> +	compatible = "fsl,mma8450";
> +	reg = <0x1c>;
> +};
> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
> index 20f8f92..6c76cf7 100644
> --- a/drivers/input/misc/mma8450.c
> +++ b/drivers/input/misc/mma8450.c
> @@ -24,6 +24,7 @@
>  #include <linux/delay.h>
>  #include <linux/i2c.h>
>  #include <linux/input-polldev.h>
> +#include <linux/of_device.h>
>  
>  #define MMA8450_DRV_NAME	"mma8450"
>  
> @@ -229,10 +230,17 @@ static const struct i2c_device_id mma8450_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, mma8450_id);
>  
> +static const struct of_device_id mma8450_dt_ids[] = {
> +	{ .compatible = "fsl,mma8450", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
> +
>  static struct i2c_driver mma8450_driver = {
>  	.driver = {
>  		.name	= MMA8450_DRV_NAME,
>  		.owner	= THIS_MODULE,
> +		.of_match_table = mma8450_dt_ids,
>  	},
>  	.probe		= mma8450_probe,
>  	.remove		= __devexit_p(mma8450_remove),
> -- 
> 1.7.4.1
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Eric Miao July 29, 2011, 3 a.m. UTC | #2

On Fri, Jul 29, 2011 at 10:38 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> Any comments?
>

Shawn,

Patch looks OK to me.

> Regards,
> Shawn
>
> On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
>> It adds device tree probe support for mma8450 driver.
>>
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Sammy He <r62914@freescale.com>
>> Cc: Eric Miao <eric.miao@linaro.org>
>> Cc: Dmitry Torokhov <dtor@mail.ru>
>> ---
>>  .../devicetree/bindings/input/fsl-mma8450.txt      |   11 +++++++++++
>>  drivers/input/misc/mma8450.c                       |    8 ++++++++
>>  2 files changed, 19 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> new file mode 100644
>> index 0000000..a00c94c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> @@ -0,0 +1,11 @@
>> +* Freescale MMA8450 3-Axis Accelerometer
>> +
>> +Required properties:
>> +- compatible : "fsl,mma8450".
>> +
>> +Example:
>> +
>> +accelerometer: mma8450@1c {
>> +     compatible = "fsl,mma8450";
>> +     reg = <0x1c>;
>> +};
>> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
>> index 20f8f92..6c76cf7 100644
>> --- a/drivers/input/misc/mma8450.c
>> +++ b/drivers/input/misc/mma8450.c
>> @@ -24,6 +24,7 @@
>>  #include <linux/delay.h>
>>  #include <linux/i2c.h>
>>  #include <linux/input-polldev.h>
>> +#include <linux/of_device.h>
>>
>>  #define MMA8450_DRV_NAME     "mma8450"
>>
>> @@ -229,10 +230,17 @@ static const struct i2c_device_id mma8450_id[] = {
>>  };
>>  MODULE_DEVICE_TABLE(i2c, mma8450_id);
>>
>> +static const struct of_device_id mma8450_dt_ids[] = {
>> +     { .compatible = "fsl,mma8450", },
>> +     { /* sentinel */ }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
>> +
>>  static struct i2c_driver mma8450_driver = {
>>       .driver = {
>>               .name   = MMA8450_DRV_NAME,
>>               .owner  = THIS_MODULE,
>> +             .of_match_table = mma8450_dt_ids,
>>       },
>>       .probe          = mma8450_probe,
>>       .remove         = __devexit_p(mma8450_remove),
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> devicetree-discuss mailing list
>> devicetree-discuss@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/devicetree-discuss
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Grant Likely July 31, 2011, 3:07 a.m. UTC | #3

On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
> It adds device tree probe support for mma8450 driver.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Sammy He <r62914@freescale.com>
> Cc: Eric Miao <eric.miao@linaro.org>
> Cc: Dmitry Torokhov <dtor@mail.ru>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> ---
>  .../devicetree/bindings/input/fsl-mma8450.txt      |   11 +++++++++++
>  drivers/input/misc/mma8450.c                       |    8 ++++++++
>  2 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
> new file mode 100644
> index 0000000..a00c94c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
> @@ -0,0 +1,11 @@
> +* Freescale MMA8450 3-Axis Accelerometer
> +
> +Required properties:
> +- compatible : "fsl,mma8450".
> +
> +Example:
> +
> +accelerometer: mma8450@1c {
> +	compatible = "fsl,mma8450";
> +	reg = <0x1c>;
> +};
> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
> index 20f8f92..6c76cf7 100644
> --- a/drivers/input/misc/mma8450.c
> +++ b/drivers/input/misc/mma8450.c
> @@ -24,6 +24,7 @@
>  #include <linux/delay.h>
>  #include <linux/i2c.h>
>  #include <linux/input-polldev.h>
> +#include <linux/of_device.h>
>  
>  #define MMA8450_DRV_NAME	"mma8450"
>  
> @@ -229,10 +230,17 @@ static const struct i2c_device_id mma8450_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, mma8450_id);
>  
> +static const struct of_device_id mma8450_dt_ids[] = {
> +	{ .compatible = "fsl,mma8450", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
> +
>  static struct i2c_driver mma8450_driver = {
>  	.driver = {
>  		.name	= MMA8450_DRV_NAME,
>  		.owner	= THIS_MODULE,
> +		.of_match_table = mma8450_dt_ids,
>  	},
>  	.probe		= mma8450_probe,
>  	.remove		= __devexit_p(mma8450_remove),
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dmitry Torokhov Aug. 1, 2011, 2:56 a.m. UTC | #4

On Sat, Jul 30, 2011 at 09:07:25PM -0600, Grant Likely wrote:
> On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
> > It adds device tree probe support for mma8450 driver.
> > 
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Sammy He <r62914@freescale.com>
> > Cc: Eric Miao <eric.miao@linaro.org>
> > Cc: Dmitry Torokhov <dtor@mail.ru>
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 

Applied, thanks.

diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
new file mode 100644
index 0000000..a00c94c
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
@@ -0,0 +1,11 @@ 
+* Freescale MMA8450 3-Axis Accelerometer
+
+Required properties:
+- compatible : "fsl,mma8450".
+
+Example:
+
+accelerometer: mma8450@1c {
+	compatible = "fsl,mma8450";
+	reg = <0x1c>;
+};
diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
index 20f8f92..6c76cf7 100644
--- a/drivers/input/misc/mma8450.c
+++ b/drivers/input/misc/mma8450.c
@@ -24,6 +24,7 @@ 
 #include <linux/delay.h>
 #include <linux/i2c.h>
 #include <linux/input-polldev.h>
+#include <linux/of_device.h>
 
 #define MMA8450_DRV_NAME	"mma8450"
 
@@ -229,10 +230,17 @@  static const struct i2c_device_id mma8450_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, mma8450_id);
 
+static const struct of_device_id mma8450_dt_ids[] = {
+	{ .compatible = "fsl,mma8450", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
+
 static struct i2c_driver mma8450_driver = {
 	.driver = {
 		.name	= MMA8450_DRV_NAME,
 		.owner	= THIS_MODULE,
+		.of_match_table = mma8450_dt_ids,
 	},
 	.probe		= mma8450_probe,
 	.remove		= __devexit_p(mma8450_remove),