@@ -317,11 +317,12 @@ static int spear_kbd_suspend(struct device *dev)
mutex_lock(&input_dev->mutex);
- if (input_dev->users)
- clk_enable(kbd->clk);
-
- if (device_may_wakeup(&pdev->dev))
+ if (device_may_wakeup(&pdev->dev)) {
enable_irq_wake(kbd->irq);
+ } else {
+ if (input_dev->users)
+ clk_disable(kbd->clk);
+ }
mutex_unlock(&input_dev->mutex);
@@ -336,11 +337,12 @@ static int spear_kbd_resume(struct device *dev)
mutex_lock(&input_dev->mutex);
- if (device_may_wakeup(&pdev->dev))
+ if (device_may_wakeup(&pdev->dev)) {
disable_irq_wake(kbd->irq);
-
- if (input_dev->users)
- clk_enable(kbd->clk);
+ } else {
+ if (input_dev->users)
+ clk_enable(kbd->clk);
+ }
mutex_unlock(&input_dev->mutex);
SPEAr keyboard should normally disable clock during suspend and enable it during resume. For cases where it is expected to act as a wakeup source the clock can remain in the same state i.e. kept enabled if it is being used. Signed-off-by: Shiraz Hashim <shiraz.hashim@st.com> --- Changes since V1: * remove discarded irq balancing patch dependency drivers/input/keyboard/spear-keyboard.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)