From patchwork Tue Jul 24 13:59:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Pereira da Silva X-Patchwork-Id: 1231261 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 425EDDF25A for ; Tue, 24 Jul 2012 13:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754237Ab2GXN6y (ORCPT ); Tue, 24 Jul 2012 09:58:54 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:40851 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616Ab2GXN6x (ORCPT ); Tue, 24 Jul 2012 09:58:53 -0400 Received: by yenl2 with SMTP id l2so6660461yen.19 for ; Tue, 24 Jul 2012 06:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer; bh=8eAtKSx/UOI+p8oP1z9DOh3UDEUH09a1UuWwmpBNXXk=; b=HNSIyvrPv61OHp1SXjkLlRzXwoSTApgJZLgRnheRQF8obI/2R71GHX48y84z/CPQx8 Y2v91HmeJ5dV9WkiiLD4zwyq5K+mJqjdatRqvoMn6fD6lsVDg+IVNvfZBKwkCPTmbfyh PHbDN9WYWLb8j7p9jHQTkmUaFIVns/4vomVyHADY7vXDL6NXQBTIeDn3naBnXgnFRCH+ B3jXX2QzxYngV7qufDrq111k3cuCKX5aAJ5cZkbW1I6LoqNzMktAgNU1smou6J8RoKGJ pV1N/aPgYT+gU2b2NtlVsMduevvOF3V6GNLiCppmQV09F5K4Is8kq5NRimAgZt40OqLk Laqg== Received: by 10.236.80.34 with SMTP id j22mr19193451yhe.82.1343138332276; Tue, 24 Jul 2012 06:58:52 -0700 (PDT) Received: from localhost.localdomain (c934e77a.virtua.com.br. [201.52.231.122]) by mx.google.com with ESMTPS id e19sm15373427ann.10.2012.07.24.06.58.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jul 2012 06:58:50 -0700 (PDT) From: Alexandre Pereira da Silva To: Alexandre Pereira da Silva , Grant Likely , Rob Herring , Rob Landley , Dmitry Torokhov , Tobias Klauser , David Jander , JJ Ding , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v3] input: gpio_keys_polled: convert to dt Date: Tue, 24 Jul 2012 10:59:06 -0300 Message-Id: <1343138346-11942-1-git-send-email-aletes.xgr@gmail.com> X-Mailer: git-send-email 1.7.10 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Signed-off-by: Alexandre Pereira da Silva Signed-off-by: Dmitry Torokhov --- Dmitry, I've made a few adjustments from your patch. Applies to linux-next next-20120723 Changes since v2: * Use modification suggestion from Dmitry and avoid pdata copy Changes since v1: * Add biding documentation * Fix sizeof in memset * Cleanup dt properties extraction * Use for_each macro * Fix memleak on buttons .../devicetree/bindings/input/gpio-keys-polled.txt | 38 ++++++ drivers/input/keyboard/gpio_keys_polled.c | 140 +++++++++++++++++++- 2 files changed, 173 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/gpio-keys-polled.txt diff --git a/Documentation/devicetree/bindings/input/gpio-keys-polled.txt b/Documentation/devicetree/bindings/input/gpio-keys-polled.txt new file mode 100644 index 0000000..313abef --- /dev/null +++ b/Documentation/devicetree/bindings/input/gpio-keys-polled.txt @@ -0,0 +1,38 @@ +Device-Tree bindings for input/gpio_keys_polled.c keyboard driver + +Required properties: + - compatible = "gpio-keys-polled"; + - poll-interval: Poll interval time in milliseconds + +Optional properties: + - autorepeat: Boolean, Enable auto repeat feature of Linux input + subsystem. + +Each button (key) is represented as a sub-node of "gpio-keys-polled": +Subnode properties: + + - gpios: OF device-tree gpio specification. + - label: Descriptive name of the key. + - linux,code: Keycode to emit. + +Optional subnode-properties: + - linux,input-type: Specify event type this button/key generates. + If not specified defaults to <1> == EV_KEY. + - debounce-interval: Debouncing interval time in milliseconds. + If not specified defaults to 5. + - gpio-key,wakeup: Boolean, button can wake-up the system. + +Example nodes: + + gpio_keys_polled { + compatible = "gpio-keys-polled"; + #address-cells = <1>; + #size-cells = <0>; + poll-interval = <100>; + autorepeat; + button@21 { + label = "GPIO Key UP"; + linux,code = <103>; + gpios = <&gpio1 0 1>; + }; + ... diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index 20c8ab1..c728aba 100644 --- a/drivers/input/keyboard/gpio_keys_polled.c +++ b/drivers/input/keyboard/gpio_keys_polled.c @@ -25,6 +25,8 @@ #include #include #include +#include +#include #define DRV_NAME "gpio-keys-polled" @@ -100,6 +102,108 @@ static void gpio_keys_polled_close(struct input_polled_dev *dev) pdata->disable(bdev->dev); } +#ifdef CONFIG_OF +static struct gpio_keys_platform_data * __devinit +gpio_keys_polled_get_devtree_pdata(struct device *dev) +{ + struct device_node *node, *pp; + struct gpio_keys_platform_data *pdata; + struct gpio_keys_button *buttons; + int error; + int nbuttons; + int i; + + node = dev->of_node; + if (!node) { + error = -ENODEV; + goto err_out; + } + + nbuttons = of_get_child_count(node); + if (nbuttons == 0) { + error = -ENODEV; + goto err_out; + } + + pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); + if (!pdata) { + error = -ENOMEM; + goto err_out; + } + + buttons = kzalloc(nbuttons * sizeof(*buttons), GFP_KERNEL); + if (!buttons) { + error = -ENOMEM; + goto err_free_pdata; + } + + pdata->nbuttons = nbuttons; + pdata->buttons = buttons; + + pdata->rep = !!of_get_property(node, "autorepeat", NULL); + of_property_read_u32(node, "poll-interval", &pdata->poll_interval); + + i = 0; + for_each_child_of_node(node, pp) { + enum of_gpio_flags flags; + + if (!of_find_property(pp, "gpios", NULL)) { + pdata->nbuttons--; + dev_warn(dev, "Found button without gpios\n"); + continue; + } + + buttons[i].gpio = of_get_gpio_flags(pp, 0, &flags); + buttons[i].active_low = flags & OF_GPIO_ACTIVE_LOW; + + if (of_property_read_u32(pp, "linux,code", &buttons[i].code)) { + dev_err(dev, "Button without keycode: 0x%x\n", + buttons[i].gpio); + error = -EINVAL; + goto err_free_buttons; + } + + buttons[i].desc = of_get_property(pp, "label", NULL); + + if (of_property_read_u32(pp, "linux,input-type", + &buttons[i].type)) + buttons[i].type = EV_KEY; + + buttons[i].wakeup = !!of_get_property(pp, "gpio-key,wakeup", + NULL); + + if (of_property_read_u32(pp, "debounce-interval", + &buttons[i].debounce_interval)) + buttons[i].debounce_interval = 5; + + i++; + } + + return pdata; + +err_free_buttons: + kfree(buttons); +err_free_pdata: + kfree(pdata); +err_out: + return ERR_PTR(error); +} + +static struct of_device_id gpio_keys_polled_of_match[] = { + { .compatible = "gpio-keys-polled", }, + { }, +}; +MODULE_DEVICE_TABLE(of, gpio_keys_polled_of_match); + +#else + +static inline struct gpio_keys_platform_data * +gpio_keys_polled_get_devtree_pdata(struct device *dev) +{ + return ERR_PTR(-ENODEV); +} +#endif + static int __devinit gpio_keys_polled_probe(struct platform_device *pdev) { struct gpio_keys_platform_data *pdata = pdev->dev.platform_data; @@ -110,15 +214,24 @@ static int __devinit gpio_keys_polled_probe(struct platform_device *pdev) int error; int i; - if (!pdata || !pdata->poll_interval) - return -EINVAL; + if (!pdata) { + pdata = gpio_keys_polled_get_devtree_pdata(dev); + if (IS_ERR(pdata)) + return PTR_ERR(pdata); + } + + if (!pdata->poll_interval) { + error = -EINVAL; + goto err_free_pdata; + } bdev = kzalloc(sizeof(struct gpio_keys_polled_dev) + pdata->nbuttons * sizeof(struct gpio_keys_button_data), GFP_KERNEL); if (!bdev) { dev_err(dev, "no memory for private data\n"); - return -ENOMEM; + error = -ENOMEM; + goto err_free_pdata; } poll_dev = input_allocate_polled_device(); @@ -197,7 +310,7 @@ static int __devinit gpio_keys_polled_probe(struct platform_device *pdev) /* report initial state of the buttons */ for (i = 0; i < pdata->nbuttons; i++) gpio_keys_polled_check_state(input, &pdata->buttons[i], - &bdev->data[i]); + &bdev->data[i]); return 0; @@ -209,8 +322,15 @@ err_free_gpio: err_free_bdev: kfree(bdev); - platform_set_drvdata(pdev, NULL); + +err_free_pdata: + /* If we have no platform_data, we allocated pdata dynamically. */ + if (!dev_get_platdata(&pdev->dev)) { + kfree(pdata->buttons); + kfree(pdata); + } + return error; } @@ -227,6 +347,15 @@ static int __devexit gpio_keys_polled_remove(struct platform_device *pdev) input_free_polled_device(bdev->poll_dev); + /* + * If we had no platform_data, we allocated pdata dynamically and + * must free it here. + */ + if (!dev_get_platdata(&pdev->dev)) { + kfree(pdata->buttons); + kfree(pdata); + } + kfree(bdev); platform_set_drvdata(pdev, NULL); @@ -239,6 +368,7 @@ static struct platform_driver gpio_keys_polled_driver = { .driver = { .name = DRV_NAME, .owner = THIS_MODULE, + .of_match_table = of_match_ptr(gpio_keys_polled_of_match), }, }; module_platform_driver(gpio_keys_polled_driver);