From patchwork Wed Aug 22 10:17:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Farnsworth X-Patchwork-Id: 1360851 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 91A46DF280 for ; Wed, 22 Aug 2012 10:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116Ab2HVKRc (ORCPT ); Wed, 22 Aug 2012 06:17:32 -0400 Received: from claranet-outbound-smtp05.uk.clara.net ([195.8.89.38]:44195 "EHLO claranet-outbound-smtp05.uk.clara.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519Ab2HVKRc (ORCPT ); Wed, 22 Aug 2012 06:17:32 -0400 Received: from 110.100.155.90.in-addr.arpa ([90.155.100.110]:26222 helo=f17simon.office.onelan.co.uk) by relay05.mail.eu.clara.net (relay.clara.net [213.253.3.45]:1025) with esmtpa (authdaemon_plain:simon.farnsworth@onelan.co.uk) id 1T4802-0007TY-Gt (return-path ); Wed, 22 Aug 2012 10:17:22 +0000 From: Simon Farnsworth To: linux-input@vger.kernel.org Cc: Benjamin Tissoires , Benjamin Tissoires , Jiri Kosina , Henrik Rydberg , Simon Farnsworth Subject: [PATCH] hid: Remove QUANTA from special drivers list Date: Wed, 22 Aug 2012 11:17:17 +0100 Message-Id: <1345630637-7142-1-git-send-email-simon.farnsworth@onelan.co.uk> X-Mailer: git-send-email 1.7.11.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This QUANTA device is driven by the generic hid-multitouch.ko driver, and therefore shouldn't be in the special drivers list. I've gone over the entire special drivers list in hid-core.c; this is the only device I spotted that's listed as needing a special driver, but doesn't have an entry in a struct hid_driver's id_table. Signed-off-by: Simon Farnsworth --- Applying just this patch is enough to fix the problem I described in my mail "QUANTA touchscreen controller integrated in HP2310ti no longer recognised (regression in 3.5 and later as compared to 3.3)". This looks like an oversight in commit 4fa3a58; that commit removes most multitouch screens from this list, but missed this one. Henrik should be able to confirm, though, so I'd appreciate his sign-off. drivers/hid/hid-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 60ea284..8bf8a64 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1624,7 +1624,6 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_WKB2000) }, { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) }, { HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) }, - { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN) }, { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) }, { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ARVO) }, { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ISKU) },