| Message ID | 1349529287-23193-2-git-send-email-yann.cantin@laposte.net (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
Jiri, Are you OK with this change? Yann, Is the device usable at all with generic HID driver? If it isn't then maybe we should blacklist it unconditionally? Thanks. On Sat, Oct 06, 2012 at 03:14:46PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin <yann.cantin@laposte.net> > --- > drivers/hid/hid-core.c | 3 +++ > drivers/hid/hid-ids.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index bd3971b..59ffaa2 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1937,6 +1937,9 @@ static const struct hid_device_id hid_ignore_list[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) }, > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) }, > +#if defined(CONFIG_INPUT_EBEAM_USB) > + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_EBEAM) }, > +#endif > { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, > { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, > { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 269b509..df826b8 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -274,6 +274,9 @@ > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72D0 0x72d0 > #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72C4 0x72c4 > > +#define USB_VENDOR_ID_EFI 0x2650 > +#define USB_DEVICE_ID_EFI_EBEAM 0x1311 > + > #define USB_VENDOR_ID_ELECOM 0x056e > #define USB_DEVICE_ID_ELECOM_BM084 0x0061 > > -- > 1.7.10 >
Hi, Le 10/10/2012 18:37, Dmitry Torokhov a écrit : > Is the device usable at all with generic HID driver? If it isn't then > maybe we should blacklist it unconditionally? Without the libusb based proprietary stack, the device is unusable under linux. If i correctly understand, libusb need a driver to be present in the first place, (even a useless generic-usb) to be able to grab the device. If we unconditionally blacklist the device and the ebeam driver isn't loaded (not compiled for example), no way for libusb (and the stack) to handle the device. As stated before, i'm not comfortable with the risk of breaking other hypothetical support, even proprietary.
On Wed, 10 Oct 2012, Dmitry Torokhov wrote: > Jiri, > > Are you OK with this change? Yes, please take it through your tree together with the proper driver and add Acked-by: Jiri Kosina <jkosina@suse.cz> to the HID blacklist additions. Thanks,
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index bd3971b..59ffaa2 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1937,6 +1937,9 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) }, +#if defined(CONFIG_INPUT_EBEAM_USB) + { HID_USB_DEVICE(USB_VENDOR_ID_EFI, USB_DEVICE_ID_EFI_EBEAM) }, +#endif { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 269b509..df826b8 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -274,6 +274,9 @@ #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72D0 0x72d0 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72C4 0x72c4 +#define USB_VENDOR_ID_EFI 0x2650 +#define USB_DEVICE_ID_EFI_EBEAM 0x1311 + #define USB_VENDOR_ID_ELECOM 0x056e #define USB_DEVICE_ID_ELECOM_BM084 0x0061
Signed-off-by: Yann Cantin <yann.cantin@laposte.net> --- drivers/hid/hid-core.c | 3 +++ drivers/hid/hid-ids.h | 3 +++ 2 files changed, 6 insertions(+)