From patchwork Wed Nov 14 16:48:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 1742891 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 2DB9EDF264 for ; Wed, 14 Nov 2012 16:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161228Ab2KNQtd (ORCPT ); Wed, 14 Nov 2012 11:49:33 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:45862 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423064Ab2KNQsQ (ORCPT ); Wed, 14 Nov 2012 11:48:16 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so488529pbc.19 for ; Wed, 14 Nov 2012 08:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=adFUVDWbkvQPPCuPX9/VHVZqv59asTXktwl/sKCtKAk=; b=R0CaWsKdgxkAZlOhErIVtfEev7pozpcOax9Hzvwz/QK4RMH5wbCOmjqchwaqO/U1J8 R777HjdHHsBsrLn5vMlpAyrdwhRTRUNGxxNU4JzIDJhjA6MId5Zxcd8knH1oejIrhRDG Cvk4ZxCjKJnvrtVX668Xn58CXL3YXoiWJdFwA2jivusQzW8HNvvj8fT3hqybtrY/tS27 Em2fhRC8MuzX5DL/B21dHE3lqiwhPcfHc1ghV23vxk/zrBm2L78QGgMNEhuCXj1Dr0XA /OnaSbzbXS+eDAS5p1lhtJhmW1dlCmBImBMxntIelM9Eytjjjb06Qnra2Xpb9BWBAhCh VbtQ== Received: by 10.68.191.229 with SMTP id hb5mr37322254pbc.57.1352911696378; Wed, 14 Nov 2012 08:48:16 -0800 (PST) Received: from mailhub.coreip.homeip.net (c-67-188-112-76.hsd1.ca.comcast.net. [67.188.112.76]) by mx.google.com with ESMTPS id kb3sm7980919pbc.27.2012.11.14.08.48.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 14 Nov 2012 08:48:15 -0800 (PST) From: Dmitry Torokhov To: Alban Bedel Cc: linux-input@vger.kernel.org Subject: [PATCH 4/5] Input: tca8418_keypad - increase severity of failures in probe() Date: Wed, 14 Nov 2012 08:48:07 -0800 Message-Id: <1352911688-5001-4-git-send-email-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352911688-5001-1-git-send-email-dmitry.torokhov@gmail.com> References: <1352911688-5001-1-git-send-email-dmitry.torokhov@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Failures to build a keymap, request an IRQ, or register input device are fatal for the driver, therefore the messages should have "error" severity instead of "debug". Signed-off-by: Dmitry Torokhov Reviewed-by: Alban Bedel --- drivers/input/keyboard/tca8418_keypad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c index 35340c3..10047eb 100644 --- a/drivers/input/keyboard/tca8418_keypad.c +++ b/drivers/input/keyboard/tca8418_keypad.c @@ -348,7 +348,7 @@ static int __devinit tca8418_keypad_probe(struct i2c_client *client, error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols, keypad_data->keymap, input); if (error) { - dev_dbg(dev, "Failed to build keymap\n"); + dev_err(dev, "Failed to build keymap\n"); goto fail2; } @@ -367,14 +367,14 @@ static int __devinit tca8418_keypad_probe(struct i2c_client *client, IRQF_ONESHOT, client->name, keypad_data); if (error) { - dev_dbg(dev, "Unable to claim irq %d; error %d\n", + dev_err(dev, "Unable to claim irq %d; error %d\n", client->irq, error); goto fail2; } error = input_register_device(input); if (error) { - dev_dbg(dev, "Unable to register input device, error: %d\n", + dev_err(dev, "Unable to register input device, error: %d\n", error); goto fail3; }