From patchwork Thu Mar 28 07:53:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2355171 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 58481DF2A1 for ; Thu, 28 Mar 2013 08:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751095Ab3C1IFM (ORCPT ); Thu, 28 Mar 2013 04:05:12 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:64241 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435Ab3C1IFK (ORCPT ); Thu, 28 Mar 2013 04:05:10 -0400 Received: by mail-pa0-f51.google.com with SMTP id jh10so1929409pab.38 for ; Thu, 28 Mar 2013 01:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=rkGR+nFU5FIdEo1u6B1dxFLsXjZ3IUjQLoTl38K3Kw0=; b=Wk9NYsMOtRO89ofjBsNQTsS0Yn3z7U1NvV2EkFqJPQh/pv6VUn3Cp6zw47MigmhoK1 ruIvCvlhgtBCg3EpWgthafNl0FB4woIGAL7mG1oPtE4cUzf+CmOGlSOHVXiiY2OkQ5LC E5xdfJqdFLmB4hfmn8JrauIrckUy6oXwEFcEqYFBsoHzdbstRhfnASYUT+2ZXr8z4I6G i9BZ4WO7OGsYhiQ1NLsb8t9ArOsP0luhLXe4sIlGpL9Z0afkgafUGlcRLuczwaqAM83T VHnA37xIe1arNarSJibusIV2diJ7d+yKcU7Gb7R4o4Vhbyyuv1QF7KibdKzCB5wnVLqs 3F4Q== X-Received: by 10.66.7.138 with SMTP id j10mr34547690paa.221.1364457909554; Thu, 28 Mar 2013 01:05:09 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id oq3sm26743190pac.16.2013.03.28.01.05.07 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 Mar 2013 01:05:09 -0700 (PDT) From: Sachin Kamat To: linux-input@vger.kernel.org Cc: dmitry.torokhov@gmail.com, sachin.kamat@linaro.org Subject: [PATCH 2/2] Input: eeti_ts - Remove redundant null check Date: Thu, 28 Mar 2013 13:23:42 +0530 Message-Id: <1364457222-4381-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1364457222-4381-1-git-send-email-sachin.kamat@linaro.org> References: <1364457222-4381-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlWiRv5TBcHol3CfNzH5cYOrHuUID9RdbRVc+Jm2J0UVRtY9oyc4FbyXfCVO9YaCTMtELs1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org 'pdata' is already dereferenced earlier. Hence this check is meaningless. Signed-off-by: Sachin Kamat --- drivers/input/touchscreen/eeti_ts.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c index 55255a9..8fe5086 100644 --- a/drivers/input/touchscreen/eeti_ts.c +++ b/drivers/input/touchscreen/eeti_ts.c @@ -206,8 +206,7 @@ static int eeti_ts_probe(struct i2c_client *client, if (err < 0) goto err1; - if (pdata) - priv->irq_active_high = pdata->irq_active_high; + priv->irq_active_high = pdata->irq_active_high; irq_flags = priv->irq_active_high ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;