diff mbox

[3/3] Input: gpio_mouse - Remove redundant platform_set_drvdata()

Message ID 1367577742-14712-3-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat May 3, 2013, 10:42 a.m. UTC
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
---
 drivers/input/mouse/gpio_mouse.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

Hans-Christian Noren Egtvedt May 3, 2013, 11:27 a.m. UTC | #1
Around Fri 03 May 2013 16:12:22 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>  drivers/input/mouse/gpio_mouse.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
> index 532eaca..6b44413 100644
> --- a/drivers/input/mouse/gpio_mouse.c
> +++ b/drivers/input/mouse/gpio_mouse.c
> @@ -138,7 +138,6 @@ static int gpio_mouse_probe(struct platform_device *pdev)
>  
>   out_free_polldev:
>  	input_free_polled_device(input_poll);
> -	platform_set_drvdata(pdev, NULL);
>  
>   out_free_gpios:
>  	while (--i >= 0) {
> @@ -165,8 +164,6 @@ static int gpio_mouse_remove(struct platform_device *pdev)
>  			gpio_free(pin);
>  	}
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
>
diff mbox

Patch

diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
index 532eaca..6b44413 100644
--- a/drivers/input/mouse/gpio_mouse.c
+++ b/drivers/input/mouse/gpio_mouse.c
@@ -138,7 +138,6 @@  static int gpio_mouse_probe(struct platform_device *pdev)
 
  out_free_polldev:
 	input_free_polled_device(input_poll);
-	platform_set_drvdata(pdev, NULL);
 
  out_free_gpios:
 	while (--i >= 0) {
@@ -165,8 +164,6 @@  static int gpio_mouse_remove(struct platform_device *pdev)
 			gpio_free(pin);
 	}
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }