From patchwork Wed Jul 17 14:34:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 2828680 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1F0549F9A0 for ; Wed, 17 Jul 2013 14:35:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C92D82024A for ; Wed, 17 Jul 2013 14:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C5EE201E4 for ; Wed, 17 Jul 2013 14:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519Ab3GQOfJ (ORCPT ); Wed, 17 Jul 2013 10:35:09 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:37084 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754741Ab3GQOfI (ORCPT ); Wed, 17 Jul 2013 10:35:08 -0400 Received: by mail-pb0-f47.google.com with SMTP id rr13so1966753pbb.34 for ; Wed, 17 Jul 2013 07:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=HJ8h9W1T6EHmZ8VDgn+NbQZlkAwlTPvKyUfn6N+YLh4=; b=PAM54aMNweKCCnOC0YRX1Bm8XqZeKbEmBKKLGi6fl6XqYN77EGviCLVVRr+pYdgobg oSY3icYtY4TBH0MuD+JIxym+H6w3JcRDTBbkROaFDoL3S7n+YxRHgRMKjjsoykvpK98j pTt6apMq6QbfeJx54ruAUwIMD+UhwFmTP+zj04k49EwcdjTkt/Lzao7ndnSlhL4wYmBh pVN06j+izmLmx88HaipuY8vCwexBeoiwsaUPqOvuiTPYaGWIWAweN7aG6LrAbwsJ2eRA P1wLj5g/z8ppaFIvk71buG7u+zSzT47rFw3FeFK+RqVMLPWmmHTVSp4qMtYFF+MAlvC+ cUYA== X-Received: by 10.66.232.101 with SMTP id tn5mr2894311pac.132.1374071707605; Wed, 17 Jul 2013 07:35:07 -0700 (PDT) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPSA id eq5sm8233877pbc.15.2013.07.17.07.35.05 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Jul 2013 07:35:06 -0700 (PDT) From: mathieu.poirier@linaro.org To: grant.likely@linaro.org, dmitry.torokhov@gmail.com Cc: devicetree-discuss@lists.ozlabs.org, john.stultz@linaro.org, linux-input@vger.kernel.org, kernel-team@android.com, mathieu.poirier@linaro.org Subject: [PATCH v5] Input: sysrq - DT binding for key sequence Date: Wed, 17 Jul 2013 08:34:57 -0600 Message-Id: <1374071697-30166-1-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.8.1.2 X-Gm-Message-State: ALoCoQmAGBQm+Bg1EG6wraiYHChUg9QYZemXFODwqvwIGHkLObD4HJrkgfNwsMeSOOOF0R1ROpkv Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Mathieu J. Poirier" Adding a simple device tree binding for the specification of key sequences. Definition of the keys found in the sequence are located in 'include/uapi/linux/input.h'. For the sysrq driver, holding the sequence of keys down for a specific amount of time will reset the system. Signed-off-by: Mathieu Poirier --- changes for v5: - Corrected error in binding definition. - Using helper macro to fetch the key sequence. - Removing white space. --- .../devicetree/bindings/input/input-reset.txt | 34 ++++++++++++++++++++ drivers/tty/sysrq.c | 37 ++++++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/input-reset.txt diff --git a/Documentation/devicetree/bindings/input/input-reset.txt b/Documentation/devicetree/bindings/input/input-reset.txt new file mode 100644 index 0000000..c69390c --- /dev/null +++ b/Documentation/devicetree/bindings/input/input-reset.txt @@ -0,0 +1,34 @@ +Input: sysrq reset sequence + +A simple binding to represent a set of keys as described in +include/uapi/linux/input.h. This is to communicate a +sequence of keys to the sysrq driver. Upon holding the keys +for a specified amount of time (if specified) the system is +sync'ed and reset. + +Key sequences are global to the system but all the keys in a +set must be coming from the same input device. + +The /chosen node should contain a 'linux,sysrq-reset-seq' child +node to define a set of keys. + +Required property: +sysrq-reset-seq: array of keycodes + +Optional property: +timeout-ms: duration keys must be pressed together in milliseconds +before generating a sysrq + +Example: + + chosen { + linux,sysrq-reset-seq { + keyset = <0x03 + 0x04 + 0x0a>; + timeout-ms = <3000>; + }; + }; + +Would represent KEY_2, KEY_3 and KEY_9. + diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index b51c154..ed8f00f 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -44,6 +44,7 @@ #include #include #include +#include #include #include @@ -671,6 +672,34 @@ static void sysrq_detect_reset_sequence(struct sysrq_state *state, } } +static void sysrq_of_get_keyreset_config(void) +{ + u32 key; + struct device_node *np; + struct property *prop; + const __be32 *p; + + np = of_find_node_by_path("/chosen/linux,sysrq-reset-seq"); + if (!np) { + pr_debug("No sysrq node found"); + return; + } + + /* reset in case a __weak definition was present */ + sysrq_reset_seq_len = 0; + + of_property_for_each_u32(np, "keyset", prop, p, key) { + if ((key == KEY_RESERVED || key > KEY_MAX) || + (sysrq_reset_seq_len == SYSRQ_KEY_RESET_MAX)) + break; + + sysrq_reset_seq[sysrq_reset_seq_len++] = (unsigned short)key; + } + + /* get reset timeout if any */ + of_property_read_u32(np, "timeout-ms", &sysrq_reset_downtime_ms); +} + static void sysrq_reinject_alt_sysrq(struct work_struct *work) { struct sysrq_state *sysrq = @@ -903,6 +932,7 @@ static inline void sysrq_register_handler(void) int error; int i; + /* first check if a __weak interface was instantiated */ for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) { key = platform_sysrq_reset_seq[i]; if (key == KEY_RESERVED || key > KEY_MAX) @@ -911,6 +941,13 @@ static inline void sysrq_register_handler(void) sysrq_reset_seq[sysrq_reset_seq_len++] = key; } + /* + * DT configuration takes precedence over anything + * that would have been defined via the __weak + * interface + */ + sysrq_of_get_keyreset_config(); + error = input_register_handler(&sysrq_handler); if (error) pr_err("Failed to register input handler, error %d", error);