From patchwork Thu Jul 18 13:21:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nestor Lopez Casado X-Patchwork-Id: 2829657 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1FD9F9F9CF for ; Thu, 18 Jul 2013 13:30:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EEDCE201BB for ; Thu, 18 Jul 2013 13:30:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C253220154 for ; Thu, 18 Jul 2013 13:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758547Ab3GRNaW (ORCPT ); Thu, 18 Jul 2013 09:30:22 -0400 Received: from na3sys009aog124.obsmtp.com ([74.125.149.151]:39341 "EHLO na3sys009aog124.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753943Ab3GRNaV (ORCPT ); Thu, 18 Jul 2013 09:30:21 -0400 Received: from mail-ea0-f173.google.com ([209.85.215.173]) (using TLSv1) by na3sys009aob124.postini.com ([74.125.148.12]) with SMTP ID DSNKUeft7GSSYcoWQSO3C1q8mlr/R24mOnV5@postini.com; Thu, 18 Jul 2013 06:30:21 PDT Received: by mail-ea0-f173.google.com with SMTP id g15so1754812eak.18 for ; Thu, 18 Jul 2013 06:30:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=SFOk86+eS/F621gvh1nETjkggL5Y2sng2SJ1jmrCpwY=; b=HeO5HN3FuMUEHc46d91nIqdMzMgtCbQW0Q0UEE8ys9MFAjmheQzwoqvtAFVsH/BdGt 93cl/GmD0fG9uOB3SmTNgLMYjrLIH2kpdABoP5TdTgDgj2AJenQqrYlni7vO1OxFSYDC OXKx/ppR1BfXjh2zZKhqnqZ/2Nt6yEMxsRRDIfWtVVPvb/IjPSZpAUCQTVsezyZlJg+X rrnhkS8W1q2zl8tAMf8F+mewBf/t/cXTnuBTwNZfjfjKROpu7wD6v1aGnd88N/7nCz4F mOD/2jFBl7kJT9NAjUwJYGUiE2ZDyWgykTkNXExAwKoUrPVqFaoqbzmdpKVDyi41lC3r KBew== X-Received: by 10.15.33.132 with SMTP id c4mr11480978eev.12.1374153719603; Thu, 18 Jul 2013 06:21:59 -0700 (PDT) X-Received: by 10.15.33.132 with SMTP id c4mr11480972eev.12.1374153719527; Thu, 18 Jul 2013 06:21:59 -0700 (PDT) Received: from ubuntu.localdomain ([195.81.139.13]) by mx.google.com with ESMTPSA id n42sm19190981eeh.15.2013.07.18.06.21.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Jul 2013 06:21:58 -0700 (PDT) From: Nestor Lopez Casado To: jkosina@suse.cz Cc: benjamin.tissoires@gmail.com, adlr@chromium.org, joseph.salisbury@canonical.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Nestor Lopez Casado Subject: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set Date: Thu, 18 Jul 2013 06:21:31 -0700 Message-Id: <1374153691-25100-2-git-send-email-nlopezcasad@logitech.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1374153691-25100-1-git-send-email-nlopezcasad@logitech.com> References: <1374153691-25100-1-git-send-email-nlopezcasad@logitech.com> X-Gm-Message-State: ALoCoQk1Au9Ry6b+klD3JFlEVYRhB907BiXQ7rRAYNu4/akcIu2yPsXDdCA3sfvMNJdksJa7BzfLkVp53+U2O5/F5jTOiw43Jg0p7bM9lYfTfCF/JtTncKa5tW2cUTL2TDb9d6ciYwYMQf9CCKfUwfzhgcqUeol8BTKcRWHUEcH6B3Faf8KkSYA= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Set querying_devices flag to true when we start the enumeration process. This was missing from the original patch. It never produced undesirable effects as it is highly improbable to have a second enumeration triggered while a first one was still in progress. Signed-off-by: Nestor Lopez Casado --- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 0d13389..d4657a5 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -488,6 +488,8 @@ static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev) if (djrcv_dev->querying_devices) return 0; + djrcv_dev->querying_devices = true; + dj_report = kzalloc(sizeof(struct dj_report), GFP_KERNEL); if (!dj_report) return -ENOMEM;