From patchwork Thu Aug 29 23:03:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ping Cheng X-Patchwork-Id: 2851635 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 66C41C0AB5 for ; Thu, 29 Aug 2013 23:04:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9AA8B20497 for ; Thu, 29 Aug 2013 23:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86DE520466 for ; Thu, 29 Aug 2013 23:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756431Ab3H2XEW (ORCPT ); Thu, 29 Aug 2013 19:04:22 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:51003 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754336Ab3H2XEW (ORCPT ); Thu, 29 Aug 2013 19:04:22 -0400 Received: by mail-pd0-f182.google.com with SMTP id r10so1063150pdi.27 for ; Thu, 29 Aug 2013 16:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=kO9jttU1dqbleA1lCe4J1od5FAPa8PevkAaC7o9fvm0=; b=KAbE8y3P5NUQk1WHJ3EXluNEwQqtcsW1lgRH0eNlifjpcGSywV9pCcMr6dgfni7m6x eq/QqZDvaIT8BTC5iNwVGaq9KaHXeTslPLY0UxxPefk4un9aaKOl0v8dtpo1ySvbZq4e fGmhsM9KM/leLg31iOzRRDgoqa7rxXYu9O/xCjeki1S4dsdRavjzvYrvjJRHyWffeYZC 2bhetAxz9Ie31fBAsnFLdm+huOcK6uT84o31pMGTRlE6NpBzrkt08VQClaK66I1mz0EW Sbjn0+7ehTj2EbnzdAHMT+lYdnDQ0aYoLJmy5zJFf4edinh57VAs/H6UVU0ehQ3DYSpx h2ig== X-Received: by 10.68.167.132 with SMTP id zo4mr6287651pbb.129.1377817461435; Thu, 29 Aug 2013 16:04:21 -0700 (PDT) Received: from wacom-XPS-8500.wacom.com ([67.51.163.2]) by mx.google.com with ESMTPSA id fk4sm43412579pab.23.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 29 Aug 2013 16:04:20 -0700 (PDT) From: Ping Cheng To: linux-input@vger.kernel.org Cc: dmitry.torokhov@gmail.com, Ping Cheng Subject: [PATCH 1/2] Input: wacom - testing result shows get_report is unnecessary. Date: Thu, 29 Aug 2013 16:03:47 -0700 Message-Id: <1377817427-29761-1-git-send-email-pingc@wacom.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Ping Cheng --- drivers/input/tablet/wacom_sys.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c index 79b69ea..1c70a8d 100644 --- a/drivers/input/tablet/wacom_sys.c +++ b/drivers/input/tablet/wacom_sys.c @@ -524,9 +524,6 @@ static int wacom_set_device_mode(struct usb_interface *intf, int report_id, int error = wacom_set_report(intf, WAC_HID_FEATURE_REPORT, report_id, rep_data, length, 1); - if (error >= 0) - error = wacom_get_report(intf, WAC_HID_FEATURE_REPORT, - report_id, rep_data, length, 1); } while ((error < 0 || rep_data[1] != mode) && limit++ < WAC_MSG_RETRIES); kfree(rep_data);