From patchwork Fri Sep 6 18:08:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2854801 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 05F889F494 for ; Fri, 6 Sep 2013 18:44:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 19A9E20375 for ; Fri, 6 Sep 2013 18:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D99C420371 for ; Fri, 6 Sep 2013 18:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086Ab3IFSI2 (ORCPT ); Fri, 6 Sep 2013 14:08:28 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:34397 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053Ab3IFSI1 (ORCPT ); Fri, 6 Sep 2013 14:08:27 -0400 Received: by mail-pb0-f44.google.com with SMTP id xa7so3531608pbc.17 for ; Fri, 06 Sep 2013 11:08:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q8khW6O49McPRnnQXlok4lMyMhTrC46ByP+R7cfrTr4=; b=EzCiVfMZdYSN1InbtW+YZNyt5wRy5t0Mv6MmM65ClNYUlB2DTLuu4cuLWwk/zoJyW5 Uv1W2o2rmEgank7dqOwnF3dESi8ToWLq2f/GzafXy2y/zm4u1AVg7IipbfP1ETRgqEwO x6tSLf0fQQFgBjhxNGY0m0uhaZDBr7C4QPJ8WczSpiV0xcKECLk6xpXL7SxbxYdYCkiY Wpflq/grKk6DsCjUv5GV+KQa85ul+ucg+nAeh0RdlldV2w4AaFuwHjbG9Ry5mtl5G/zO CoDrfKP23S+jmhDmgwiWuuJ6tqL71vP0X32sc3g/vmSbrrz4ak3HOtOGM7jB1D2wE5XK yG1g== X-Gm-Message-State: ALoCoQnEVBcOA0DdHePG4DssBfAnVR8Sg6suo1QNQHkjIt3MgqBM9v5/DQQqv5OFtJDSVLEGCA9h X-Received: by 10.68.252.233 with SMTP id zv9mr4348898pbc.69.1378490907231; Fri, 06 Sep 2013 11:08:27 -0700 (PDT) Received: from localhost.localdomain ([122.172.177.173]) by mx.google.com with ESMTPSA id va1sm2266727pbc.31.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 06 Sep 2013 11:08:26 -0700 (PDT) From: Sachin Kamat To: linux-input@vger.kernel.org Cc: dmitry.torokhov@gmail.com, sachin.kamat@linaro.org, Pau Oliva Fora Subject: [PATCH 3/4] Input: htcpen - Remove redundant dev_set_drvdata Date: Fri, 6 Sep 2013 23:38:07 +0530 Message-Id: <1378490888-5083-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1378490888-5083-1-git-send-email-sachin.kamat@linaro.org> References: <1378490888-5083-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver core sets the data to NULL upon release or probe failure. Hence explicit setting is not necessary. Signed-off-by: Sachin Kamat Cc: Pau Oliva Fora --- drivers/input/touchscreen/htcpen.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c index 6650085..92e2243 100644 --- a/drivers/input/touchscreen/htcpen.c +++ b/drivers/input/touchscreen/htcpen.c @@ -186,8 +186,6 @@ static int htcpen_isa_remove(struct device *dev, unsigned int id) release_region(HTCPEN_PORT_INIT, 1); release_region(HTCPEN_PORT_IRQ_CLEAR, 1); - dev_set_drvdata(dev, NULL); - return 0; }