diff mbox

[1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata

Message ID 1379652173-32477-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Sept. 20, 2013, 4:42 a.m. UTC 
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Barry Song <21cnbao@gmail.com>
---
Series compile tested.
---
 drivers/input/misc/ad714x-spi.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Sept. 20, 2013, 4:39 p.m. UTC | #1 
On Fri, Sep 20, 2013 at 10:12:50AM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Barry Song <21cnbao@gmail.com>
> ---
> Series compile tested.

Applied all 4, thank you.

> ---
>  drivers/input/misc/ad714x-spi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/ad714x-spi.c b/drivers/input/misc/ad714x-spi.c
> index 6189148..3a90b71 100644
> --- a/drivers/input/misc/ad714x-spi.c
> +++ b/drivers/input/misc/ad714x-spi.c
> @@ -108,7 +108,6 @@ static int ad714x_spi_remove(struct spi_device *spi)
>  	struct ad714x_chip *chip = spi_get_drvdata(spi);
>  
>  	ad714x_remove(chip);
> -	spi_set_drvdata(spi, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/drivers/input/misc/ad714x-spi.c b/drivers/input/misc/ad714x-spi.c
index 6189148..3a90b71 100644
--- a/drivers/input/misc/ad714x-spi.c
+++ b/drivers/input/misc/ad714x-spi.c
@@ -108,7 +108,6 @@  static int ad714x_spi_remove(struct spi_device *spi)
 	struct ad714x_chip *chip = spi_get_drvdata(spi);
 
 	ad714x_remove(chip);
-	spi_set_drvdata(spi, NULL);
 
 	return 0;
 }