From patchwork Fri Oct 4 12:53:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 2988671 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ED419BFF0B for ; Fri, 4 Oct 2013 12:53:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B14C32035D for ; Fri, 4 Oct 2013 12:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99B5520374 for ; Fri, 4 Oct 2013 12:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579Ab3JDMxa (ORCPT ); Fri, 4 Oct 2013 08:53:30 -0400 Received: from mail-we0-f178.google.com ([74.125.82.178]:58073 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415Ab3JDMx2 (ORCPT ); Fri, 4 Oct 2013 08:53:28 -0400 Received: by mail-we0-f178.google.com with SMTP id q59so3766952wes.9 for ; Fri, 04 Oct 2013 05:53:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SCynWvYLhjjKpd85ntlauOvse6tLEubjWXDqMUrE4Z8=; b=d/sgX74mTt6K5LqlwallfdiHX3V4FYpa3A2Jq8bOAbhJFbMngyTRAxnwUC7OKPF2im k4J/ipEatyhqrnfgnQzGFwUU8I9OZjAZWYdOTPTToop0he/ChdvTi5lKTXQlFrdSZw2F muJzSdfE+Q+tyRRIcb8TG/neyX+YQ2t/i3Oy4YjQIc7ayHFL4ZPlxIFbnE+IhezHQPQD t7FgaY704D9zY9jec2wLpuGn4ICp9aliemUcwqAmEr0O9CG5s/o/AK3y31IUOQeNLEhT BA9P87iI3nIjYAkLvRvWt6q8SkFJOLboc/GFy8WKrz1VkIEXP87AlB5gMBYMXASjjniu Nplg== X-Gm-Message-State: ALoCoQmBng06oos0Ti6l5OkBYmALlyeafOlGLI8J/54TmJfMuN/ZGkcTpHMES/++v3chClaI+RRM X-Received: by 10.194.75.165 with SMTP id d5mr12089987wjw.18.1380891207609; Fri, 04 Oct 2013 05:53:27 -0700 (PDT) Received: from localhost.localdomain ([190.2.109.48]) by mx.google.com with ESMTPSA id ev4sm9386566wib.7.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2013 05:53:27 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Ezequiel Garcia , Daniel Mack , Dmitry Torokhov , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH v2 2/2] input: rotary-encoder: Add 'on-each-step' to binding documentation Date: Fri, 4 Oct 2013 09:53:23 -0300 Message-Id: <1380891203-17617-3-git-send-email-ezequiel@vanguardiasur.com.ar> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: <1380891203-17617-1-git-send-email-ezequiel@vanguardiasur.com.ar> References: <1380891203-17617-1-git-send-email-ezequiel@vanguardiasur.com.ar> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver now supports a new mode to handle the interruptions generated by the device: on this new mode an input event is generated on each step (i.e. on each IRQ). Therefore, add a new DT property, to select the mode: 'rotary-encoder,on-each-step'. Cc: Daniel Mack Cc: Dmitry Torokhov Cc: Rob Herring Cc: devicetree@vger.kernel.org Signed-off-by: Ezequiel Garcia --- I'm not at all happy with this DT binding as it's way to customized for the current driver. For instance, if we want to support mapping key events (or better arbitrary linux-input event types) it seems there's no easy way to fix the binding. Maybe a better way of handling the different 'modes' is through compatible strings? I'm not really sure, so I hope the DT guys have some comment on this. Documentation/devicetree/bindings/input/rotary-encoder.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b/Documentation/devicetree/bindings/input/rotary-encoder.txt index 3315495..b89e38d 100644 --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt @@ -15,6 +15,7 @@ Optional properties: - rotary-encoder,rollover: Automatic rollove when the rotary value becomes greater than the specified steps or smaller than 0. For absolute axis only. - rotary-encoder,half-period: Makes the driver work on half-period mode. +- rotary-encoder,on-each-step: Makes the driver send an event on each step. See Documentation/input/rotary-encoder.txt for more information.