| Message ID | 1385838747.2760.4.camel@deadeye.wl.decadent.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On 30/11/13 14:12, Ben Hutchings wrote: > The change to support Genius Manticore Keyboard also changed behaviour > for Genius Gx Imperator Keyboard, as there is no break between the > cases. This is presumably a mistake. > > Reported by Coverity as CID 1134029. > > Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard') > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > --- > drivers/hid/hid-kye.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c > index ecb5ca6..e776963 100644 > --- a/drivers/hid/hid-kye.c > +++ b/drivers/hid/hid-kye.c > @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc, > case USB_DEVICE_ID_GENIUS_GX_IMPERATOR: > rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83, > "Genius Gx Imperator Keyboard"); > + break; > case USB_DEVICE_ID_GENIUS_MANTICORE: > rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104, > "Genius Manticore Keyboard"); > Jiri already applied this one, but FWIW: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Thanks for spotting this, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c index ecb5ca6..e776963 100644 --- a/drivers/hid/hid-kye.c +++ b/drivers/hid/hid-kye.c @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc, case USB_DEVICE_ID_GENIUS_GX_IMPERATOR: rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83, "Genius Gx Imperator Keyboard"); + break; case USB_DEVICE_ID_GENIUS_MANTICORE: rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104, "Genius Manticore Keyboard");
The change to support Genius Manticore Keyboard also changed behaviour for Genius Gx Imperator Keyboard, as there is no break between the cases. This is presumably a mistake. Reported by Coverity as CID 1134029. Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard') Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- drivers/hid/hid-kye.c | 1 + 1 file changed, 1 insertion(+)