From patchwork Mon Dec 2 23:17:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Gay X-Patchwork-Id: 3272441 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A305C9F373 for ; Mon, 2 Dec 2013 23:36:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DD43C20373 for ; Mon, 2 Dec 2013 23:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0120420364 for ; Mon, 2 Dec 2013 23:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128Ab3LBXfa (ORCPT ); Mon, 2 Dec 2013 18:35:30 -0500 Received: from [195.81.139.13] ([195.81.139.13]:35262 "EHLO soller.eu.logitech.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752575Ab3LBXf3 (ORCPT ); Mon, 2 Dec 2013 18:35:29 -0500 X-Greylist: delayed 1067 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Dec 2013 18:35:29 EST Received: from ogay by soller.eu.logitech.com with local (Exim 4.72) (envelope-from ) id 1VnckF-0005cC-Ph; Tue, 03 Dec 2013 00:17:39 +0100 From: Olivier Gay To: linux-input@vger.kernel.org Cc: Jiri Kosina , linux-kernel@vger.kernel.org, Olivier Gay , Nestor Lopez Casado , Mathieu Meisser Subject: [PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig Date: Tue, 3 Dec 2013 00:17:24 +0100 Message-Id: <1386026244-21553-1-git-send-email-ogay@logitech.com> X-Mailer: git-send-email 1.8.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP hid-logitech-dj.c driver needs hidraw to work correctly. Without hidraw, hid-logitech-dj.c fails during probe() and Logitech Unifying devices HID reports aren't recognized. Signed-off-by: Olivier Gay Signed-off-by: Nestor Lopez Casado Signed-off-by: Mathieu Meisser --- Hi everyone, this adds a HIDRAW dependency in Kconfig for hid-logitech-dj.c driver. The driver uses hidraw and needs it to work correctly. Without hidraw if a Logitech Unifying device is plugged, the driver fails during probe() and Logitech Unifying devices HID reports aren't recognized. This has been the cause of some confusion. Some Linux and Android distributions had HID_LOGITECH_DJ enabled without HIDRAW and the Unifying mice and keyboards would simply not work (no cursor tracking / no keyboard typing). Best regards, Olivier drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 329fbb9..c8a66b9 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -344,6 +344,7 @@ config HID_LOGITECH config HID_LOGITECH_DJ tristate "Logitech Unifying receivers full support" + depends on HIDRAW depends on HID_LOGITECH ---help--- Say Y if you want support for Logitech Unifying receivers and devices.