From patchwork Tue Feb 25 15:47:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Jackson X-Patchwork-Id: 3717741 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ACE9EBF13A for ; Tue, 25 Feb 2014 15:47:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 98BD42018E for ; Tue, 25 Feb 2014 15:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7644C2017E for ; Tue, 25 Feb 2014 15:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbaBYPrK (ORCPT ); Tue, 25 Feb 2014 10:47:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbaBYPrJ (ORCPT ); Tue, 25 Feb 2014 10:47:09 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1PFl8C0003258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Feb 2014 10:47:08 -0500 Received: from hyoscyamine.boston.devel.redhat.com (dhcp-10-19-61-247.boston.devel.redhat.com [10.19.61.247]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1PFl7ov021052; Tue, 25 Feb 2014 10:47:07 -0500 From: Adam Jackson To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Peter Jones Subject: [PATCH] i8042: Don't print an error message just because there's no chip Date: Tue, 25 Feb 2014 10:47:07 -0500 Message-Id: <1393343227-13092-1-git-send-email-ajax@redhat.com> In-Reply-To: <1222713404-1097-1-git-send-email-ajax@redhat.com> References: <1222713404-1097-1-git-send-email-ajax@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Peter Jones Some systems, such as EFI-based Apple systems, won't necessarily have an i8042 to initialize. We shouldn't be printing an error message in this case, since not detecting the chip is the correct behavior. v2: Downgrade to pr_notice instead of pr_err. Signed-off-by: Adam Jackson Reviewed-by: Josh Boyer Reviewed-by: Benjamin Tissoires --- drivers/input/serio/i8042.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 020053f..05c6285 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void) static int i8042_controller_check(void) { if (i8042_flush()) { - pr_err("No controller found\n"); + pr_notice("No controller found\n"); return -ENODEV; }