From patchwork Sat Apr 26 11:57:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Mal=C3=BD?= X-Patchwork-Id: 4068431 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 34A5ABFF02 for ; Sat, 26 Apr 2014 12:09:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D4B120279 for ; Sat, 26 Apr 2014 12:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79C5820256 for ; Sat, 26 Apr 2014 12:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbaDZMIS (ORCPT ); Sat, 26 Apr 2014 08:08:18 -0400 Received: from prifuk.cz ([31.31.77.140]:49887 "EHLO smtp.devoid-pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbaDZMDp (ORCPT ); Sat, 26 Apr 2014 08:03:45 -0400 Received: from localhost.localdomain (cst-prg-5-22.cust.vodafone.cz [46.135.5.22]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by smtp.devoid-pointer.net (Postfix) with ESMTPSA id 3422A20BAD; Sat, 26 Apr 2014 14:03:41 +0200 (CEST) From: =?UTF-8?q?Michal=20Mal=C3=BD?= To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com, anssi.hannula@iki.fi, simon@mungewell.org, =?UTF-8?q?Michal=20Mal=C3=BD?= Subject: [PATCH v3 16/24] hid: Port hid-sony to ff-memless-next Date: Sat, 26 Apr 2014 13:57:53 +0200 Message-Id: <1398513696-12626-17-git-send-email-madcatxster@devoid-pointer.net> X-Mailer: git-send-email 1.9.2 In-Reply-To: <1398513696-12626-1-git-send-email-madcatxster@devoid-pointer.net> References: <1398513696-12626-1-git-send-email-madcatxster@devoid-pointer.net> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Port hid-sony to ff-memless-next Signed-off-by: Michal Malý --- drivers/hid/Kconfig | 2 +- drivers/hid/hid-sony.c | 24 ++++++++++++++++++------ 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 9260d14..e97c382 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -634,7 +634,7 @@ config HID_SONY config SONY_FF bool "Sony PS2/3/4 accessories force feedback support" depends on HID_SONY - select INPUT_FF_MEMLESS + select INPUT_FF_MEMLESS_NEXT ---help--- Say Y here if you have a Sony PS2/3/4 accessory and want to enable force feedback support for it. diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 908de27..95bb2e1 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "hid-ids.h" @@ -53,6 +54,7 @@ #define SONY_BATTERY_SUPPORT (SIXAXIS_CONTROLLER | DUALSHOCK4_CONTROLLER) #define SONY_FF_SUPPORT (SIXAXIS_CONTROLLER | DUALSHOCK4_CONTROLLER) +#define FF_UPDATE_RATE 50 #define MAX_LEDS 4 static const u8 sixaxis_rdesc_fixup[] = { @@ -1308,16 +1310,25 @@ static void dualshock4_state_worker(struct work_struct *work) #ifdef CONFIG_SONY_FF static int sony_play_effect(struct input_dev *dev, void *data, - struct ff_effect *effect) + const struct mlnx_effect_command *command) { struct hid_device *hid = input_get_drvdata(dev); struct sony_sc *sc = hid_get_drvdata(hid); + const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force; - if (effect->type != FF_RUMBLE) - return 0; - sc->left = effect->u.rumble.strong_magnitude / 256; - sc->right = effect->u.rumble.weak_magnitude / 256; + switch (command->cmd) { + case MLNX_START_RUMBLE: + sc->left = rumble_force->strong / 256; + sc->right = rumble_force->weak / 256; + break; + case MLNX_STOP_RUMBLE: + sc->left = 0; + sc->right = 0; + break; + default: + return -EINVAL; + } schedule_work(&sc->state_worker); return 0; @@ -1330,7 +1341,7 @@ static int sony_init_ff(struct hid_device *hdev) struct input_dev *input_dev = hidinput->input; input_set_capability(input_dev, EV_FF, FF_RUMBLE); - return input_ff_create_memless(input_dev, NULL, sony_play_effect); + return input_ff_create_mlnx(input_dev, NULL, sony_play_effect, FF_UPDATE_RATE); } #else @@ -1762,6 +1773,7 @@ static const struct hid_device_id sony_devices[] = { .driver_data = DUALSHOCK4_CONTROLLER_USB }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER), .driver_data = DUALSHOCK4_CONTROLLER_BT }, + { } }; MODULE_DEVICE_TABLE(hid, sony_devices);