Message ID | 1402694473-11518-3-git-send-email-ulrik.debie-os@e2big.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi On Fri, Jun 13, 2014 at 11:21 PM, Ulrik De Bie <ulrik.debie-os@e2big.org> wrote: > Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org> This patch lacks _any_ explanation why this is done. Please always write commit-messages! It is totally unclear from the patch description why the device is reset. Thanks David > --- > drivers/input/mouse/elantech.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 0eb185b..fa150d9 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -1617,6 +1617,7 @@ int elantech_init(struct psmouse *psmouse) > sysfs_remove_group(&psmouse->ps2dev.serio->dev.kobj, > &elantech_attr_group); > init_fail: > + psmouse_reset(psmouse); > kfree(etd); > return error; > } > -- > 2.0.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 0eb185b..fa150d9 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1617,6 +1617,7 @@ int elantech_init(struct psmouse *psmouse) sysfs_remove_group(&psmouse->ps2dev.serio->dev.kobj, &elantech_attr_group); init_fail: + psmouse_reset(psmouse); kfree(etd); return error; }
Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org> --- drivers/input/mouse/elantech.c | 1 + 1 file changed, 1 insertion(+)