| Message ID | 1406385747-2444-1-git-send-email-jm@lentin.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Sat, Jul 26, 2014 at 03:42:27PM +0100, Jamie Lentin wrote: > Signed-off-by: Jamie Lentin <jm@lentin.co.uk> > --- > drivers/hid/hid-lenovo.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c > index a56b9e7..f96bf09 100644 > --- a/drivers/hid/hid-lenovo.c > +++ b/drivers/hid/hid-lenovo.c > @@ -350,6 +350,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) > size_t name_sz = strlen(dev_name(dev)) + 16; > char *name_mute, *name_micmute; > int i; > + int ret; > > /* > * Only register extra settings against subdevice where input_mapping > @@ -368,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) > if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2)) > return -ENODEV; > > - if (sysfs_create_group(&hdev->dev.kobj, > - &lenovo_attr_group_tpkbd)) { > - hid_warn(hdev, "Could not create sysfs group\n"); > - } > + ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd); > + if (ret) > + hid_warn(hdev, "Could not create sysfs group: %d\n", ret); Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks.
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index a56b9e7..f96bf09 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -350,6 +350,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) size_t name_sz = strlen(dev_name(dev)) + 16; char *name_mute, *name_micmute; int i; + int ret; /* * Only register extra settings against subdevice where input_mapping @@ -368,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2)) return -ENODEV; - if (sysfs_create_group(&hdev->dev.kobj, - &lenovo_attr_group_tpkbd)) { - hid_warn(hdev, "Could not create sysfs group\n"); - } + ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd); + if (ret) + hid_warn(hdev, "Could not create sysfs group: %d\n", ret); data_pointer = devm_kzalloc(&hdev->dev, sizeof(struct lenovo_drvdata_tpkbd),
Signed-off-by: Jamie Lentin <jm@lentin.co.uk> --- drivers/hid/hid-lenovo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)